Status Update
Comments
il...@google.com <il...@google.com> #2
Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).
ha...@gmail.com <ha...@gmail.com>
il...@google.com <il...@google.com> #3
I have a similar issue with plain AnimatorSet:
set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()
doesn't play animation in resume().
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #4
Should clarify that if I filter out setCurrentPlayTime(0)
(or replace it with setCurrentPlayTime(1)
) it works well.
Also even with setCurrentPlayTime(0)
, onAnimationEnd
is notified with correct delay (as if the animation has played).
il...@google.com <il...@google.com> #5
@
I think that is intended for Animator. If you set the currentPlayTime
to 0 or the total duration the animator completes. We do some
an...@google.com <an...@google.com> #6
Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.
Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45:
TransitionSet@e133f9a:
Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45:
TransitionSet@e133f9a:
Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
Still digging.
il...@google.com <il...@google.com> #7
Branch: androidx-main
commit 567b7459329d1ec8d27a8c6fe1c4a86442065d7d
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 26 20:06:54 2023
Add additional logging for transitions
Adding more debug logging in transitions to track the entering and
exiting transitions as well as the final merged transition and its
targets.
Test: added logging
Bug: 300157785
Change-Id: I0d9ad72b865422493c6c895ddb6115abf85eed16
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt
Description
Version used: 1.1.0-beta01
For any given fragment backstack, if the fragment to be popped off the backstack is the current primary navigation fragment, this results in a NullPointerException on that popped fragment's FragmentManager receiving notification that the primary navigation fragment changed. Because that fragment is being removed, it no longer has a host nor a reference to that host's FragmentManager. Specifically, this happens at androidx.fragment.app.Fragment.performPrimaryNavigationFragmentChanged, line 2662 (mFragmentManager is null).
Example:
fragmentManager.beginTransaction()
.add(containerId, FragmentA())
.commit()
Current backstack:
A (not primary)
Transaction adding a new fragment that is to be a primary nav fragment:
val fragmentB = FragmentB()
fragmentManager.beginTransaction()
.addToBackStack(null)
.setPrimaryNavigationFragment(fragmentB)
.replace(containerId, fragmentB)
.commit()
Current backstack:
A -> B (primary)
If activity.onBackPress() or fragmentManager.popBackStack() is called, as B is being popped, the FragmentManager's primary nav fragment is set to null, and B (that is now removed) notifies its host FragmentManager of this change (which B no longer has a host because it was removed).