Fixed
Status Update
No update yet.
Comments
kc...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
kc...@google.com
kc...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
ev...@tatarka.me
The issue we were seeing on Samsung drives is it is very easy to fat-finger and tap the screen because the fingerprint sensor is on the front. This was with the compat dialog. I think always setting Dialog#setCanceledOnTouchOutside(false) is a reasonable solution as you can still use the back button to cancel the dialog.
kc...@google.com
The safer way seems to me like disallowing the library from being dismissed from taps outside. The back button is still there, which gives the user an escape hatch.
kc...@google.com
Attached wrong bug number, fixed in following commit
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2aa297a0d4a014a06766b1658b6c9438ecff30fc
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 16:42:48 2019
Do not allow the fingerprint dialog to be canceled due to touches outside
It's safer to disallow this, since on some devices the sensor is on the
home button, etc, where it's easier to miss. Since the support library
is supposed to simplify developer's lives, we should just default to
preventing this on all pre-P devices, rather than potentially exposing
an API for developers to toggle based on device type (too complicated).
Fixes: 125447052
Test: Touches outside no longer cancel authentication. Back button cancels
authentication still.
Change-Id: I6639b2ecdf18f82a242fffba63eeb8ca45d53dc9
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
https://android-review.googlesource.com/1087531
https://goto.google.com/android-sha1/2aa297a0d4a014a06766b1658b6c9438ecff30fc
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2aa297a0d4a014a06766b1658b6c9438ecff30fc
Author: Kevin Chyn <kchyn@google.com>
Date: Thu Jul 18 16:42:48 2019
Do not allow the fingerprint dialog to be canceled due to touches outside
It's safer to disallow this, since on some devices the sensor is on the
home button, etc, where it's easier to miss. Since the support library
is supposed to simplify developer's lives, we should just default to
preventing this on all pre-P devices, rather than potentially exposing
an API for developers to toggle based on device type (too complicated).
Fixes: 125447052
Test: Touches outside no longer cancel authentication. Back button cancels
authentication still.
Change-Id: I6639b2ecdf18f82a242fffba63eeb8ca45d53dc9
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
su...@gmail.com
I didn't get how you marked it to fixed. I'm using Honor 9 Lite phone and clicking outside the Biometric prompt is still cancelling the dialog
an...@gmail.com
Using Xiaomi Mi A2, when the biometricprompt comes up and i press outside the dialog box, the biometric prompt closes. I'm using androidx.biometric:biometric:1.0.1 library
pu...@gmail.com
Using Vivo v11 Pro and OnePlus 7 Pro, when the biometricprompt comes up and I press outside the dialog box or press the back button, the biometric prompt closes. I'm using androidx.biometric:biometric:1.2.0_alpha01 library.
How can I prevent this?
How can I prevent this?
ri...@brainvire.com
Any updates regarding solution to this issue?
[Deleted User] <[Deleted User]>
this issue still exists, kindly re-verify it ..
ja...@gmail.com
this issue still exists, kindly re-verify it , even in alpha version.
94...@gmail.com
this issue is still there, please retest and provide fix.
ma...@gmail.com
Not fixed and not work on emulator Nexus 5x API 33
Description
Version used: 1.0.0-alpha03
Devices/Android versions reproduced on: Samsung S7 Android 8.0.0, Pixel Android 9, Huawei Mate 20 lite Android 8.1.0
When using the BiometricPrompt, it is cancelled when the user touches outside the dialog asking for biometric verification. This is especially problematic when the dialog appears in the middle of the screen and the fingerprint scanner is on the home button, like on the Samsung S7. The problem is that the user will touch the screen while verifying and so accidentally cancel the verification.
Request:
Allow functionality like DialogFragment#setCancelable(boolean) or Dialog#setCanceledOnTouchOutside() to be set through BiometricPrompt.PromptInfo.Builder (for relevant implementations).