Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c12a9ca3231ddd7b19cc1a385aba8811a3b4a40e
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Fri Jun 21 10:08:09 2019
Don't declare EntityAdapters with raw types in generated code.
For Kotlin interoperability, adapter methods that take Iterable now
extend their type args to take subclasses of T, something that was
already accepted. This is because Kotlin's collection declarations are
`? extends T`.
Bug: 135747255
Test: Existing test pass.
Change-Id: Ie6f1df9e16c97f5a3dfd9c11e382d0ec44b55ef0
M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/compiler/src/test/data/daoWriter/output/DeletionDao.java
M room/compiler/src/test/data/daoWriter/output/UpdateDao.java
M room/compiler/src/test/data/daoWriter/output/WriterDao.java
M room/runtime/api/restricted_2.2.0-alpha01.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/EntityDeletionOrUpdateAdapter.java
M room/runtime/src/main/java/androidx/room/EntityInsertionAdapter.java
https://android-review.googlesource.com/987586
https://goto.google.com/android-sha1/c12a9ca3231ddd7b19cc1a385aba8811a3b4a40e
Branch: androidx-master-dev
commit c12a9ca3231ddd7b19cc1a385aba8811a3b4a40e
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Fri Jun 21 10:08:09 2019
Don't declare EntityAdapters with raw types in generated code.
For Kotlin interoperability, adapter methods that take Iterable now
extend their type args to take subclasses of T, something that was
already accepted. This is because Kotlin's collection declarations are
`? extends T`.
Bug: 135747255
Test: Existing test pass.
Change-Id: Ie6f1df9e16c97f5a3dfd9c11e382d0ec44b55ef0
M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/compiler/src/test/data/daoWriter/output/DeletionDao.java
M room/compiler/src/test/data/daoWriter/output/UpdateDao.java
M room/compiler/src/test/data/daoWriter/output/WriterDao.java
M room/runtime/api/restricted_2.2.0-alpha01.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/EntityDeletionOrUpdateAdapter.java
M room/runtime/src/main/java/androidx/room/EntityInsertionAdapter.java
da...@google.com <da...@google.com>
ih...@gmail.com <ih...@gmail.com> #3
You modified methods
insert(Iterable<? extends T> entities)
But forgot
insertAndReturnIdsArray(Collection<T> entities)
insertAndReturnIdsArrayBox(Collection<T> entities)
insertAndReturnIdsList(Collection<T> entities)
I am right?
insert(Iterable<? extends T> entities)
But forgot
insertAndReturnIdsArray(Collection<T> entities)
insertAndReturnIdsArrayBox(Collection<T> entities)
insertAndReturnIdsList(Collection<T> entities)
I am right?
Description
private final EntityDeletionOrUpdateAdapter __deletionAdapterOfDataStatus;
^
missing type arguments for generic class EntityDeletionOrUpdateAdapter<T>
where T is a type-variable:
T extends Object declared in class EntityDeletionOrUpdateAdapter