Apply benchmark plugin to internal benchmark modules [135927863]

Fixed

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Jun 24, 2019 05:59PM

We need to validate the way it's used to run benchmarks, e.g. copying the benchmark data off device, and the Q storage workaround.

Comments

du...@google.com <du...@google.com> Jul 26, 2019 09:56PM

Accepted by du...@google.com.

ap...@google.com <ap...@google.com> #2Jul 29, 2019 11:13PM

Marked as fixed.

I highly support this, this way every current FormGroup subclass can define only the functions it needs (Everything besides Address can get rid of the AutofillType API and of the app_locale parameters, many classes could also get rid of the VerificationStatus API, etc.)

AutofillProfile could then implement a GetDataForType(FieldType) -> absl::variant<Address, NameInfo, ...> and provide the current API with visit calls instead of polymorphism.

ap...@google.com <ap...@google.com> #3Apr 28, 2024 01:18AM

Relevant prior discussion: https://chromium-review.googlesource.com/c/chromium/src/+/6197978/comments/3ac57e7a_d168059a

Issue 135927863

Description

Issue summary

Comments

du...@google.com <du...@google.com> Jul 26, 2019 09:56PM

ap...@google.com <ap...@google.com> #2Jul 29, 2019 11:13PM

ap...@google.com <ap...@google.com> #3Apr 28, 2024 01:18AM

Add comment

Issue metadata