PreviewChannelHelper.getAllChannels() crashes on API <26 [136123939]

Fixed

Bug

Status Update

No update yet.

Description

ow...@google.com

created issue #1

Jun 27, 2019 12:53AM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): androidx.tvprovider:tvprovider:1.0.0
Version used: 1.0.0
Theme used: N/A
Devices/Android versions reproduced on: Android TV API 22 Emulator

- Relevant code to trigger the issue. `PreviewChannelHelper(context).getAllChannels()`

This issue is not unique to this method, but rather a design flaw assuming that the relevant URI exists in the content provider. Furthermore, the issue could be triggered on devices with API level 26+ if the Android O home screen launcher is not present (e.g. due to OEM customization).

Comments

ra...@google.com <ra...@google.com> #2May 8, 2020 03:39AM

Reassigned to ra...@google.com.

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

ra...@google.com <ra...@google.com> #3May 8, 2020 03:41AM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

ra...@google.com <ra...@google.com> #4May 13, 2020 05:58PM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

ap...@google.com <ap...@google.com> #5May 27, 2020 04:13PM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

ra...@google.com <ra...@google.com> #6Sep 2, 2020 07:16AM

Marked as fixed.

Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.

Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})

Still digging.

Issue 136123939