Fixed
Status Update
No update yet.
Comments
ra...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ra...@google.com
ra...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5c8efcf6fed783b67bcaa11ec4831075011de9a2
Author: Rahul Arora <raharora@google.com>
Date: Wed May 13 22:49:55 2020
Adding no-op in PreviewChannel classes for API<26
Bug: 136123939
Test: Ran a sample TV App with Emulator having API version=24 and
invoked all the public methods of PreviewChannelHelper class and
verified the desired no-op behavior.
./gradlew buildOnServer : Successful
Change-Id: If165ec032cf528af7e801b64b50ade6cec4274b7
M tv-provider/tv-provider/api/1.1.0-alpha01.txt
M tv-provider/tv-provider/api/current.txt
M tv-provider/tv-provider/api/public_plus_experimental_1.1.0-alpha01.txt
M tv-provider/tv-provider/api/public_plus_experimental_current.txt
M tv-provider/tv-provider/api/restricted_1.1.0-alpha01.txt
M tv-provider/tv-provider/api/restricted_current.txt
M tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannelHelper.java
https://android-review.googlesource.com/1310579
Branch: androidx-master-dev
commit 5c8efcf6fed783b67bcaa11ec4831075011de9a2
Author: Rahul Arora <raharora@google.com>
Date: Wed May 13 22:49:55 2020
Adding no-op in PreviewChannel classes for API<26
Bug: 136123939
Test: Ran a sample TV App with Emulator having API version=24 and
invoked all the public methods of PreviewChannelHelper class and
verified the desired no-op behavior.
./gradlew buildOnServer : Successful
Change-Id: If165ec032cf528af7e801b64b50ade6cec4274b7
M tv-provider/tv-provider/api/1.1.0-alpha01.txt
M tv-provider/tv-provider/api/current.txt
M tv-provider/tv-provider/api/public_plus_experimental_1.1.0-alpha01.txt
M tv-provider/tv-provider/api/public_plus_experimental_current.txt
M tv-provider/tv-provider/api/restricted_1.1.0-alpha01.txt
M tv-provider/tv-provider/api/restricted_current.txt
M tv-provider/tv-provider/src/main/java/androidx/tvprovider/media/tv/PreviewChannelHelper.java
ra...@google.com
This was fixed and released as part of latest TV Provider release.
https://developer.android.com/jetpack/androidx/releases/tvprovider#1.1.0-alpha01
I'm resolving this ticket.
Feel free to re-open this in case of any issues.
I'm resolving this ticket.
Feel free to re-open this in case of any issues.
Description
Version used: 1.0.0
Theme used: N/A
Devices/Android versions reproduced on: Android TV API 22 Emulator
- Relevant code to trigger the issue. `PreviewChannelHelper(context).getAllChannels()`
This issue is not unique to this method, but rather a design flaw assuming that the relevant URI exists in the content provider. Furthermore, the issue could be triggered on devices with API level 26+ if the Android O home screen launcher is not present (e.g. due to OEM customization).