Fixed
Status Update
No update yet.
Comments
da...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e098f49838f5505b77c47d0a88b675430338fc77
Author: Eugene Susla <eugenesusla@google.com>
Date: Tue Feb 04 16:42:20 2020
Allow conditional startActivityForResult in ActivityResultContract
This adds an extra superclass for ActivityResultContract, that allows
customizing the action to start the activity.
This allows the common "short-circuit" behavior.
Also allows us to get rid of permissions-specific APIs.
Bug: 137198065
Bug: 151110799
Test: use the testapp to manually trigger requests,
rotating phone in the process.
Change-Id: I9d1e6f5be70406194ea30a43980389fc985125f3
M activity/activity/api/1.2.0-alpha03.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha03.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha03.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.java
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContract.java
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContracts.java
https://android-review.googlesource.com/1238800
Branch: androidx-master-dev
commit e098f49838f5505b77c47d0a88b675430338fc77
Author: Eugene Susla <eugenesusla@google.com>
Date: Tue Feb 04 16:42:20 2020
Allow conditional startActivityForResult in ActivityResultContract
This adds an extra superclass for ActivityResultContract, that allows
customizing the action to start the activity.
This allows the common "short-circuit" behavior.
Also allows us to get rid of permissions-specific APIs.
Bug: 137198065
Bug: 151110799
Test: use the testapp to manually trigger requests,
rotating phone in the process.
Change-Id: I9d1e6f5be70406194ea30a43980389fc985125f3
M activity/activity/api/1.2.0-alpha03.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha03.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha03.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.java
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContract.java
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContracts.java
ch...@googlemail.com
This has been fixed internally and will be available in the Activity 1.2.0-alpha03 release.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit a5cc0f5a1ec46393491c24cdaaa566a4a53fa92b
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Jul 01 15:47:14 2019
Use correct setter name when reading from cursor via field assignment.
Bug: 136194628
Test: /gradlew room:integration-tests:room-testapp:cC
Change-Id: I3faab69b4a19de38b862e355448d0ddcff9bdd08
M room/compiler/src/main/kotlin/androidx/room/writer/FieldReadWriteWriter.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/PojoTest.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/ProductDao.java
A room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Review.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/SampleDatabase.java
https://android-review.googlesource.com/1008209
https://goto.google.com/android-sha1/a5cc0f5a1ec46393491c24cdaaa566a4a53fa92b
Branch: androidx-master-dev
commit a5cc0f5a1ec46393491c24cdaaa566a4a53fa92b
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Jul 01 15:47:14 2019
Use correct setter name when reading from cursor via field assignment.
Bug: 136194628
Test: /gradlew room:integration-tests:room-testapp:cC
Change-Id: I3faab69b4a19de38b862e355448d0ddcff9bdd08
M room/compiler/src/main/kotlin/androidx/room/writer/FieldReadWriteWriter.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/PojoTest.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/ProductDao.java
A room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/Review.java
M room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/SampleDatabase.java
da...@google.com
A fix for this will be available in Room 2.2.0-alpha02
Description
Version used: 1.2.0
When I define an entity with a protected field that only has a getter, room tries to use the getter name to assing a value to the field.
Example:
@androidx.room.Entity
public class Entity {
@PrimaryKey
protected int id;
/**
* This getter is the problem - if I @Ignore it, everything works
*/
public int getId() {
return id;
}
}
This generates the following code in the DAO:
final Entity _item;
_item = new Entity();
_item.getId = _cursor.getInt(_cursorIndexOfId);
_result.add(_item);
This of course fails to compile ("Cannot find symbol variable getId").
I have attached a project that reproduces the problem.