Standalone Jetifier tool NullPointerException crash with Audience Network aar [136576786]

Fixed

Bug

Status Update

No update yet.

Description

th...@gmail.com

created issue #1

Jul 2, 2019 07:58PM

I'm trying to convert an .aar file and I'm getting a NullPointerException

Command line:
jetifier-standalone -i AudienceNetwork-5.2.0-unity.aar -o jetified-audience-network.aar

Error:
Exception in thread "main" java.lang.NullPointerException
at java.nio.file.Files.provider(Files.java:97)
at java.nio.file.Files.createDirectory(Files.java:674)
at java.nio.file.Files.createAndCheckIsDirectory(Files.java:781)
at java.nio.file.Files.createDirectories(Files.java:727)
at com.android.tools.build.jetifier.processor.archive.Archive.writeSelfToFile(Archive.kt:107)
at com.android.tools.build.jetifier.processor.archive.Archive.writeSelf(Archive.kt:87)
at com.android.tools.build.jetifier.processor.Processor.transform2(Processor.kt:321)
at com.android.tools.build.jetifier.processor.Processor.transform2$default(Processor.kt:251)
at com.android.tools.build.jetifier.standalone.Main.run(Main.kt:156)
at com.android.tools.build.jetifier.standalone.Main$Companion.main(Main.kt:109)
at com.android.tools.build.jetifier.standalone.Main.main(Main.kt)

.aar file is attached. It's part of the Audience Network Unity SDK 5.2.0

macOS High Sierra 10.13.6

java -version
openjdk version "1.8.0_152-release"
OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
OpenJDK 64-Bit Server VM (build 25.152-b01, mixed mode)

AudienceNetwork-5.2.0-unity.aar

1.1 MB

Download

Comments

th...@gmail.com <th...@gmail.com> #2Jul 2, 2019 08:15PM

This was on jetifier-standalone beta-05.

pa...@google.com <pa...@google.com> #3Jul 2, 2019 08:28PM

Seems like it works with jetifier-standalone beta-04. Will look into what is happening there.

ar...@amazon.com <ar...@amazon.com> #4Jul 26, 2019 09:31PM

Been trying to run Jetifier in reverse mode, and seeing this error as well. Seems to be working fine with jetifier-standalone beta04. Fails with beta05.

Can't share the aars here, but the command is of the form:

jetifier-standalone -r -i my_jetified.aar -o my_dejetified.aar

Error:

Exception in thread "main" java.lang.NullPointerException
at java.nio.file.Files.provider(Files.java:97)
at java.nio.file.Files.createDirectory(Files.java:674)
at java.nio.file.Files.createAndCheckIsDirectory(Files.java:781)
at java.nio.file.Files.createDirectories(Files.java:727)
at com.android.tools.build.jetifier.processor.archive.Archive.writeSelfToFile(Archive.kt:107)
at com.android.tools.build.jetifier.processor.archive.Archive.writeSelf(Archive.kt:87)
at com.android.tools.build.jetifier.processor.Processor.transform2(Processor.kt:321)
at com.android.tools.build.jetifier.processor.Processor.transform2$default(Processor.kt:251)
at com.android.tools.build.jetifier.standalone.Main.run(Main.kt:156)
at com.android.tools.build.jetifier.standalone.Main$Companion.main(Main.kt:109)
at com.android.tools.build.jetifier.standalone.Main.main(Main.kt)

MacOS High Sierra 10.13.6

ap...@google.com <ap...@google.com> #5Aug 5, 2019 05:28PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 76803311a93c39de08c08eded2b664c065b7b5a4
Author: Filip Pavlis <pavlis@google.com>
Date: Mon Aug 05 16:40:13 2019

Fix null reference for dir parent in Jetifier.

Fixes regression introduced in aosp/933797. If output is saved
into the current working directory, parent is null.
Files.CreateDirectories can't work with null reference and throws
exception.

Bug:

b/136576786

Test: Manually reproduced and verified.
Change-Id: I2b5dcdff846fee3a5ab56309b464249846b11e29

M jetifier/jetifier/processor/src/main/kotlin/com/android/tools/build/jetifier/processor/archive/Archive.kt

https://android-review.googlesource.com/1096466

https://goto.google.com/android-sha1/76803311a93c39de08c08eded2b664c065b7b5a4

pa...@google.com <pa...@google.com> #6Aug 7, 2019 01:40PM

This will be fixed as part of beta-06. The bug happens when the output file is in the same directory as from where the command was invoked.

pa...@google.com <pa...@google.com> #7Aug 20, 2019 11:56AM

Marked as fixed, reassigned to pa...@google.com.

beta-06 released. So the issue should be fixed now. Thanks for reporting folks!

Issue 136576786