Resource error message rewritting not working properly since 3.5.0-alpha09 [136987001]

Fixed

Bug

Status Update

No update yet.

Description

im...@google.com

created issue #1

Jul 8, 2019 09:59AM

Starting AGP 3.5.0-alpha09 the messages for errors in resources are not being rewritten properly for values files, i.e. instead of pointing to the original file they point to the merged.dir/values* files.

With 3.5.0-alpha08 the messages get rewritten properly.

Happens when run from the command line, and also when building form AS (tested with AS 3.6.0-alpha02, 3.6.0-alpha04, 3.5.0-beta05) with versions between 3.5.0-alpha08 to dev (present since 3.5 alpha9 and still present in dev).

Comments

cm...@google.com <cm...@google.com> #2Jul 8, 2019 10:54AM

Are there any updates here?

bu...@google.com <bu...@google.com> #3Jul 8, 2019 11:05AM

I looked at it and I'm planning to remove the deduplicating lookup the callstack refers to. It should be no longer needed. How was the 80ms in comment#1 calculated? If it's straightforward I'll calculate it again before my change goes in.

am...@google.com <am...@google.com> Jul 8, 2019 12:01PM

Accepted by am...@google.com.

am...@google.com <am...@google.com> #4Jul 9, 2019 12:46PM

Marked as fixed.

I couldn't move the logging off thread but I was able to address an area of concern in the callstack:
com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java)
com.android.build.gradle.internal.cxx.logging.CxxLogging.<clinit>(CxxLogging.java:82)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.getDescriptor(LoggingMessage.java:110)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.hashCode(LoggingMessage.java:489)
java.util.HashMap.hash(HashMap.java:340)
java.util.HashMap.containsKey(HashMap.java:592)
java.util.HashSet.contains(HashSet.java:204)

This logic was deduplicating messages (including chatty 'info' messages). This deduplication shouldn't be needed anymore so I removed it.

I don't know how the 80ms from

comment#1

was gathered so I can't say how much it has improved logging, but it should help quite a bit. Let me know if you can still measure a performance issue. The next step would be to reduce the 'info' that's logged.

Issue 136987001

Description

Issue summary

Comments

cm...@google.com <cm...@google.com> #2Jul 8, 2019 10:54AM

bu...@google.com <bu...@google.com> #3Jul 8, 2019 11:05AM

am...@google.com <am...@google.com> Jul 8, 2019 12:01PM

am...@google.com <am...@google.com> #4Jul 9, 2019 12:46PM

Add comment

Issue metadata