Resource error message rewritting not working properly since 3.5.0-alpha09 [136987001]

Fixed

Bug

Status Update

No update yet.

Description

im...@google.com

created issue #1

Jul 8, 2019 09:59AM

Starting AGP 3.5.0-alpha09 the messages for errors in resources are not being rewritten properly for values files, i.e. instead of pointing to the original file they point to the merged.dir/values* files.

With 3.5.0-alpha08 the messages get rewritten properly.

Happens when run from the command line, and also when building form AS (tested with AS 3.6.0-alpha02, 3.6.0-alpha04, 3.5.0-beta05) with versions between 3.5.0-alpha08 to dev (present since 3.5 alpha9 and still present in dev).

Comments

cm...@google.com <cm...@google.com> #2Jul 8, 2019 10:54AM

We should consider this for 3.5

bu...@google.com <bu...@google.com> #3Jul 8, 2019 11:05AM

If we do, we should be aware that RC1 cut is this Wednesday (P0 maybe?).

am...@google.com <am...@google.com> Jul 8, 2019 12:01PM

Accepted by am...@google.com.

am...@google.com <am...@google.com> #4Jul 9, 2019 12:46PM

Marked as fixed.

Fixing change:

https://android.googlesource.com/platform/tools/base/+/7aa4b57a7602a05a914aa2e1b3b72385733b3f39, cherry-picked into 3.5 dev.

Issue 136987001

Description

Issue summary

Comments

cm...@google.com <cm...@google.com> #2Jul 8, 2019 10:54AM

bu...@google.com <bu...@google.com> #3Jul 8, 2019 11:05AM

am...@google.com <am...@google.com> Jul 8, 2019 12:01PM

am...@google.com <am...@google.com> #4Jul 9, 2019 12:46PM

Add comment

Issue metadata