Add workaround for Robolectric not posting requestApplyInsets() [137201343]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jul 10, 2019 05:44PM

Component used: Fragment
Version used: 1.2.0-alpha01

When running a test in Robolectric, the new behavior introduced in

https://issuetracker.google.com/issues/135945162 causes issues when you have a ViewPager since Robolectric, instead of properly posting the requestApplyInsets (and the subsequent measure/layout) runs it inline, causing an IllegalStateException when FragmentPagerAdapter / FragmentStatePagerAdapter use commitNowAllowingStateLoss() when the FragmentManager is in the middle of processing transactions.

We should continue to use commitNowAllowingStateLoss(), but catch the IllegalStateException and fall back to commitAllowingStateLoss() specifically in the case where we're already performing transactions.

Comments

il...@google.com <il...@google.com> Jul 10, 2019 06:13PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #2Jul 10, 2019 07:59PM

Marked as fixed.

Yigit, do you have time to fix it?

reemission of the same liveData is racy

om...@gmail.com <om...@gmail.com> #3Jan 6, 2020 09:24PM

yea i'll take it.

ap...@google.com <ap...@google.com> #4Jan 21, 2020 09:34PM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

an...@google.com <an...@google.com> #5Jan 22, 2020 12:10AM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

Issue 137201343