Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit fd8d4df6962535efebb4a0ef0426c6e17d1c81e9
Author: jbwoods <jbwoods@google.com>
Date: Thu Jun 27 13:38:50 2019
Replace FrameLayout Containers in Navigation with FragmentContainerViews
Navigation can take advantage of FragmentContainerView and have entering
views drawn on top of exiting ones.
Replaced all FrameLayouts in navigation-fragment component with
FragmentContainerViews.
Updated integration test to clearly show the difference in the
animations. If working properly, entering view will animate on top. If
something is incorrect, the entering view will pop into place.
Test: Tested visually in app. Tests still pass
BUG: 137310379
Change-Id: I27b9a6d6111329f3d808b68d374df1935e77eea1
M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/MainFragment.kt
A navigation/integration-tests/testapp/src/main/res/anim/nav_default_enter_anim.xml
A navigation/integration-tests/testapp/src/main/res/anim/nav_default_exit_anim.xml
A navigation/integration-tests/testapp/src/main/res/anim/nav_default_pop_enter_anim.xml
A navigation/integration-tests/testapp/src/main/res/anim/nav_default_pop_exit_anim.xml
M navigation/navigation-fragment/src/androidTest/res/layout/dynamic_navigation_activity.xml
M navigation/navigation-fragment/src/androidTest/res/layout/embedded_xml_activity.xml
M navigation/navigation-fragment/src/androidTest/res/layout/empty_activity.xml
M navigation/navigation-fragment/src/androidTest/res/layout/start_destination_args_activity.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
https://android-review.googlesource.com/1004063
https://goto.google.com/android-sha1/fd8d4df6962535efebb4a0ef0426c6e17d1c81e9
Branch: androidx-master-dev
commit fd8d4df6962535efebb4a0ef0426c6e17d1c81e9
Author: jbwoods <jbwoods@google.com>
Date: Thu Jun 27 13:38:50 2019
Replace FrameLayout Containers in Navigation with FragmentContainerViews
Navigation can take advantage of FragmentContainerView and have entering
views drawn on top of exiting ones.
Replaced all FrameLayouts in navigation-fragment component with
FragmentContainerViews.
Updated integration test to clearly show the difference in the
animations. If working properly, entering view will animate on top. If
something is incorrect, the entering view will pop into place.
Test: Tested visually in app. Tests still pass
BUG: 137310379
Change-Id: I27b9a6d6111329f3d808b68d374df1935e77eea1
M navigation/integration-tests/testapp/src/main/java/androidx/navigation/testapp/MainFragment.kt
A navigation/integration-tests/testapp/src/main/res/anim/nav_default_enter_anim.xml
A navigation/integration-tests/testapp/src/main/res/anim/nav_default_exit_anim.xml
A navigation/integration-tests/testapp/src/main/res/anim/nav_default_pop_enter_anim.xml
A navigation/integration-tests/testapp/src/main/res/anim/nav_default_pop_exit_anim.xml
M navigation/navigation-fragment/src/androidTest/res/layout/dynamic_navigation_activity.xml
M navigation/navigation-fragment/src/androidTest/res/layout/embedded_xml_activity.xml
M navigation/navigation-fragment/src/androidTest/res/layout/empty_activity.xml
M navigation/navigation-fragment/src/androidTest/res/layout/start_destination_args_activity.xml
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
jb...@google.com <jb...@google.com> #3
This has been fixed internally and will be available in the Navigation 2.2.0-alpha01 release.
Description
Version used: 2.1.0-alpha06
With the introduction of FragmentContainerView in