Fixed
Status Update
No update yet.
Comments
je...@google.com
> The Transition Kotlin extensions target the Framework Transition class which is a bit confusing
All extensions in 'core-ktx' target either 'core' or the framework types. This is working as expected. It sounds like this is a feature request for a transition-ktx with equivalent extensions for the androidx.transition types.
> as most framework classes are being deprecated in favor of their AndroidX counterparts, Fragments for example.
"Most"? This *dramatically* overstates what is actually happening. Fragments (and loaders) were added to the framework in a time where the Android team did not have external libraries for shipping features. Transition was added 5 years later.
All extensions in 'core-ktx' target either 'core' or the framework types. This is working as expected. It sounds like this is a feature request for a transition-ktx with equivalent extensions for the androidx.transition types.
> as most framework classes are being deprecated in favor of their AndroidX counterparts, Fragments for example.
"Most"? This *dramatically* overstates what is actually happening. Fragments (and loaders) were added to the framework in a time where the Android team did not have external libraries for shipping features. Transition was added 5 years later.
je...@google.com
Pardon my misunderstanding, I was under the belief that where possible, new features that could be developed outside the framework, would be under Androidx. Also it's a common refrain to use the Androidx libraries over the framework libraries where possible, as those ship update independently of platform releases. I wasn't attempting to be dramatic.
If the Transition api is unlikely to change, there is no need for a transition-ktx for androidx.transition types. If developers should use Androidx transitions over framework transitions where possible however, then it would be much appreciated.
I am well aware of the limitations that existed when Fragments and Loaders were created, and when the Transition api was introduced.
If the Transition api is unlikely to change, there is no need for a transition-ktx for androidx.transition types. If developers should use Androidx transitions over framework transitions where possible however, then it would be much appreciated.
I am well aware of the limitations that existed when Fragments and Loaders were created, and when the Transition api was introduced.
jg...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ae42e311ecfbac18cedc90e489d1fdde956a4557
Author: Jake Wharton <jakew@google.com>
Date: Fri Nov 22 11:13:30 2019
Introduce transition-ktx for standalone transition library
These extensions are the same as androidx.core.transition for the platform types, just adapted to the standalone library.
Bug: 138870873
Test: gw :transition:transition-ktx:build :transition:transition-ktx:connectedCheck
Change-Id: Ie80022cc60ed1f482b7593db5ef1ac1c5ea33d8d
M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
M jetifier/jetifier/migration.config
M settings.gradle
A transition/transition-ktx/OWNERS
A transition/transition-ktx/api/1.4.0-alpha01.txt
A transition/transition-ktx/api/current.txt
A transition/transition-ktx/api/public_plus_experimental_1.4.0-alpha01.txt
A transition/transition-ktx/api/public_plus_experimental_current.txt
A transition/transition-ktx/api/res-1.4.0-alpha01.txt
A transition/transition-ktx/api/restricted_1.4.0-alpha01.txt
A transition/transition-ktx/api/restricted_current.txt
A transition/transition-ktx/build.gradle
A transition/transition-ktx/src/androidTest/AndroidManifest.xml
A transition/transition-ktx/src/androidTest/java/androidx/transition/TestActivity.kt
A transition/transition-ktx/src/androidTest/java/androidx/transition/TransitionTest.kt
A transition/transition-ktx/src/androidTest/res/layout/test_activity.xml
A transition/transition-ktx/src/main/AndroidManifest.xml
A transition/transition-ktx/src/main/java/androidx/transition/Transition.kt
https://android-review.googlesource.com/1172715
Branch: androidx-master-dev
commit ae42e311ecfbac18cedc90e489d1fdde956a4557
Author: Jake Wharton <jakew@google.com>
Date: Fri Nov 22 11:13:30 2019
Introduce transition-ktx for standalone transition library
These extensions are the same as androidx.core.transition for the platform types, just adapted to the standalone library.
Bug: 138870873
Test: gw :transition:transition-ktx:build :transition:transition-ktx:connectedCheck
Change-Id: Ie80022cc60ed1f482b7593db5ef1ac1c5ea33d8d
M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
M jetifier/jetifier/migration.config
M settings.gradle
A transition/transition-ktx/OWNERS
A transition/transition-ktx/api/1.4.0-alpha01.txt
A transition/transition-ktx/api/current.txt
A transition/transition-ktx/api/public_plus_experimental_1.4.0-alpha01.txt
A transition/transition-ktx/api/public_plus_experimental_current.txt
A transition/transition-ktx/api/res-1.4.0-alpha01.txt
A transition/transition-ktx/api/restricted_1.4.0-alpha01.txt
A transition/transition-ktx/api/restricted_current.txt
A transition/transition-ktx/build.gradle
A transition/transition-ktx/src/androidTest/AndroidManifest.xml
A transition/transition-ktx/src/androidTest/java/androidx/transition/TestActivity.kt
A transition/transition-ktx/src/androidTest/java/androidx/transition/TransitionTest.kt
A transition/transition-ktx/src/androidTest/res/layout/test_activity.xml
A transition/transition-ktx/src/main/AndroidManifest.xml
A transition/transition-ktx/src/main/java/androidx/transition/Transition.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 0057dd5af173f3c848bb95ef5d649ae66a9cbd75
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jul 29 18:00:39 2019
Make runOnUiThread sync and rethrow on caller thread
- Use activityTestRule.runOnUiThread to leverage its synchronous
implementation. This removes the need for some latches.
- Catch all throwables and rethrow them on the caller thread. This is
particularly useful if assertions are made in the runOnUiThread block.
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: I1344cfe49f62b182d2d86c21d00e627dcb8dd44a
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AccessibilityTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/DragWhileSmoothScrollTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FakeDragTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FragmentLifecycleTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/OffscreenPageLimitTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
https://android-review.googlesource.com/1092803
https://goto.google.com/android-sha1/0057dd5af173f3c848bb95ef5d649ae66a9cbd75
Branch: androidx-master-dev
commit 0057dd5af173f3c848bb95ef5d649ae66a9cbd75
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jul 29 18:00:39 2019
Make runOnUiThread sync and rethrow on caller thread
- Use activityTestRule.runOnUiThread to leverage its synchronous
implementation. This removes the need for some latches.
- Catch all throwables and rethrow them on the caller thread. This is
particularly useful if assertions are made in the runOnUiThread block.
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: I1344cfe49f62b182d2d86c21d00e627dcb8dd44a
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AccessibilityTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/DragWhileSmoothScrollTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FakeDragTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FragmentLifecycleTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/OffscreenPageLimitTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c7dccffeaa91f243213c4e781621f34f7f49ca3d
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jul 29 16:29:36 2019
Don't await animations to update mCurrentItem
ItemAnimations only adjust translationX/Y, not view positions.
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: Icfd9f6ace4a1e3dc5959bacfcbff755be84acfce
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java
https://android-review.googlesource.com/1092799
https://goto.google.com/android-sha1/c7dccffeaa91f243213c4e781621f34f7f49ca3d
Branch: androidx-master-dev
commit c7dccffeaa91f243213c4e781621f34f7f49ca3d
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jul 29 16:29:36 2019
Don't await animations to update mCurrentItem
ItemAnimations only adjust translationX/Y, not view positions.
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: Icfd9f6ace4a1e3dc5959bacfcbff755be84acfce
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3a6d49d6961e860f998d5cc658d7535e8a00138f
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jul 30 14:22:07 2019
Rename runOnUiThread to runOnUiThreadSync
To make it explicit that it runs synchronously, contrary to how
Activity.runOnUiThread works, but similar to how
ActivityTestRule.runOnUiThread works.
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: Ia8fb2cb7b45c3bbabf458194717d93b20c3f687f
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AccessibilityTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/DragWhileSmoothScrollTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FakeDragTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FragmentLifecycleTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/MutableCollectionsTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/OffscreenPageLimitTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageFillTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/SetItemWhileScrollInProgressTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/SwipeTest.kt
https://android-review.googlesource.com/1093429
https://goto.google.com/android-sha1/3a6d49d6961e860f998d5cc658d7535e8a00138f
Branch: androidx-master-dev
commit 3a6d49d6961e860f998d5cc658d7535e8a00138f
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jul 30 14:22:07 2019
Rename runOnUiThread to runOnUiThreadSync
To make it explicit that it runs synchronously, contrary to how
Activity.runOnUiThread works, but similar to how
ActivityTestRule.runOnUiThread works.
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: Ia8fb2cb7b45c3bbabf458194717d93b20c3f687f
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AccessibilityTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/DragWhileSmoothScrollTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FakeDragTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FragmentLifecycleTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/MutableCollectionsTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/OffscreenPageLimitTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageFillTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/SetItemWhileScrollInProgressTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/SwipeTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit f418aaa3dc3d8517dafdd1fba5af6ec0c16dc7d4
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jul 29 13:16:41 2019
Fix mCurrentItem and events when data set changes
If the data set changes during a smooth scroll and the first visible
item is removed in this change, the smooth scroll may land on another
page then expected.
Fix this by dispatching a selected event and an idle event when RV
transitions to idle and we are not yet idle (and a few more specific
conditions).
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: Ia241d00aa7758ddbdd937a97aa17a15ed8feb343
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/SetItemWhileScrollInProgressTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ScrollEventAdapter.java
https://android-review.googlesource.com/1092797
https://goto.google.com/android-sha1/f418aaa3dc3d8517dafdd1fba5af6ec0c16dc7d4
Branch: androidx-master-dev
commit f418aaa3dc3d8517dafdd1fba5af6ec0c16dc7d4
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Jul 29 13:16:41 2019
Fix mCurrentItem and events when data set changes
If the data set changes during a smooth scroll and the first visible
item is removed in this change, the smooth scroll may land on another
page then expected.
Fix this by dispatching a selected event and an idle event when RV
transitions to idle and we are not yet idle (and a few more specific
conditions).
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: Ia241d00aa7758ddbdd937a97aa17a15ed8feb343
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/SetItemWhileScrollInProgressTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ScrollEventAdapter.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 18598b92ddd3b1f324f0c2f62cdefc4920471b86
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jul 30 16:44:33 2019
Fix epsilon offset in test_removeFirstVisibleItemWhileScrolling
Epsilon needs to be subtracted instead of added.
Consider the case where targetBound = false. The window of opportunity
for the test is while scrolling between 3 and 2 pages before the target,
so the 'distance' parameter for addWaitForDistanceToTarget should be
3 - epsilon. 'targetPage - windowStart' gives 3 (see calculation of
windowStart), so subtract epsilon from that.
Bug: 137642608
Test: ./gradlew viewpager2:cC \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.viewpager2.widget.PageChangeCallbackTest
Change-Id: I8220540cd4f41c80d3deeb2c5ad089a58fdb353c
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
https://android-review.googlesource.com/1093436
https://goto.google.com/android-sha1/18598b92ddd3b1f324f0c2f62cdefc4920471b86
Branch: androidx-master-dev
commit 18598b92ddd3b1f324f0c2f62cdefc4920471b86
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jul 30 16:44:33 2019
Fix epsilon offset in test_removeFirstVisibleItemWhileScrolling
Epsilon needs to be subtracted instead of added.
Consider the case where targetBound = false. The window of opportunity
for the test is while scrolling between 3 and 2 pages before the target,
so the 'distance' parameter for addWaitForDistanceToTarget should be
3 - epsilon. 'targetPage - windowStart' gives 3 (see calculation of
windowStart), so subtract epsilon from that.
Bug: 137642608
Test: ./gradlew viewpager2:cC \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.viewpager2.widget.PageChangeCallbackTest
Change-Id: I8220540cd4f41c80d3deeb2c5ad089a58fdb353c
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
jg...@google.com
The fix is now in place and should come out in the next release.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 51a3aa658e8bbb69f1abbb72e61137d48c5b042d
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jul 31 09:45:59 2019
Extract method to reset ViewPager2 to a page
Intended use is for the resetBlock in tryNTimes()
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: Ibf33dec5695b843dd9f55de70428696f4fbf33e7
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FakeDragTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
https://android-review.googlesource.com/1094209
https://goto.google.com/android-sha1/51a3aa658e8bbb69f1abbb72e61137d48c5b042d
Branch: androidx-master-dev
commit 51a3aa658e8bbb69f1abbb72e61137d48c5b042d
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jul 31 09:45:59 2019
Extract method to reset ViewPager2 to a page
Intended use is for the resetBlock in tryNTimes()
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: Ibf33dec5695b843dd9f55de70428696f4fbf33e7
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/BaseTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FakeDragTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5d424ebe42854e78c5f5fdf8a153e87caa67a2a7
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jul 31 11:10:39 2019
Add more tests for data changes while scrolling
Creates a new parameterized test to tease out different modifications of
the adapter's data set while smooth scrolling. Note that while the
expectedFinalPage and expectedFinalPageText are not what you'd expect
intuitively, it is fine to hardcode them as they are not determined by
ViewPager2, but by an external and constant factor (RecyclerView).
Bug: 137642608
Test: ./gradle viewpager2:cC
Change-Id: If08869bcb45c014168f9f208457894d227ab7588
A viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeWhileSmoothScrollTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/androidTest/res/layout/item_test_layout.xml
https://android-review.googlesource.com/1094210
https://goto.google.com/android-sha1/5d424ebe42854e78c5f5fdf8a153e87caa67a2a7
Branch: androidx-master-dev
commit 5d424ebe42854e78c5f5fdf8a153e87caa67a2a7
Author: Jelle Fresen <jellefresen@google.com>
Date: Wed Jul 31 11:10:39 2019
Add more tests for data changes while scrolling
Creates a new parameterized test to tease out different modifications of
the adapter's data set while smooth scrolling. Note that while the
expectedFinalPage and expectedFinalPageText are not what you'd expect
intuitively, it is fine to hardcode them as they are not determined by
ViewPager2, but by an external and constant factor (RecyclerView).
Bug: 137642608
Test: ./gradle viewpager2:cC
Change-Id: If08869bcb45c014168f9f208457894d227ab7588
A viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeWhileSmoothScrollTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/androidTest/res/layout/item_test_layout.xml
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ffafc2b3d16a50939dd7b8a49ee814726fb51d2f
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Aug 01 17:11:25 2019
Fix currentItem for dataSetChange+smoothScroll
Follow-up after stress testing.
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: I9f5a9972f3b47bca87ca4a1ac7dada9f2565aad1
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeWhileSmoothScrollTest.kt
A viewpager2/src/androidTest/java/androidx/viewpager2/widget/ChangeDataSetWhileScrollingTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ScrollEventAdapter.java
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java
https://android-review.googlesource.com/1095052
https://goto.google.com/android-sha1/ffafc2b3d16a50939dd7b8a49ee814726fb51d2f
Branch: androidx-master-dev
commit ffafc2b3d16a50939dd7b8a49ee814726fb51d2f
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Aug 01 17:11:25 2019
Fix currentItem for dataSetChange+smoothScroll
Follow-up after stress testing.
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: I9f5a9972f3b47bca87ca4a1ac7dada9f2565aad1
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeWhileSmoothScrollTest.kt
A viewpager2/src/androidTest/java/androidx/viewpager2/widget/ChangeDataSetWhileScrollingTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ScrollEventAdapter.java
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 977716cf625c3be2422ab959fee72d1760c1e2d8
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Aug 01 17:40:42 2019
Increase timeout of ChangeDataSetWhileScrollingTest
1 second might be too tight on slow devices
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: If65c72db21665f51cac389b9af2c69ef7770baa8
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/ChangeDataSetWhileScrollingTest.kt
https://android-review.googlesource.com/1095053
https://goto.google.com/android-sha1/977716cf625c3be2422ab959fee72d1760c1e2d8
Branch: androidx-master-dev
commit 977716cf625c3be2422ab959fee72d1760c1e2d8
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Aug 01 17:40:42 2019
Increase timeout of ChangeDataSetWhileScrollingTest
1 second might be too tight on slow devices
Bug: 137642608
Test: ./gradlew viewpager2:cC
Change-Id: If65c72db21665f51cac389b9af2c69ef7770baa8
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/ChangeDataSetWhileScrollingTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 332667ea380fcde2c9e8b2cdccfbfbeeecc52316
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Aug 02 14:25:10 2019
Determine expectedFinalPage dynamically
In AdapterDataSetChangeWhileSmoothScrollTest, determine the expected
final page by looking at RecyclerView.
Bug: 137642608
Test: ./gradlew viewpager2:connectedCheck \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.viewpager2.widget.AdapterDataSetChangeWhileSmoothScrollTest
Change-Id: Ic210673ef21f9af33efa4e2e507b69de0d7ae9df
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeWhileSmoothScrollTest.kt
https://android-review.googlesource.com/1095612
https://goto.google.com/android-sha1/332667ea380fcde2c9e8b2cdccfbfbeeecc52316
Branch: androidx-master-dev
commit 332667ea380fcde2c9e8b2cdccfbfbeeecc52316
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Aug 02 14:25:10 2019
Determine expectedFinalPage dynamically
In AdapterDataSetChangeWhileSmoothScrollTest, determine the expected
final page by looking at RecyclerView.
Bug: 137642608
Test: ./gradlew viewpager2:connectedCheck \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.viewpager2.widget.AdapterDataSetChangeWhileSmoothScrollTest
Change-Id: Ic210673ef21f9af33efa4e2e507b69de0d7ae9df
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/AdapterDataSetChangeWhileSmoothScrollTest.kt
Description
No description yet.