Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5528d80bc5235577e34701b42f34762207d0cb76
Author: Chris Craik <ccraik@google.com>
Date: Tue Jul 16 16:32:24 2019
Change benchmark warnings to be true errors, which fail test by default
Fixes: 137653596
Test: ./gradlew benchmark:cC
They can be suppressed by instrumentation arg, but outputs will still
be mangled.
This makes it much less likely to have to deal with bad data in CI.
Benchmark tests suppress DEBUGGABLE, CODE-COVERAGE, EMULATOR,
LOW-BATTERY, and UNLOCKED since any of those is fine for correctness
tests (and all occur in correctness test CI).
They do this from code though, as instrumentation args defined in
gradle aren't currently picked up by our CI.
Change-Id: I4308e565c08da413b4c5e5a890145802937554dc
M benchmark/api/1.0.0-alpha04.txt
M benchmark/api/current.txt
M benchmark/api/restricted_1.0.0-alpha04.txt
M benchmark/api/restricted_current.txt
M benchmark/src/androidTest/AndroidManifest.xml
A benchmark/src/androidTest/java/androidx/benchmark/ArgumentInjectingApplication.kt
M benchmark/src/androidTest/java/androidx/benchmark/BenchmarkStateTest.kt
M benchmark/src/main/java/androidx/benchmark/AndroidBenchmarkRunner.kt
A benchmark/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/src/main/java/androidx/benchmark/BenchmarkRule.kt
M benchmark/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/src/main/java/androidx/benchmark/Errors.kt
M benchmark/src/main/java/androidx/benchmark/ResultWriter.kt
https://android-review.googlesource.com/1056179
https://goto.google.com/android-sha1/5528d80bc5235577e34701b42f34762207d0cb76
Branch: androidx-master-dev
commit 5528d80bc5235577e34701b42f34762207d0cb76
Author: Chris Craik <ccraik@google.com>
Date: Tue Jul 16 16:32:24 2019
Change benchmark warnings to be true errors, which fail test by default
Fixes: 137653596
Test: ./gradlew benchmark:cC
They can be suppressed by instrumentation arg, but outputs will still
be mangled.
This makes it much less likely to have to deal with bad data in CI.
Benchmark tests suppress DEBUGGABLE, CODE-COVERAGE, EMULATOR,
LOW-BATTERY, and UNLOCKED since any of those is fine for correctness
tests (and all occur in correctness test CI).
They do this from code though, as instrumentation args defined in
gradle aren't currently picked up by our CI.
Change-Id: I4308e565c08da413b4c5e5a890145802937554dc
M benchmark/api/1.0.0-alpha04.txt
M benchmark/api/current.txt
M benchmark/api/restricted_1.0.0-alpha04.txt
M benchmark/api/restricted_current.txt
M benchmark/src/androidTest/AndroidManifest.xml
A benchmark/src/androidTest/java/androidx/benchmark/ArgumentInjectingApplication.kt
M benchmark/src/androidTest/java/androidx/benchmark/BenchmarkStateTest.kt
M benchmark/src/main/java/androidx/benchmark/AndroidBenchmarkRunner.kt
A benchmark/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/src/main/java/androidx/benchmark/BenchmarkRule.kt
M benchmark/src/main/java/androidx/benchmark/BenchmarkState.kt
M benchmark/src/main/java/androidx/benchmark/Errors.kt
M benchmark/src/main/java/androidx/benchmark/ResultWriter.kt
Description
We'll make this setting configurable, since we don't want to entirely block folks without a real device to run benchmarks, but defaults are important.
Need to hit zero warnings in CI before we can land this.