Version 2.1.0-beta01 include jacocoagent as dependency which makes lint fail [137782950]

Fixed

Bug

Status Update

No update yet.

Description

ni...@gmail.com

created issue #1

Jul 18, 2019 09:10AM

Component used: Navigation
Version used: 2.1.0-beta01
Devices/Android versions reproduced on: Compilation

After upgrading, I quickly got the following erros on my CI :

After checking a bit which dependency include jacocoagent, I found the culprits (ViewPager 2 does too) :
+--- androidx.navigation:navigation-ui-ktx:2.1.0-beta01
| +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.40 -> 1.3.41 (*)
| +--- androidx.navigation:navigation-ui:[2.1.0-beta01] -> 2.1.0-beta01
| | +--- com.google.android.material:material:1.0.0 -> 1.1.0-alpha08 (*)
| | +--- org.jacoco:org.jacoco.agent:0.8.3
| | +--- androidx.navigation:navigation-runtime:[2.1.0-beta01] -> 2.1.0-beta01 (*)
| | \--- androidx.transition:transition:1.0.1 (*)
| \--- androidx.navigation:navigation-runtime-ktx:[2.1.0-beta01] -> 2.1.0-beta01 (*)

Is that normal ? If it is, what can we do to avoid lint from failing ?

Comments

[Deleted User] <[Deleted User]> #2Jul 18, 2019 07:53PM

since these are in public API (:/) we need to do this in 1.2

il...@google.com <il...@google.com> #3Jul 18, 2019 08:25PM

Assigned to il...@google.com.

since it is already marked as deprecated, we can probably do it by now.

an...@google.com <an...@google.com> #4Jul 18, 2019 08:48PM

Opening diff shortly

il...@google.com <il...@google.com> Jul 19, 2019 12:27AM

Marked as fixed.

il...@google.com <il...@google.com> #5Jul 19, 2019 07:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

Issue 137782950