IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Hey, unfortunately for me, that doesn't solve the issue, if anything, it made it more sensitive to the side swipe.

I'm sorry that I can't give you a reliable way to replicate it, but i'm assuming it is something to do with the fact we are using nested scrolling views inside our fragment, or how we are consuming the touch events our side.

If you 'flick' the recyclerview in our fragment down, it scrolls fine. However, if you 'drag', it gets consumed by the side swipe to go to the next tab, which is not desired behaviour.

Here is an example of what is happening. If you need anymore info from me, i'm happy to provide.

Thank you for the video - it does make a clear case for investigating it further. I will provide updates once we know more.

One of the issues in the video is a lack of scroll orientation lock (once downwards scroll is initiated, a user can still see pages on the sides).

Could you advise on your view hierarchy from RecyclerView to ViewPager2?

I've noticed this issue caused by NestedScrollView being in the way in this sample:
- No scroll orientation lock because of NestedScrollView (from http://issuetracker.google.com/124042228#comment7): https://github.com/marbat87/ScrollingViewPager2.git

However, in a typical case, it works fine:
- Scroll orientation lock (from http://issuetracker.google.com/136194634#comment3): https://github.com/jcholin/viewpager2_issue_136194634

Also, you're right that other values than TOUCH_SLOP_PAGING in (viewPager.getChildAt(0) as androidx.recyclerview.widget.RecyclerView).setScrollingTouchSlop might cause worse experience. I've looked more into it, and only TOUCH_SLOP_PAGING results in an increased touch slop; other values are ignored and result in default RecyclerView behaviour.

Hey there, sorry to get back to you so late.

After some investigation, it seems to be the SwipeRefreshLayout that is the culprit.

In the example that works fine that you provided me ( https://github.com/jcholin/viewpager2_issue_136194634) and wrap the fragment_child in a SwipeRefreshLayout, you can see the similar to behaviour to the NestedScrollView issues.

The heirachy in the video above for the child fragment  is pretty simple

<SwipeRefreshLayout>
     <ConstraintLayout>
         <CustomErrorView/>
         <RecyclerView/>
    </ConstraintLayout>
</SwipeRefreshLayout>

I can cofirm when I remove the SwipeRefreshLayout, it works as intended.
         

This is an issue with nested scrolling and has been fixed both in SwipeRefreshLayout [1] and in RecyclerView [2]. The fixes have been released in androidx.swiperefreshlayout:swiperefreshlayout:1.1.0-alpha02 and androidx.recyclerview:recyclerview:1.1.0-beta02.

In this particular case, you will only need the bugfix of RecyclerView, because with this view hierarchy RV is driving the nested scroll.
In the absence of a scrolling child in SRL, you would need the bugfix of SRL.
If you have any other scrolling child in SRL, that component either already does the right thing or needs to be fixed similar to how RV was fixed. To the best of my knowledge, the most likely candidate, NestedScrollView, already does the right thing.

Original issue: https://issuetracker.google.com/issues/131115697

[1] https://android-review.googlesource.com/c/973750/
[2] https://android-review.googlesource.com/c/1055911/

Can you confirm which version of RecyclerView you are using, and if not 1.1.0-beta02, see if the issue is fixed when using 1.1.0-beta02?

Hi,

I started using both 1.1.0-beta02 for recyclerview and 1.1.0-alpha02 for swiperefreshlayout, but unfortunately, still not working.

The only way I can get scroll behaviour as predicted, is it if remove the SwipeRefreshLayout all together.

I should mention the view heirachy I have shown you above is for the child fragment INSIDE of the viewpager. This is not the root activity layout.

Hi Tom, could you provide us with a working minimal sample reproducing the issue? It'd allow us to dive into it -- sounds like we've covered the obvious culprits.
Probably the easiest way to do it is to modify our sample [1], but any self-contained sample that'd allow us to reproduce the issue would be great.

[1] https://github.com/googlesamples/android-viewpager2

I have attached a previous example someone has sent you to include swipe refresh layout and all the latest versions of the components you suggested to change. Hope this helps.

We tracked down the bug to SwipeRefreshLayout, but it's a bit tricky to solve without breaking unrelated things.

(Sort of) good news. Thanks for keeping me up to date, as we're all extremely keen to use it here!

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6a9efe2e5b9ad406f486b5c4999fd6c119eb59fa
Author: Jelle Fresen <jellefresen@google.com>
Date:   Tue Aug 27 14:56:12 2019

    Improve SwipeRefreshLayout test
   
    Fixes/improvements in
    SwipeRefreshLayoutInHorizontallyScrollingParentTest:
    - Make sibling pages non-zero size
    - Calculates 'gesture distance' correctly
    - Accounts for touch slop when performing gesture
    - Asserts that requestDisallowInterceptTouchEvent(true) is called
    - Speeds up the gesture
   
    Bug: 138314213
    Test: ./gradlew swiperefreshlayout:cC
    Change-Id: I00a5f73ef0c54f41034cdacd023b8348e133384c

M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInHorizontallyScrollingParentTest.java
M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInRecyclerViewActivity.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeToRefreshLayoutRequestDisallowInterceptTest.java

https://android-review.googlesource.com/1108543
https://goto.google.com/android-sha1/6a9efe2e5b9ad406f486b5c4999fd6c119eb59fa

Hey all,

Just to confirm, I have tried the new update (beta-04) and the issue persists.

Correct, the issue needs one more fix in SwipeRefreshLayout. A fix is on the way, but we're still working on fleshing out the details. At the earliest it will be released on October 2nd. The latest status of the fix can be found here: https://android-review.googlesource.com/c/platform/frameworks/support/+/1108540

In the mean time, it might be possible to work around the issue by extending SwipeRefreshLayout and overriding "requestDisallowInterceptTouchEvent" with the following implementation:

    @Override
    public void requestDisallowInterceptTouchEvent(boolean b) {
        // Ignore here, but pass it up to our parent
        ViewParent parent = getParent();
        if (parent != null) {
            parent.requestDisallowInterceptTouchEvent(b);
        }
    }

Does that solve the problem for now?

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6d5f435733bf7c9975d1b8064605a237fe6086a9
Author: Jelle Fresen <jellefresen@google.com>
Date:   Fri Aug 23 10:53:45 2019

    Don't ignore requestDisallowInterceptTouchEvent in SRL
   
    A SwipeRefreshLayout ignored calls to requestDisallowInterceptTouchEvent
    when nested scrolling was not enabled in its child, but there is no good
    reason why it shouldn't propagate the call to its parents. It is OK for
    SRL itself to dishonor the request, as one can always use
    OnChildScrollUpCallback to control cooperation with scrolls in children.
   
    Bug: 138314213
    Test: ./gradlew swiperefreshlayout:cC
    Change-Id: I4959df942ebb2097f3c3ebe39ff0582f6ae6f395

M       swiperefreshlayout/api/1.1.0-alpha03.txt
M       swiperefreshlayout/api/current.txt
M       swiperefreshlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M       swiperefreshlayout/api/public_plus_experimental_current.txt
M       swiperefreshlayout/api/restricted_1.1.0-alpha03.txt
M       swiperefreshlayout/api/restricted_current.txt
M       swiperefreshlayout/build.gradle
M       swiperefreshlayout/src/androidTest/AndroidManifest.xml
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/RequestDisallowInterceptRecordingRecyclerView.java
M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInRecyclerViewBaseActivity.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInRecyclerViewWithRecyclerViewChildActivity.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInRecyclerViewWithSimpleChildActivity.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInScrollingParentAndChildTest.java
M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInScrollingParentBaseTest.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInScrollingParentTest.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutRequestDisallowInterceptAsChildAndParentTest.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutRequestDisallowInterceptAsChildTest.java
M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutRequestDisallowInterceptBaseTest.java
M       swiperefreshlayout/src/main/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayout.java

https://android-review.googlesource.com/1108540
https://goto.google.com/android-sha1/6d5f435733bf7c9975d1b8064605a237fe6086a9

Fix will be released in swiperefreshlayout-1.1.0-alpha03 in early October

i am using it in
<swiperefreshlayout>
<recycler>
</swiperefreshlayout>
still getting this error

only in horizontal, updated recycler to 1.1.0 and refresh to 1.1.0-rc1

It's much better with this usage but sometimes I still getting this the issue. Especial, when swipeRefreshLayout is refreshing. You can see on the screen record.

ContainerFragment;
<androidx.constraintlayout.widget.ConstraintLayout>
        <com.google.android.material.tabs.TabLayout/>
        <androidx.viewpager2.widget.ViewPager2/>
</androidx.constraintlayout.widget.ConstraintLayout>

InnerFragment;
<androidx.swiperefreshlayout.widget.SwipeRefreshLayout>
    <FrameLayout android:nestedScrollingEnabled="true">
        <androidx.recyclerview.widget.RecyclerView/>
    </FrameLayout>
</androidx.swiperefreshlayout.widget.SwipeRefreshLayout>

constraintLayoutVersion = "1.1.3"
viewPager2 = "1.1.0-alpha01"
swipeRefreshLayoutVersion = "1.2.0-alpha01"
recyclerViewVersion = "1.2.0-alpha05"