IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 06035833f0e98b6116774b743c75c2cc7c334326
Author: Ember Rose <emberrose@google.com>
Date:   Mon May 17 15:52:36 2021

    Create @AppCompatShadowedAttributes
   
    This annotation is restricted to intra-androidx library usage. When
    applied to a View in AppCompat, it will direct the annotation processor
    to infer shadowed attributes for the View based on what interfaces from
    Core it implements, e.g.: TintableBackgroundView.
   
    Test: N/A
    Relnote: Improved AppCompat support
    Bug: 188446121
    Change-Id: I2d7387a017585bcea14a8d8a857b9b60930bc1c5

M       resourceinspection/resourceinspection-annotation/api/restricted_current.txt
A       resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java

https://android-review.googlesource.com/1709335

Project: platform/frameworks/support
Branch: androidx-main

commit 42f9ba7d4ccd46960123b403df5ca28803643059
Author: Ember Rose <emberrose@google.com>
Date:   Mon May 17 17:41:24 2021

    Refactor resource inspection processor model
   
    Extract an Attribute interface to generate code for either shadowed or
    annotated regular attributes.
   
    Test: ResourceInspectionProcessorTest
    Bug: 188446121
    Change-Id: I131f017c433ec9e44a6fb364c903467894735377

M       resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/InspectionCompanionGeneration.kt
M       resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M       resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt

https://android-review.googlesource.com/1709337

Project: platform/frameworks/support
Branch: androidx-main

commit 49d18d3f7b42f7a5675357bd51fa4ff22ac0b5d5
Author: Ember Rose <emberrose@google.com>
Date:   Mon May 17 18:51:33 2021

    Shadowed attributes annotation processing
   
    Test: ResourceInspectionProcessorTest
    Bug: 188446121
    Change-Id: Icf4eb2cab92ccde42daf583566f0ce7aca6d6d34

M       resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M       resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
M       resourceinspection/resourceinspection-processor/src/test/kotlin/androidx/resourceinspection/processor/ResourceInspectionProcessorTest.kt

https://android-review.googlesource.com/1709968

Project: platform/frameworks/support
Branch: androidx-main

commit 6b505f5fbaa249d03647cfa5f236bea9a2967a12
Author: Ember Rose <emberrose@google.com>
Date:   Tue May 18 12:31:44 2021

    Document shadowed attribute interfaces
   
    Test: N/A (docs)
    Bug: 188446121
    Change-Id: I025fe8f50202c9a30a0bcfcd24cd63047f9b4c75

M       core/core/src/main/java/androidx/core/view/TintableBackgroundView.java
M       core/core/src/main/java/androidx/core/widget/AutoSizeableTextView.java
M       core/core/src/main/java/androidx/core/widget/TintableCheckedTextView.java
M       core/core/src/main/java/androidx/core/widget/TintableCompoundButton.java
M       core/core/src/main/java/androidx/core/widget/TintableCompoundDrawablesView.java
M       core/core/src/main/java/androidx/core/widget/TintableImageSourceView.java
M       resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java

https://android-review.googlesource.com/1711028

Project: platform/frameworks/support
Branch: androidx-main

commit 575674b572525f2ae8626306eab2a2cd264a7246
Author: Ember Rose <emberrose@google.com>
Date:   Tue May 18 17:53:29 2021

    Covert test dependencies to runtime only
   
    Compile testing needs these dependencies to be on the runtime
    classpath, but they're not needed on the implementation classpath.
    (All use is in source strings or code generated in the test itself.)
    This keeps the implementation classpath clean.
   
    Test: ResourceInspectionProcessorTest
    Bug: 188446121
    Change-Id: I0332d8049a3fb0e22b7565d9f98cc56a8dbe3783

M       resourceinspection/resourceinspection-processor/build.gradle

https://android-review.googlesource.com/1711049

Project: platform/frameworks/support
Branch: androidx-main

commit 1bc6fdbb39da2551ddbf94e3d96ff3cd35c8779d
Author: Ember Rose <emberrose@google.com>
Date:   Thu May 20 16:36:24 2021

    Resourece Inspection 1.0.0-alpha02
   
    Test: N/A
    Bug: 188446121
    Change-Id: I76330dac3210b000842ad8151d8cd2ddf9f2227a

M       buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt

https://android-review.googlesource.com/1714294

Hey there, sorry to get back to you so late.

After some investigation, it seems to be the SwipeRefreshLayout that is the culprit.

In the example that works fine that you provided me ( https://github.com/jcholin/viewpager2_issue_136194634) and wrap the fragment_child in a SwipeRefreshLayout, you can see the similar to behaviour to the NestedScrollView issues.

The heirachy in the video above for the child fragment  is pretty simple

<SwipeRefreshLayout>
     <ConstraintLayout>
         <CustomErrorView/>
         <RecyclerView/>
    </ConstraintLayout>
</SwipeRefreshLayout>

I can cofirm when I remove the SwipeRefreshLayout, it works as intended.
         

This is an issue with nested scrolling and has been fixed both in SwipeRefreshLayout [1] and in RecyclerView [2]. The fixes have been released in androidx.swiperefreshlayout:swiperefreshlayout:1.1.0-alpha02 and androidx.recyclerview:recyclerview:1.1.0-beta02.

In this particular case, you will only need the bugfix of RecyclerView, because with this view hierarchy RV is driving the nested scroll.
In the absence of a scrolling child in SRL, you would need the bugfix of SRL.
If you have any other scrolling child in SRL, that component either already does the right thing or needs to be fixed similar to how RV was fixed. To the best of my knowledge, the most likely candidate, NestedScrollView, already does the right thing.

Original issue: https://issuetracker.google.com/issues/131115697

[1] https://android-review.googlesource.com/c/973750/
[2] https://android-review.googlesource.com/c/1055911/

Can you confirm which version of RecyclerView you are using, and if not 1.1.0-beta02, see if the issue is fixed when using 1.1.0-beta02?

Hi,

I started using both 1.1.0-beta02 for recyclerview and 1.1.0-alpha02 for swiperefreshlayout, but unfortunately, still not working.

The only way I can get scroll behaviour as predicted, is it if remove the SwipeRefreshLayout all together.

I should mention the view heirachy I have shown you above is for the child fragment INSIDE of the viewpager. This is not the root activity layout.

Hi Tom, could you provide us with a working minimal sample reproducing the issue? It'd allow us to dive into it -- sounds like we've covered the obvious culprits.
Probably the easiest way to do it is to modify our sample [1], but any self-contained sample that'd allow us to reproduce the issue would be great.

[1] https://github.com/googlesamples/android-viewpager2

I have attached a previous example someone has sent you to include swipe refresh layout and all the latest versions of the components you suggested to change. Hope this helps.

We tracked down the bug to SwipeRefreshLayout, but it's a bit tricky to solve without breaking unrelated things.

(Sort of) good news. Thanks for keeping me up to date, as we're all extremely keen to use it here!

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6a9efe2e5b9ad406f486b5c4999fd6c119eb59fa
Author: Jelle Fresen <jellefresen@google.com>
Date:   Tue Aug 27 14:56:12 2019

    Improve SwipeRefreshLayout test
   
    Fixes/improvements in
    SwipeRefreshLayoutInHorizontallyScrollingParentTest:
    - Make sibling pages non-zero size
    - Calculates 'gesture distance' correctly
    - Accounts for touch slop when performing gesture
    - Asserts that requestDisallowInterceptTouchEvent(true) is called
    - Speeds up the gesture
   
    Bug: 138314213
    Test: ./gradlew swiperefreshlayout:cC
    Change-Id: I00a5f73ef0c54f41034cdacd023b8348e133384c

M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInHorizontallyScrollingParentTest.java
M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInRecyclerViewActivity.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeToRefreshLayoutRequestDisallowInterceptTest.java

https://android-review.googlesource.com/1108543
https://goto.google.com/android-sha1/6a9efe2e5b9ad406f486b5c4999fd6c119eb59fa

Hey all,

Just to confirm, I have tried the new update (beta-04) and the issue persists.

Correct, the issue needs one more fix in SwipeRefreshLayout. A fix is on the way, but we're still working on fleshing out the details. At the earliest it will be released on October 2nd. The latest status of the fix can be found here: https://android-review.googlesource.com/c/platform/frameworks/support/+/1108540

In the mean time, it might be possible to work around the issue by extending SwipeRefreshLayout and overriding "requestDisallowInterceptTouchEvent" with the following implementation:

    @Override
    public void requestDisallowInterceptTouchEvent(boolean b) {
        // Ignore here, but pass it up to our parent
        ViewParent parent = getParent();
        if (parent != null) {
            parent.requestDisallowInterceptTouchEvent(b);
        }
    }

Does that solve the problem for now?

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6d5f435733bf7c9975d1b8064605a237fe6086a9
Author: Jelle Fresen <jellefresen@google.com>
Date:   Fri Aug 23 10:53:45 2019

    Don't ignore requestDisallowInterceptTouchEvent in SRL
   
    A SwipeRefreshLayout ignored calls to requestDisallowInterceptTouchEvent
    when nested scrolling was not enabled in its child, but there is no good
    reason why it shouldn't propagate the call to its parents. It is OK for
    SRL itself to dishonor the request, as one can always use
    OnChildScrollUpCallback to control cooperation with scrolls in children.
   
    Bug: 138314213
    Test: ./gradlew swiperefreshlayout:cC
    Change-Id: I4959df942ebb2097f3c3ebe39ff0582f6ae6f395

M       swiperefreshlayout/api/1.1.0-alpha03.txt
M       swiperefreshlayout/api/current.txt
M       swiperefreshlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M       swiperefreshlayout/api/public_plus_experimental_current.txt
M       swiperefreshlayout/api/restricted_1.1.0-alpha03.txt
M       swiperefreshlayout/api/restricted_current.txt
M       swiperefreshlayout/build.gradle
M       swiperefreshlayout/src/androidTest/AndroidManifest.xml
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/RequestDisallowInterceptRecordingRecyclerView.java
M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInRecyclerViewBaseActivity.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInRecyclerViewWithRecyclerViewChildActivity.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInRecyclerViewWithSimpleChildActivity.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInScrollingParentAndChildTest.java
M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInScrollingParentBaseTest.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutInScrollingParentTest.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutRequestDisallowInterceptAsChildAndParentTest.java
A       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutRequestDisallowInterceptAsChildTest.java
M       swiperefreshlayout/src/androidTest/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayoutRequestDisallowInterceptBaseTest.java
M       swiperefreshlayout/src/main/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayout.java

https://android-review.googlesource.com/1108540
https://goto.google.com/android-sha1/6d5f435733bf7c9975d1b8064605a237fe6086a9

Fix will be released in swiperefreshlayout-1.1.0-alpha03 in early October

i am using it in
<swiperefreshlayout>
<recycler>
</swiperefreshlayout>
still getting this error

only in horizontal, updated recycler to 1.1.0 and refresh to 1.1.0-rc1

It's much better with this usage but sometimes I still getting this the issue. Especial, when swipeRefreshLayout is refreshing. You can see on the screen record.

ContainerFragment;
<androidx.constraintlayout.widget.ConstraintLayout>
        <com.google.android.material.tabs.TabLayout/>
        <androidx.viewpager2.widget.ViewPager2/>
</androidx.constraintlayout.widget.ConstraintLayout>

InnerFragment;
<androidx.swiperefreshlayout.widget.SwipeRefreshLayout>
    <FrameLayout android:nestedScrollingEnabled="true">
        <androidx.recyclerview.widget.RecyclerView/>
    </FrameLayout>
</androidx.swiperefreshlayout.widget.SwipeRefreshLayout>

constraintLayoutVersion = "1.1.3"
viewPager2 = "1.1.0-alpha01"
swipeRefreshLayoutVersion = "1.2.0-alpha01"
recyclerViewVersion = "1.2.0-alpha05"