IssueTracker

mdchurchill@google.com says:

The location of where this is being placed in the app bundle by AGP (as quoted in b/226434396#comment1) is also incorrect - rather than BUNDLE_METADATA/assets/dexopt/baseline.prof it should be at BUNDLE_METADATA/com.android.tools.build.profiles/baseline.prof or similar, to correctly identify what kind of metadata this is within the bundle. So that baseline profiles generated from android studio via the android app bundle actually work, we'd need to make these changes in AGP for the next stable release of studio.

Currently the baseline profile ends up in BUNDLE_METADATA/assets/dexopt/baseline.prof{m}.

It needs to end up in BUNDLE_METADATA/com.android.tools.build.profiles/baseline.prof{m} or something so we can disambiguate between the types of metadata.

Related public bug: b/226434396 and b/187484591

ok so we can move the location of the baseline.prof to the new location : BUNDLE_METADATA/com.android.tools.build.profiles/baseline.prof{m}

but this will not fix the previous versions of the plugins that have shipped with this behavior (including Bumblebee) so this needs to be handled by the playstore to look into both locations (for a while at least).

Martin mentioned on the email thread that they likely won't look in the previous location:

Bundletool guards its behavioural changes behind the bundletool version that the AAB was created with (so the developer knows how their bundles will be turned into apks, and there are no surprises). So we'd only be converting profiles-in-AAB to profiles-in-APKs for cases where the AAB was built with a bundletool that knew about profiles (which is, as of now, none of them - but bundletool 1.11 will).

In that case, if we don't fix it for Chipmunk release, we will have 2 stable versions of AGP that people are going to use for a while where the profile essentially gets lost, and the next stable release is not until July at least. I would argue we should make it a P0 and get the fix in AGP and potentially delay the stable release for a week. And in the worst case we should do it in a point release as soon as possible.

Currently the baseline profile ends up in BUNDLE_METADATA/assets/dexopt/baseline.prof{m}. It needs to end up in BUNDLE_METADATA/com.android.tools.build.profiles/baseline.prof{m}

Should we also move baseline profile in apk from

assets/dexopt/baseline.prof{m}

to

com.android.tools.build.profiles/baseline.prof{m}

After discussion: APK path for baseline.prof must stay the same assets/dexopt/baseline.prof

+1 to P0ing this and ensuring baseline profiles will be successfully packaged for bundle-using app developers ASAP. This is a huge priority as baseline profiles is the biggest intervention apps can do to improve their performance, and we're really advocating that every app take advantage of it right now!

Hi alexgolubev@, will this feature also land in the same version of the Android Gradle Plugin that the fix for multidex landed in?

I merged both CLs to Dolphin branch so it will be in Dolphin/AGP 7.3 Beta 1 Release

Should we also backport it to 7.2.1? What's the process to do it?

I am talking to Saurabh about it.