Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3a125bc687cebc7489a9ddb51e8dbe8f9ee032d4
Author: Dustin Lam <dustinlam@google.com>
Date: Sat Jul 27 19:40:11 2019
Move benchmark config into BenchmarkPlugin
This moves the isBenchmark check to disable code coverage and use the
correct runner from checking "*-benchmark" directory name to a gradle
extension property.
Fixes: 138374050
Test: ./gradlew cC
Change-Id: Idcc036ae7543559cb9f4d0b1b8a23b9afd31abfd
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
M benchmark/gradle-plugin/src/test/kotlin/androidx/benchmark/gradle/BenchmarkPluginTest.kt
M benchmark/junit4/build.gradle
M buildSrc/src/main/kotlin/androidx/build/AndroidXPlugin.kt
M buildSrc/src/main/kotlin/androidx/build/SupportConfig.kt
M ui/integration-tests/benchmark/build.gradle
https://android-review.googlesource.com/1092641
https://goto.google.com/android-sha1/3a125bc687cebc7489a9ddb51e8dbe8f9ee032d4
Branch: androidx-master-dev
commit 3a125bc687cebc7489a9ddb51e8dbe8f9ee032d4
Author: Dustin Lam <dustinlam@google.com>
Date: Sat Jul 27 19:40:11 2019
Move benchmark config into BenchmarkPlugin
This moves the isBenchmark check to disable code coverage and use the
correct runner from checking "*-benchmark" directory name to a gradle
extension property.
Fixes: 138374050
Test: ./gradlew cC
Change-Id: Idcc036ae7543559cb9f4d0b1b8a23b9afd31abfd
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
M benchmark/gradle-plugin/src/test/kotlin/androidx/benchmark/gradle/BenchmarkPluginTest.kt
M benchmark/junit4/build.gradle
M buildSrc/src/main/kotlin/androidx/build/AndroidXPlugin.kt
M buildSrc/src/main/kotlin/androidx/build/SupportConfig.kt
M ui/integration-tests/benchmark/build.gradle
Description
- benchmark instrumentation runner default
- disabling code coverage
- changing test output APK name
Consider instead
androidx {
...
isBenchmark = true
}
Or
plugins {
id("AndroidXBenchmarkPlugin")
}
The latter could also help with
Could also investigate controlling debug in a similar way, but we need to keep it easy to toggle for perf tools.