Enable the rest of Android API lint checks [138602561]

In Progress

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jul 29, 2019 09:43PM

Sponsor: aurimas@
Estimated workload: ~1 day per check
Technologies: Gradle, Metalava, API signature files

We have a number of API lint checks that are yet to be enabled. Some checks should be as simple as turning it on and whitelisting existing issues. Some checks will require improving the checks so it has less false positive results.

https://osscs.corp.google.com/androidx/platform/frameworks/support/+/androidx-master-dev:buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt;l=67?q=metalavarunner&ss=androidx%2Fplatform%2Fframeworks%2Fsupport

Comments

ap...@google.com <ap...@google.com> #2Sep 6, 2019 03:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019

API lint check for the MinMaxConstant is enabled for androidx

Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25

M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java

https://android-review.googlesource.com/1114511

https://goto.google.com/android-sha1/64f11e5722d8a574ccb72bfb042fa89f51129c68

ap...@google.com <ap...@google.com> #3Sep 19, 2019 04:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019

API lint check for the SetterReturnsThis is enabled for androidx

Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1123398

https://goto.google.com/android-sha1/536a1ff3c3c7623ef60ef89b45266afd63ca748f

ap...@google.com <ap...@google.com> #4Sep 27, 2019 09:51PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8aecbea988804f4f702812f6e7f50bc60359eed1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 17:50:47 2019

API lint check for the PackageLayering is enabled for androidx

PackageLayering is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I9a6c33d6686fa63f98cd150e5f8d97a57ea14472

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126765

https://goto.google.com/android-sha1/8aecbea988804f4f702812f6e7f50bc60359eed1

ap...@google.com <ap...@google.com> #5Sep 27, 2019 11:23PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 7426c6889ba80df99b2589454d0f604e0efd7b78
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:39:30 2019

API lint check for the OverlappingConstants is enabled for androidx

OverlappingConstants is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I312b39963b0b64e06a3bd5933156dc88bff76a1c

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126766

https://goto.google.com/android-sha1/7426c6889ba80df99b2589454d0f604e0efd7b78

ap...@google.com <ap...@google.com> #6Sep 30, 2019 12:25AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9108b6016c27854f67c529a98506f93ff3631a26
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:50:54 2019

API lint check for the IllegalStateException is enabled for androidx

IllegalStateException is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I025bd3b1ade7204b78b6c66b2b205a99ccc701cc

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126767

https://goto.google.com/android-sha1/9108b6016c27854f67c529a98506f93ff3631a26

ap...@google.com <ap...@google.com> #7Sep 30, 2019 09:10PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2f50846ff288d3e18f197cb9243b40c971438e7e
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 30 22:36:57 2019

API lint check for the PackageLayering is disabled for androidx

PackageLayering is moved to the
"// The list of checks that are hidden as they are not useful in androidx"
section in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ib9cfe9d0a64f9a19b1c28a28762f38da5fe61169

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1131079

https://goto.google.com/android-sha1/2f50846ff288d3e18f197cb9243b40c971438e7e

ap...@google.com <ap...@google.com> #8Oct 1, 2019 08:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 130035de9b227f0bedf6a4380f0a7dec89f41501
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 23 00:05:26 2019

API lint check for the ListenerLast is enabled for androidx

Existing issues are suppressed with updated baseline and the
ListenerLast is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ibc5ff8601a56c7d43793a1f0902d69468963c134

M appcompat/api/api_lint.ignore
M browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M core/core/api/api_lint.ignore
M media/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M ui/ui-foundation/api/api_lint.ignore

https://android-review.googlesource.com/1126768

https://goto.google.com/android-sha1/130035de9b227f0bedf6a4380f0a7dec89f41501

ap...@google.com <ap...@google.com> #9Oct 2, 2019 04:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a509937bc0bf65df2a6e62882c5dcec5015e5e37
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Sep 11 19:12:07 2019

API lint check for the MissingBuild is enabled for androidx

Existing issues are suppressed with updated baseline and the
MissingBuild is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I407b60c1f717b8ad1c8b1c5a17aa2aba68824305

M appcompat/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
A navigation/navigation-runtime/api/api_lint.ignore
M paging/rxjava2/api/api_lint.ignore
A palette/palette/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore

https://android-review.googlesource.com/1119191

https://goto.google.com/android-sha1/a509937bc0bf65df2a6e62882c5dcec5015e5e37

au...@google.com <au...@google.com> Oct 2, 2019 07:33PM

Assigned to za...@gmail.com.

ap...@google.com <ap...@google.com> #10Oct 8, 2019 01:00AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b472cbf0b66dda85bc2a176136f5a01c905be944
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Oct 07 22:43:56 2019

API lint check for the IntentBuilderName is commented

The IntentBuilderName is placed under
"// We should only treat these as warnings"
comment in the --hide section of the API_LINT_ARGS

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I2e6e5cd63f0b126b1c9388885abfc00c8289c2c7

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1115101

https://goto.google.com/android-sha1/b472cbf0b66dda85bc2a176136f5a01c905be944

ap...@google.com <ap...@google.com> #11Oct 8, 2019 06:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 00d7cd7c0920cee6cc6c9674f524e8a8fc4432cf
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 09 23:54:22 2019

API lint check for the OnNameExpected is commented

The OnNameExpected is placed under
"// We should only treat these as warnings"
comment in the --hide section of the API_LINT_ARGS

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I07892f5fcc61f40db2d2b13e310e767831ab8c0f

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1116042

https://goto.google.com/android-sha1/00d7cd7c0920cee6cc6c9674f524e8a8fc4432cf

ap...@google.com <ap...@google.com> #12Oct 17, 2019 09:41PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 11c11aa2f9d391c3616900ef7edd882d49c8b2d7
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Thu Oct 17 23:11:48 2019

API lint check for the AbstractInner is enabled for androidx

AbstractInner is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I0a82569652a064f76cb84233fe865d17b9337d11

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1145728

https://goto.google.com/android-sha1/11c11aa2f9d391c3616900ef7edd882d49c8b2d7

ap...@google.com <ap...@google.com> #13Oct 23, 2019 05:55PM

Project: platform/tools/metalava
Branch: master

commit cbccc81cd841437d587360a423aa88afdcf5ce49
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Oct 22 13:03:22 2019

Indicate the methods that cause the requirements to implement AutoClosable

Method descriptions added to warning message

Bug: 138602561

Test: ./gradlew test
Change-Id: Ibb2b48b83c9b5170dc9b03b21038d652b094fb22

M src/main/java/com/android/tools/metalava/ApiLint.kt
M src/test/java/com/android/tools/metalava/ApiLintTest.kt

https://android-review.googlesource.com/1147767

https://goto.google.com/android-sha1/cbccc81cd841437d587360a423aa88afdcf5ce49

ap...@google.com <ap...@google.com> #14Oct 25, 2019 08:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0b58731e733ba8c3fd60fb2edf2806d134dc19c9
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Oct 20 20:49:58 2019

API lint check for the ArrayReturn is enabled for androidx

Existing issues are suppressed with updated baseline and the
ArrayReturn is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ia49ddfc53b35cb9bbcd4bcbb402d1d0c237e40ca

M annotation/annotation/api/api_lint.ignore
M appcompat/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M collection/collection/api/api_lint.ignore
M core/core-ktx/api/api_lint.ignore
M core/core/api/api_lint.ignore
A documentfile/api/api_lint.ignore
M emoji/appcompat/api/api_lint.ignore
M emoji/core/api/api_lint.ignore
M leanback-preference/api/api_lint.ignore
M leanback/api/api_lint.ignore
M navigation/navigation-common/api/api_lint.ignore
M preference/preference/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/common/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M serialization/serialization-annotation/api/api_lint.ignore
M slices/core/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore
M ui/ui-framework/api/api_lint.ignore
M ui/ui-tooling/api/api_lint.ignore
M ui/ui-vector/api/api_lint.ignore
M webkit/api/api_lint.ignore

https://android-review.googlesource.com/1146899

https://goto.google.com/android-sha1/0b58731e733ba8c3fd60fb2edf2806d134dc19c9

ap...@google.com <ap...@google.com> #15Oct 28, 2019 10:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 32f135ba3a2b586463e2113682ed68c3f4286d21
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Oct 28 20:09:45 2019

API lint check for the UserHandle is disabled for androidx

UserHandle is moved to the
"// The list of checks that are hidden as they are not useful in androidx"
section in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I888f9e9766e958182940cd2c9ddb1dd18f759d47

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1151838

https://goto.google.com/android-sha1/32f135ba3a2b586463e2113682ed68c3f4286d21

ap...@google.com <ap...@google.com> #16Nov 14, 2019 05:09AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0cc73dfff4d4e52543566e1caf260c13736094e9
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Nov 13 22:58:48 2019

API lint check for the MethodNameTense is enabled for androidx

MethodNameTense is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ia5d193612e25719b962a07a97be5587c1b2bbdbd

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1165958

ap...@google.com <ap...@google.com> #17Nov 22, 2019 07:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 142d7af5f87c237b90314af7460b7d90637cacbc
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Oct 09 14:11:18 2019

API lint check for the StreamFiles is enabled for androidx

Existing issues are suppressed with updated baseline and the
StreamFiles is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I77227d3c53d9e31bcebc328a17da97e2d5de4c44

M browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M core/core-ktx/api/api_lint.ignore
M core/core/api/api_lint.ignore
M documentfile/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M security/crypto/api/api_lint.ignore
M webkit/api/api_lint.ignore

https://android-review.googlesource.com/1137252

ap...@google.com <ap...@google.com> #18Nov 25, 2019 08:42PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit aaeaf1ca6fd733b70d51bf9afe64544c18392900
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Fri Nov 22 23:06:16 2019

API lint check for the ParcelableList is disabled for androidx

ParcelableList is moved to the
"// The list of checks that are hidden as they are not useful in androidx"
section in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: If0f30e1460230006c1c2ef9ef1e7b51be845ddf8

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1140987

ap...@google.com <ap...@google.com> #19Dec 11, 2019 08:37PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2f36c768c627b1cce422c265808c0e20a0f4deba
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Dec 11 09:13:25 2019

API lint check for the UserHandleName is commented

The UserHandleName is placed under
"// We should only treat these as warnings"
comment in the --hide section of the API_LINT_ARGS

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I8ff0e1754fcac55bece7ea6da01bc898a9b01516

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1158907

ap...@google.com <ap...@google.com> #20Dec 17, 2019 09:12PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fff393746a891b52038b9fb5debe8e3ce35cc236
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Dec 17 22:00:39 2019

API lint check for the TopLevelBuilder is enabled for androidx

Existing issues are suppressed with updated baseline and the
TopLevelBuilder is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I7b99f947943afd9ad9a35234599a12707a2ed675

M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
M navigation/navigation-runtime/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M paging/rxjava2/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore
M ui/ui-framework/api/api_lint.ignore
M work/workmanager-testing/api/api_lint.ignore

https://android-review.googlesource.com/1118833

ap...@google.com <ap...@google.com> #21Jan 13, 2020 09:36PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit df260bdcbf037df940753dfce5b4a61b3422a0a1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sat Jan 11 22:33:16 2020

API lint check for the CommonArgsFirst is enabled for androidx

CommonArgsFirst is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ia45774f5655b02eb8286b2bade8718c992a12137

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1206244

ap...@google.com <ap...@google.com> #22Jan 16, 2020 04:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 7921fbf64d00b2a7968f94d3b56dc1759158249a
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sat Jan 11 17:54:21 2020

API lint check for the NoByteOrShort is enabled for androidx

Existing issues are suppressed with updated baseline and the
NoByteOrShort is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I1540206cc7e705c6fe2beb76cfc3c5d7472bb24e

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M core/core-ktx/api/api_lint.ignore
M exifinterface/exifinterface/api/api_lint.ignore
A ui/ui-util/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1206243

ap...@google.com <ap...@google.com> #23Feb 10, 2020 07:24PM

Project: platform/tools/metalava
Branch: master

commit d32d4d72493eec7e6130cd478384c1dc3426ab37
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sat Feb 08 21:59:21 2020

False positive warnings for MissingJvmStatic are fixed.

'@JvmOverloads' annotation cannot be used on interface methods

Bug: 138602561

Test: ./gradlew test
Change-Id: I8ec9f0f0a1e77f8a6b4786573eba5ed67ad78f1e

M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt

https://android-review.googlesource.com/1229892

ap...@google.com <ap...@google.com> #24Feb 10, 2020 07:41PM

Project: platform/tools/metalava
Branch: master

commit 5fc4d6bbfb95eb3a52100f9c052cffd6c74f0cec
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sat Feb 08 13:37:08 2020

False positive warnings for MissingJvmStatic are fixed.

Companion object constants with const modifier should not use @JvmField annotation

Bug: 138602561

Test: ./gradlew test

Change-Id: I8535fb72416c0d2a92ca179fa27cebb32192bdb8

M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/main/java/com/android/tools/metalava/model/DefaultModifierList.kt
M src/main/java/com/android/tools/metalava/model/ModifierList.kt
M src/main/java/com/android/tools/metalava/model/psi/PsiModifierItem.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt

https://android-review.googlesource.com/1229891

ap...@google.com <ap...@google.com> #25Feb 13, 2020 02:37PM

Project: platform/tools/metalava
Branch: master

commit d97c1b33c7cdeb764e9e39047bf058122a42208f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Feb 10 21:16:39 2020

Fields that should be flagged with MissingJvmStatic are now flagged.

Public, non-const properties which are effective constants in a companion
object that are missing @JvmField annotation are now flagged with
MissingJvmStatic warning.

Bug: 138602561

Test: ./gradlew test

Change-Id: I02a8c8ee81e2db619413fdca4a588d1d9bb140f3

M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt

https://android-review.googlesource.com/1231491

ap...@google.com <ap...@google.com> #26Feb 20, 2020 11:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ba95f70d6f212b92b488b172a67659d9b8562307
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 17:07:18 2019

API lint check for the BuilderSetStyle is enabled for androidx

Existing issues are suppressed with updated baseline and the
BuilderSetStyle is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I88a5da3881049d3048efbd9e45f6b04cfe7589a1

A animation/animation/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M recyclerview/recyclerview-selection/api/api_lint.ignore

https://android-review.googlesource.com/1123357

ap...@google.com <ap...@google.com> #27Mar 5, 2020 07:28PM

Project: platform/tools/metalava
Branch: master

commit e83d72690645dacc5af1183908a6035b4fa4e8da
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Mar 02 01:27:53 2020

Fixed flagging of public, non-const properties in a companion object with MissingJvmStatic

Non-public properties in a companion object should not be flagged with MissingJvmStatic.
Fixed writing ID for MissingJvmstatic in api_lint.ignore file.

Bug: 138602561

Test: ./gradlew test
Change-Id: I58db4ad1108a79f0a796e4d5dd43236246b52785

M src/main/java/com/android/tools/metalava/Baseline.kt
M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt

https://android-review.googlesource.com/1247668

ap...@google.com <ap...@google.com> #28May 1, 2020 06:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 72e4fe48dda674f42f4f8ed5a265edddd4abf177
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Apr 29 23:57:31 2020

API lint check for the UseIcu is enabled for androidx

Existing issues are suppressed with updated baseline and the
UseIcu is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Icbdaccad1078623e9e968651aff9c0f04d166905

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1205428

ap...@google.com <ap...@google.com> #29May 26, 2020 07:10PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 72583b1a33918bcd4064704eeeb84a13e44ad45d
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Thu Mar 19 18:00:55 2020

API lint check for the MissingJvmstatic is enabled for androidx

The check is enabled only for projects intended to be accessed from
Java-language source code.

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I8ff95224f8246426f88a2c49c563e268080905d5

M buildSrc/src/main/kotlin/androidx/build/AndroidXExtension.kt
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M datastore/datastore-preferences/api/1.0.0-alpha01.txt
M datastore/datastore-preferences/api/current.txt
M datastore/datastore-preferences/api/public_plus_experimental_1.0.0-alpha01.txt
M datastore/datastore-preferences/api/public_plus_experimental_current.txt
M datastore/datastore-preferences/api/restricted_1.0.0-alpha01.txt
M datastore/datastore-preferences/api/restricted_current.txt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/Preferences.kt
M paging/common/api/api_lint.ignore

https://android-review.googlesource.com/1236386

ap...@google.com <ap...@google.com> #30Jun 15, 2020 07:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5bb26c0c742912c5fe99ffd46e3558c556f2de0a
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Dec 03 17:54:01 2019

API lint check for the NotCloseable is enabled for androidx

Existing issues are suppressed with updated baseline and the
NotCloseable is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I6e40ebb4a9531766dbb4c064ba6e10feab26d635

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/compose-runtime/api/api_lint.ignore
M concurrent/futures/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore
M ui/ui-graphics/api/api_lint.ignore
A ui/ui-material/api/api_lint.ignore
M vectordrawable/vectordrawable-animated/api/api_lint.ignore

https://android-review.googlesource.com/1145729

ap...@google.com <ap...@google.com> #31Jul 6, 2020 04:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 017c121d8aede0439072de34890e61fbab5c3c59
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Jul 05 00:51:15 2020

API lint check for the MissingJvmstatic is enabled for androidx

The check is enabled only for projects intended to be accessed from
Java-language source code.

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ic4468e8bedf6c1479b54983a2dfecd57cdd06e2c

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1355264

ap...@google.com <ap...@google.com> #32Aug 20, 2020 10:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4a6bc898df028ed81a424f0a970d4ca5c40bf589
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Feb 19 03:55:58 2020

API lint check for the ExecutorRegistration is enabled for androidx

Existing issues are suppressed with updated baseline and the
ExecutorRegistration is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I46c81f7f8a4906149ac241a7d7d8ef5eedcd1724

M activity/activity/api/api_lint.ignore
M appcompat/appcompat/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/interop/Camera2Interop.java
M compose/runtime/runtime/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M contentpager/contentpager/api/api_lint.ignore
M core/core/api/api_lint.ignore
M emoji/core/api/api_lint.ignore
A enterprise/feedback/api/api_lint.ignore
A enterprise/feedback/testing/api/api_lint.ignore
M leanback/leanback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M mediarouter/mediarouter/api/api_lint.ignore
M navigation/navigation-runtime/api/api_lint.ignore
M navigation/navigation-ui/api/api_lint.ignore
M paging/common/api/api_lint.ignore
A paging/runtime/api/api_lint.ignore
M preference/preference/api/api_lint.ignore
A print/print/api/api_lint.ignore
M recyclerview/recyclerview-selection/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M security/crypto/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M slices/view/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
A window/window-extensions/api/api_lint.ignore
M window/window-sidecar/api/api_lint.ignore

https://android-review.googlesource.com/1242687

ap...@google.com <ap...@google.com> #33Aug 24, 2020 04:17PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit aefc62cba13de9888609b7372ddaf808c263a80b
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Aug 24 09:02:19 2020

Add missing API baselines for aosp/1242687

Relnote: n/a
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I9869a6f29a9844392ecd537a029c708fde09707e

M room/runtime/api/api_lint.ignore

https://android-review.googlesource.com/1408983

ap...@google.com <ap...@google.com> #34Aug 24, 2020 06:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5e7fc48929b3fd30a0717ae423b7814c42a4c941
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun May 17 18:28:55 2020

API lint check for the CallbackMethodName is enabled for androidx

Existing issues are suppressed with updated baseline and the
CallbackMethodName is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Id5b690751b23319580b109d5cb1039d3ed592617

M activity/activity/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/ui/ui/api/api_lint.ignore
M contentpager/contentpager/api/api_lint.ignore
M customview/customview/api/api_lint.ignore
M leanback/leanback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M preference/preference/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M remotecallback/remotecallback/api/api_lint.ignore
M swiperefreshlayout/swiperefreshlayout/api/api_lint.ignore
M wear/wear/api/api_lint.ignore

https://android-review.googlesource.com/1313235

ap...@google.com <ap...@google.com> #35Aug 31, 2020 04:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fdb836b6143bae101047a1a0241f69a1cb82294e
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon May 18 02:36:46 2020

API lint check for the GetterOnBuilder is enabled for androidx

Existing issues are suppressed with updated baseline and the
GetterOnBuilder is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I4b717667f833b8240b1f4432344026f44dd0d93e

M appcompat/appcompat/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/ui/ui-graphics/api/api_lint.ignore
M compose/ui/ui-text/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore

https://android-review.googlesource.com/1313236

ap...@google.com <ap...@google.com> #36Sep 2, 2020 03:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 012a88b4545d870c4df83783cbb922f2967ec9f5
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed May 20 00:06:53 2020

API lint check for the StaticFinalBuilder is enabled for androidx

Existing issues are suppressed with updated baseline and the
StaticFinalBuilder is turned into an error in androidx configuration

Relnote: API lint check for the StaticFinalBuilder is enabled for androidx

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I2b11be1bb370e178e3e0d1d1083d43af38eece23

M appcompat/appcompat/api/api_lint.ignore
A appsearch/appsearch/api/api_lint.ignore
A biometric/biometric/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-core/api/api_lint.ignore
M camera/camera-core/api/public_plus_experimental_1.0.0-beta07.txt
M camera/camera-core/api/public_plus_experimental_1.0.0-beta09.txt
M camera/camera-core/api/public_plus_experimental_current.txt
M camera/camera-core/src/main/java/androidx/camera/core/UseCaseGroup.java
M camera/camera-core/src/main/java/androidx/camera/core/ViewPort.java
M core/core-animation/api/api_lint.ignore
M core/core/api/api_lint.ignore
M enterprise/feedback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M tv-provider/tv-provider/api/api_lint.ignore
M webkit/webkit/api/api_lint.ignore
M work/workmanager-testing/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1315354

ap...@google.com <ap...@google.com> #37Oct 21, 2020 05:53PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 757ff428f74b1d85f4a932e55fc7d79aabf555b9
Author: Alexander Dorokhine <adorokhine@google.com>
Date: Tue Oct 20 22:30:12 2020

Enable API lint check for MissingGetterMatchingBuilder in androidx.

Existing issues are suppressed with updated baseline and
MissingGetterMatchingBuilder is turned into an error in androidx
configuration

This linter is enabled in framework, and its lack in androidx made it
more difficult to share code.

Relnote: API lint check for MissingGetterMatchingBuilder is enabled for androidx

Bug: 138602561
Bug: 171261337
Test: ./gradlew checkApi
Change-Id: I4bbeacf9869d8338a3d7086acb40bc56ec68c3f9

M activity/activity/api/api_lint.ignore
M appsearch/appsearch/api/api_lint.ignore
M autofill/autofill/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-core/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M core/core/api/api_lint.ignore
M heifwriter/heifwriter/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/session/api/api_lint.ignore
M mediarouter/mediarouter/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
M navigation/navigation-common/api/api_lint.ignore
A navigation/navigation-fragment/api/api_lint.ignore
M navigation/navigation-runtime/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M recommendation/recommendation/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M security/crypto/api/api_lint.ignore
A security/identity-credential/api/api_lint.ignore
M textclassifier/textclassifier/api/api_lint.ignore
M tv-provider/tv-provider/api/api_lint.ignore
A wear/wear-complications-data/api/api_lint.ignore
A wear/wear-watchface/api/api_lint.ignore
M webkit/webkit/api/api_lint.ignore
M work/workmanager-testing/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1468060

za...@gmail.com <za...@gmail.com> Oct 21, 2020 06:33PM

Accepted by za...@gmail.com.

ap...@google.com <ap...@google.com> #38Jul 20, 2023 06:28PM