Enable the rest of Android API lint checks [138602561]

In Progress

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jul 29, 2019 09:43PM

Sponsor: aurimas@
Estimated workload: ~1 day per check
Technologies: Gradle, Metalava, API signature files

We have a number of API lint checks that are yet to be enabled. Some checks should be as simple as turning it on and whitelisting existing issues. Some checks will require improving the checks so it has less false positive results.

https://osscs.corp.google.com/androidx/platform/frameworks/support/+/androidx-master-dev:buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt;l=67?q=metalavarunner&ss=androidx%2Fplatform%2Fframeworks%2Fsupport

Comments

ap...@google.com <ap...@google.com> #2Sep 6, 2019 03:35PM

Is there any way to use this while it's not available, without a big if else where we do everything duplicated? Like this example.

        val notification = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
            Notification.Builder(...)
                .setContentTitle("Title")
                .setStyle(...)
                // Duplicate everything here!!!
                .build()
        } else {
            NotificationCompat.Builder(...)
                .setContentTitle("Title")
                .setStyle(...)
                // Duplicate everything here!!!
                .build()
        }

ap...@google.com <ap...@google.com> #3Sep 19, 2019 04:39PM

Hi,

Could you at least tell us if you will add the CallStyle to the NotificationCompat API?

Best regards,

ap...@google.com <ap...@google.com> #4Sep 27, 2019 09:51PM

Yes. Our goal is to provide an implementation that uses CallStyle on API 31+ and uses the new fields to produce a usable call notification, based on the device's standard template, on older versions of Android.

ap...@google.com <ap...@google.com> #5Sep 27, 2019 11:23PM

Thanks for the answer. Do you have an estimated ETA?

ap...@google.com <ap...@google.com> #6Sep 30, 2019 12:25AM

Any update on this please?

ap...@google.com <ap...@google.com> #7Sep 30, 2019 09:10PM

Could you please give us an ETA?

ap...@google.com <ap...@google.com> #8Oct 1, 2019 08:06PM

Hello again,

It's been a while now that Android 12 has been released, and it would be great to have an estimated time of arrival for this feature in appcompat package so we can plan our developments & releases as app developers.

Thanks in advance.

ap...@google.com <ap...@google.com> #9Oct 2, 2019 04:34PM

Hi @google,
Any update on this please?

au...@google.com <au...@google.com> Oct 2, 2019 07:33PM

Assigned to za...@gmail.com.

ap...@google.com <ap...@google.com> #10Oct 8, 2019 01:00AM

Is this planned for androidx.core:core:1.8.0 ?

ap...@google.com <ap...@google.com> #11Oct 8, 2019 06:44PM

Is someone there? -_-

ap...@google.com <ap...@google.com> #12Oct 17, 2019 09:41PM

Google has left the bugtracker

ap...@google.com <ap...@google.com> #13Oct 23, 2019 05:55PM

Any news?

ap...@google.com <ap...@google.com> #14Oct 25, 2019 08:44PM

Monthly ping...

ap...@google.com <ap...@google.com> #15Oct 28, 2019 10:35PM

Seriously guys it's been 10 months...

ap...@google.com <ap...@google.com> #16Nov 14, 2019 05:09AM

Hello guys, this Style is now required on Android 13 to get Notification Permission exemption for VoIP Apps.

If you want dev to adopt Android 13 API, you should really consider including it in AndroidX.

Having such important feature ignored for months, is a strong signal that adopting Android 13 API should be delayed for any serious developer.

ap...@google.com <ap...@google.com> #17Nov 22, 2019 07:33PM

deleted

ap...@google.com <ap...@google.com> #18Nov 25, 2019 08:42PM

Ping, guys.

ap...@google.com <ap...@google.com> #19Dec 11, 2019 08:37PM

Monthly ping

ap...@google.com <ap...@google.com> #20Dec 17, 2019 09:12PM

ping please

ap...@google.com <ap...@google.com> #21Jan 13, 2020 09:36PM

What do we want? CallStyle in NotificationCompat!!! When do we want it? Months ago!

ap...@google.com <ap...@google.com> #22Jan 16, 2020 04:39PM

Please update on ETA

ap...@google.com <ap...@google.com> #23Feb 10, 2020 07:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5916349f37585425a855d0b13259009d1843d28c
Author: Alexander Roederer <aroederer@google.com>
Date: Wed Aug 10 14:44:51 2022

Adds CallStyle to NotificationCompat

Adds CallStyle to NotificationCompat. Adds support for use of
Notification.CallStyle in API version 31 and higher, and creates an
unstyled notification that mimics the look of CallStyle in versions
lower than 31. Also adds testing to cover these cases.

Test: Added unit test coverage for all new class uses
Bug: 199294989
Change-Id: Id9a5321ab9172a004215c85aa2e6d7165a01e074
Relnote: Adds Callstyle to NotificationCompat

M core/core/api/current.txt
M core/core/api/public_plus_experimental_current.txt
M core/core/api/restricted_current.txt
M core/core/src/androidTest/java/androidx/core/app/NotificationCompatTest.java
M core/core/src/main/java/androidx/core/app/NotificationCompat.java
A core/core/src/main/res/drawable/ic_call_answer.xml
A core/core/src/main/res/drawable/ic_call_answer_low.xml
A core/core/src/main/res/drawable/ic_call_answer_video.xml
A core/core/src/main/res/drawable/ic_call_answer_video_low.xml
A core/core/src/main/res/drawable/ic_call_decline.xml
A core/core/src/main/res/drawable/ic_call_decline_low.xml
M core/core/src/main/res/values/colors.xml
M core/core/src/main/res/values/strings.xml

https://android-review.googlesource.com/2269806

ap...@google.com <ap...@google.com> #24Feb 10, 2020 07:41PM

CallStyle is now available in NotificationCompat. Please note associated doc comments regarding the use of this style, namely that CallStyle Notifications need to be associated with a foreground service and for proper ranking on older versions, we encourage marking the Notification as colorized, using Builder#setColorized.

ap...@google.com <ap...@google.com> #25Feb 13, 2020 02:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core:1.10.0-alpha01

ap...@google.com <ap...@google.com> #26Feb 20, 2020 11:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ba95f70d6f212b92b488b172a67659d9b8562307
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 17:07:18 2019

API lint check for the BuilderSetStyle is enabled for androidx

Existing issues are suppressed with updated baseline and the
BuilderSetStyle is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I88a5da3881049d3048efbd9e45f6b04cfe7589a1

A animation/animation/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M recyclerview/recyclerview-selection/api/api_lint.ignore

https://android-review.googlesource.com/1123357

ap...@google.com <ap...@google.com> #27Mar 5, 2020 07:28PM

Project: platform/tools/metalava
Branch: master

commit e83d72690645dacc5af1183908a6035b4fa4e8da
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Mar 02 01:27:53 2020

Fixed flagging of public, non-const properties in a companion object with MissingJvmStatic

Non-public properties in a companion object should not be flagged with MissingJvmStatic.
Fixed writing ID for MissingJvmstatic in api_lint.ignore file.

Bug: 138602561

Test: ./gradlew test
Change-Id: I58db4ad1108a79f0a796e4d5dd43236246b52785

M src/main/java/com/android/tools/metalava/Baseline.kt
M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt

https://android-review.googlesource.com/1247668

ap...@google.com <ap...@google.com> #28May 1, 2020 06:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 72e4fe48dda674f42f4f8ed5a265edddd4abf177
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Apr 29 23:57:31 2020

API lint check for the UseIcu is enabled for androidx

Existing issues are suppressed with updated baseline and the
UseIcu is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Icbdaccad1078623e9e968651aff9c0f04d166905

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1205428

ap...@google.com <ap...@google.com> #29May 26, 2020 07:10PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 72583b1a33918bcd4064704eeeb84a13e44ad45d
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Thu Mar 19 18:00:55 2020

API lint check for the MissingJvmstatic is enabled for androidx

The check is enabled only for projects intended to be accessed from
Java-language source code.

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I8ff95224f8246426f88a2c49c563e268080905d5

M buildSrc/src/main/kotlin/androidx/build/AndroidXExtension.kt
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M datastore/datastore-preferences/api/1.0.0-alpha01.txt
M datastore/datastore-preferences/api/current.txt
M datastore/datastore-preferences/api/public_plus_experimental_1.0.0-alpha01.txt
M datastore/datastore-preferences/api/public_plus_experimental_current.txt
M datastore/datastore-preferences/api/restricted_1.0.0-alpha01.txt
M datastore/datastore-preferences/api/restricted_current.txt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/Preferences.kt
M paging/common/api/api_lint.ignore

https://android-review.googlesource.com/1236386

ap...@google.com <ap...@google.com> #30Jun 15, 2020 07:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5bb26c0c742912c5fe99ffd46e3558c556f2de0a
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Dec 03 17:54:01 2019

API lint check for the NotCloseable is enabled for androidx

Existing issues are suppressed with updated baseline and the
NotCloseable is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I6e40ebb4a9531766dbb4c064ba6e10feab26d635

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/compose-runtime/api/api_lint.ignore
M concurrent/futures/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore
M ui/ui-graphics/api/api_lint.ignore
A ui/ui-material/api/api_lint.ignore
M vectordrawable/vectordrawable-animated/api/api_lint.ignore

https://android-review.googlesource.com/1145729

ap...@google.com <ap...@google.com> #31Jul 6, 2020 04:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 017c121d8aede0439072de34890e61fbab5c3c59
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Jul 05 00:51:15 2020

API lint check for the MissingJvmstatic is enabled for androidx

The check is enabled only for projects intended to be accessed from
Java-language source code.

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ic4468e8bedf6c1479b54983a2dfecd57cdd06e2c

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1355264

ap...@google.com <ap...@google.com> #32Aug 20, 2020 10:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4a6bc898df028ed81a424f0a970d4ca5c40bf589
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Feb 19 03:55:58 2020

API lint check for the ExecutorRegistration is enabled for androidx

Existing issues are suppressed with updated baseline and the
ExecutorRegistration is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I46c81f7f8a4906149ac241a7d7d8ef5eedcd1724

M activity/activity/api/api_lint.ignore
M appcompat/appcompat/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/interop/Camera2Interop.java
M compose/runtime/runtime/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M contentpager/contentpager/api/api_lint.ignore
M core/core/api/api_lint.ignore
M emoji/core/api/api_lint.ignore
A enterprise/feedback/api/api_lint.ignore
A enterprise/feedback/testing/api/api_lint.ignore
M leanback/leanback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M mediarouter/mediarouter/api/api_lint.ignore
M navigation/navigation-runtime/api/api_lint.ignore
M navigation/navigation-ui/api/api_lint.ignore
M paging/common/api/api_lint.ignore
A paging/runtime/api/api_lint.ignore
M preference/preference/api/api_lint.ignore
A print/print/api/api_lint.ignore
M recyclerview/recyclerview-selection/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M security/crypto/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M slices/view/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
A window/window-extensions/api/api_lint.ignore
M window/window-sidecar/api/api_lint.ignore

https://android-review.googlesource.com/1242687

ap...@google.com <ap...@google.com> #33Aug 24, 2020 04:17PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit aefc62cba13de9888609b7372ddaf808c263a80b
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Aug 24 09:02:19 2020

Add missing API baselines for aosp/1242687

Relnote: n/a
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I9869a6f29a9844392ecd537a029c708fde09707e

M room/runtime/api/api_lint.ignore

https://android-review.googlesource.com/1408983

ap...@google.com <ap...@google.com> #34Aug 24, 2020 06:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5e7fc48929b3fd30a0717ae423b7814c42a4c941
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun May 17 18:28:55 2020

API lint check for the CallbackMethodName is enabled for androidx

Existing issues are suppressed with updated baseline and the
CallbackMethodName is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Id5b690751b23319580b109d5cb1039d3ed592617

M activity/activity/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/ui/ui/api/api_lint.ignore
M contentpager/contentpager/api/api_lint.ignore
M customview/customview/api/api_lint.ignore
M leanback/leanback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M preference/preference/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M remotecallback/remotecallback/api/api_lint.ignore
M swiperefreshlayout/swiperefreshlayout/api/api_lint.ignore
M wear/wear/api/api_lint.ignore

https://android-review.googlesource.com/1313235

ap...@google.com <ap...@google.com> #35Aug 31, 2020 04:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fdb836b6143bae101047a1a0241f69a1cb82294e
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon May 18 02:36:46 2020

API lint check for the GetterOnBuilder is enabled for androidx

Existing issues are suppressed with updated baseline and the
GetterOnBuilder is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I4b717667f833b8240b1f4432344026f44dd0d93e

M appcompat/appcompat/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/ui/ui-graphics/api/api_lint.ignore
M compose/ui/ui-text/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore

https://android-review.googlesource.com/1313236

ap...@google.com <ap...@google.com> #36Sep 2, 2020 03:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 012a88b4545d870c4df83783cbb922f2967ec9f5
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed May 20 00:06:53 2020

API lint check for the StaticFinalBuilder is enabled for androidx

Existing issues are suppressed with updated baseline and the
StaticFinalBuilder is turned into an error in androidx configuration

Relnote: API lint check for the StaticFinalBuilder is enabled for androidx

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I2b11be1bb370e178e3e0d1d1083d43af38eece23

M appcompat/appcompat/api/api_lint.ignore
A appsearch/appsearch/api/api_lint.ignore
A biometric/biometric/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-core/api/api_lint.ignore
M camera/camera-core/api/public_plus_experimental_1.0.0-beta07.txt
M camera/camera-core/api/public_plus_experimental_1.0.0-beta09.txt
M camera/camera-core/api/public_plus_experimental_current.txt
M camera/camera-core/src/main/java/androidx/camera/core/UseCaseGroup.java
M camera/camera-core/src/main/java/androidx/camera/core/ViewPort.java
M core/core-animation/api/api_lint.ignore
M core/core/api/api_lint.ignore
M enterprise/feedback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M tv-provider/tv-provider/api/api_lint.ignore
M webkit/webkit/api/api_lint.ignore
M work/workmanager-testing/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1315354

ap...@google.com <ap...@google.com> #37Oct 21, 2020 05:53PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 757ff428f74b1d85f4a932e55fc7d79aabf555b9
Author: Alexander Dorokhine <adorokhine@google.com>
Date: Tue Oct 20 22:30:12 2020

Enable API lint check for MissingGetterMatchingBuilder in androidx.

Existing issues are suppressed with updated baseline and
MissingGetterMatchingBuilder is turned into an error in androidx
configuration

This linter is enabled in framework, and its lack in androidx made it
more difficult to share code.

Relnote: API lint check for MissingGetterMatchingBuilder is enabled for androidx

Bug: 138602561
Bug: 171261337
Test: ./gradlew checkApi
Change-Id: I4bbeacf9869d8338a3d7086acb40bc56ec68c3f9

M activity/activity/api/api_lint.ignore
M appsearch/appsearch/api/api_lint.ignore
M autofill/autofill/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-core/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M core/core/api/api_lint.ignore
M heifwriter/heifwriter/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/session/api/api_lint.ignore
M mediarouter/mediarouter/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
M navigation/navigation-common/api/api_lint.ignore
A navigation/navigation-fragment/api/api_lint.ignore
M navigation/navigation-runtime/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M recommendation/recommendation/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M security/crypto/api/api_lint.ignore
A security/identity-credential/api/api_lint.ignore
M textclassifier/textclassifier/api/api_lint.ignore
M tv-provider/tv-provider/api/api_lint.ignore
A wear/wear-complications-data/api/api_lint.ignore
A wear/wear-watchface/api/api_lint.ignore
M webkit/webkit/api/api_lint.ignore
M work/workmanager-testing/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1468060

za...@gmail.com <za...@gmail.com> Oct 21, 2020 06:33PM

Accepted by za...@gmail.com.

ap...@google.com <ap...@google.com> #38Jul 20, 2023 06:28PM