Enable the rest of Android API lint checks [138602561]

In Progress

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jul 29, 2019 09:43PM

Sponsor: aurimas@
Estimated workload: ~1 day per check
Technologies: Gradle, Metalava, API signature files

We have a number of API lint checks that are yet to be enabled. Some checks should be as simple as turning it on and whitelisting existing issues. Some checks will require improving the checks so it has less false positive results.

https://osscs.corp.google.com/androidx/platform/frameworks/support/+/androidx-master-dev:buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt;l=67?q=metalavarunner&ss=androidx%2Fplatform%2Fframeworks%2Fsupport

Comments

ap...@google.com <ap...@google.com> #2Sep 6, 2019 03:35PM

Hello,

Thank you for reaching out.

The Product team is working on this issue. This request has no ETA, but you can follow the progress in this thread.

ap...@google.com <ap...@google.com> #3Sep 19, 2019 04:39PM

Any updates on this? Fedora 35 uses python 3.10 and gcloud is broken on this OS currently.

ap...@google.com <ap...@google.com> #4Sep 27, 2019 09:51PM

Workaround for Fedora 35: Downgrade python 3 or add the following to .bashrc:

export CLOUDSDK_PYTHON=/usr/bin/python2

ap...@google.com <ap...@google.com> #5Sep 27, 2019 11:23PM

Better workaround for Fedora, install python 3.9 and use that instead of 2.7

https://developer.fedoraproject.org/tech/languages/python/multiple-pythons.html

ap...@google.com <ap...@google.com> #6Sep 30, 2019 12:25AM

It's fixed now on Fedora 35 with latest sdk

ap...@google.com <ap...@google.com> #7Sep 30, 2019 09:10PM

It's not. Google Cloud SDK still doesn't support Python 3.10 with the latest 366.0:

>gcloud
ERROR: gcloud failed to load: module 'collections' has no attribute 'Mapping'
gcloud_main = _import_gcloud_main()
import googlecloudsdk.gcloud_main
from googlecloudsdk.calliope import cli
from googlecloudsdk.calliope import actions
from googlecloudsdk.calliope import markdown
from googlecloudsdk.calliope import usage_text
from googlecloudsdk.calliope import parser_arguments
from googlecloudsdk.calliope import parser_completer
from googlecloudsdk.core.console import progress_tracker
class _BaseStagedProgressTracker(collections.Mapping):

ap...@google.com <ap...@google.com> #8Oct 1, 2019 08:06PM

Strange I don't have problem anymore with same version. I didn't set CLOUDSDK_PYTHON

ap...@google.com <ap...@google.com> #9Oct 2, 2019 04:34PM

It seems that is fixed in SDK 367.0.0

au...@google.com <au...@google.com> Oct 2, 2019 07:33PM

Assigned to za...@gmail.com.

ap...@google.com <ap...@google.com> #10Oct 8, 2019 01:00AM

The fix is released with gcloud version 367.0.0 today. Please download latest gcloud version to work with Python 3.10.

ap...@google.com <ap...@google.com> #11Oct 8, 2019 06:44PM

Thanks. I can confirm that at least on Windows 10 using latest Python 3.10 from MS Store I'm now able to run gcloud SDK.

ap...@google.com <ap...@google.com> #12Oct 17, 2019 09:41PM

for some reason running gcloud on it's own still produces error (on Mac)

~ ❯ gcloud --version                                       
Google Cloud SDK 367.0.0
beta 2021.12.10
bq 2.0.72
core 2021.12.10
gsutil 5.5
~ ❯ gcloud                                                   
ERROR: (gcloud) Command name argument expected.
ERROR: gcloud crashed (CommandLoadFailure): Problem loading gcloud.events: module 'collections' has no attribute 'MutableMapping'.

If you would like to report this issue, please run the following command:
  gcloud feedback

To check gcloud for common problems, please run the following command:
  gcloud info --run-diagnostics

ap...@google.com <ap...@google.com> #13Oct 23, 2019 05:55PM

Hi i could not reproduce the issue. could you please try fresh download the latest gcloud?

$ export CLOUDSDK_PYTHON=/Library/Frameworks/Python.framework/Versions/3.10/bin/python3
$ gcloud --version
Google Cloud SDK 367.0.0
bq 2.0.72
core 2021.12.10
gsutil 5.5

ap...@google.com <ap...@google.com> #14Oct 25, 2019 08:44PM

I can. gcloud when used with any of parameters works fine. However without parameters it produces an error:

>gcloud --version
Google Cloud SDK 367.0.0
beta 2021.12.10
bq 2.0.72
core 2021.12.10
gsutil 5.5
kubectl 1.20.8

>gcloud projects list
PROJECT_ID NAME PROJECT_NUMBER
xxxxxxxxxxxx XXXXXXXXXXXXX 1234556789

>gcloud
ERROR: (gcloud) Command name argument expected.
ERROR: gcloud crashed (CommandLoadFailure): Problem loading gcloud.events: module 'collections' has no attribute 'MutableMapping'.

ap...@google.com <ap...@google.com> #15Oct 28, 2019 10:35PM

Thanks. I can reproduce it. We will work on a fix.

ap...@google.com <ap...@google.com> #16Nov 14, 2019 05:09AM

i can confirm - gcloud with parameters doesn't work.

Version: 367.0.0
Python: 3.10

ap...@google.com <ap...@google.com> #17Nov 22, 2019 07:33PM

HI Coco,

I see another bug related to this and it says it fixed, is that true?

https://buganizer.corp.google.com/issues/202258405

Thanks!

ap...@google.com <ap...@google.com> #18Nov 25, 2019 08:42PM

vinwong@ https://buganizer.corp.google.com/issues/202258405 is fixed.

ap...@google.com <ap...@google.com> #19Dec 11, 2019 08:37PM

thanks cocosheng@

So, just want to verify one last thing, so is GCP SDK now fully support Python 3.10? I just want to make sure it is before I tell the customer, thanks!

Vincent

ap...@google.com <ap...@google.com> #20Dec 17, 2019 09:12PM

for now, running gcloud without any parameters still throws an error.

ap...@google.com <ap...@google.com> #21Jan 13, 2020 09:36PM

I'm still getting the error when I try to deploy to App Engine Flexible using the `gloud app deploy` command. As a temporary workaround, I've set the SDK to use Python 3.9.

ap...@google.com <ap...@google.com> #22Jan 16, 2020 04:39PM

vinwong@ we don't have full support for python 3.10 yet.

ap...@google.com <ap...@google.com> #23Feb 10, 2020 07:24PM

Thanks! Do we have any ETA on when it might have a solution that will make the SDK fully support using Python 3.10? Just want to set the customer's expectation, thanks!

ap...@google.com <ap...@google.com> #24Feb 10, 2020 07:41PM

Thanks for your patience. Our product team confirmed that the issue has been fixed. Can you please check from your end of everything is okay?

ap...@google.com <ap...@google.com> #25Feb 13, 2020 02:37PM

Can you confirm which version this is fixed in?

ap...@google.com <ap...@google.com> #26Feb 20, 2020 11:44PM

It should work fine with python 3.10.

ap...@google.com <ap...@google.com> #27Mar 5, 2020 07:28PM

It doesn't. As mentioned previously gcloud SDK 367.0 still fails when running gcloud without parameters. It also fails if running gcloud with *incorrect* parameter set. For example:

>gcloud set project my-project
ERROR: gcloud failed to load (gcloud.interactive): Problem loading gcloud.interactive: cannot import name 'Mapping' from 'collections'

ap...@google.com <ap...@google.com> #28May 1, 2020 06:22PM

This is still occurring with Fedora 35 after updating to 368.0.0

ap...@google.com <ap...@google.com> #29May 26, 2020 07:10PM

After updating my SDK to the latest version, the issue got resolved. Can you please try reinstalling the SDK if it doesn't solve the issue?

This issue tracker is a channel for reporting issues and requesting new features.

The issue you described looks like a technical issue and for troubleshooting, it would be best for you to contact the GCP support or to use the Community support.

ap...@google.com <ap...@google.com> #30Jun 15, 2020 07:40PM

Please check what your colleague wrote in

comment #15

and

comment #22

. The issue got fixed only partially, you can check for reproducible steps when it still doesn't work in

comment #14

.

Also, I don't understand what do you mean by first writing:
"This issue tracker is a channel for reporting issues..."
and then
"The issue you described looks like a technical issue..."

So technical issues are not issues?

ap...@google.com <ap...@google.com> #31Jul 6, 2020 04:39PM

This issue is still not resolved in version 371.0.0. As others have noted, the issue only occurs for certain commands/command groups. We are particularly impacted by the gcloud app command group being broken due to this issue (already noted above in comment #21), as it has made us unable to deploy some applications via our CI/CD pipelines.

It is surprising and frustrating that this issue has not been treated with more urgency. Having a command group break may not seem significant given the full breadth of services gcloud spans, but for some, a single broken command group means gcloud is effectively completely broken, because the vast majority of their usage is within that command group. Additionally, there are now three open issues for this bug (b/205238176 and b/216667499 being the others).

Version information and some failed commands are included below. Note that there are two different error messages, but both are caused by the same underlying issue.

> python -V
Python 3.10.2

> gcloud --version
Google Cloud SDK 371.0.0
alpha 2022.01.28
beta 2022.01.28
bq 2.0.73
cloud_sql_proxy 1.27.0
core 2022.01.28
gsutil 5.6

> gcloud
ERROR: (gcloud) Command name argument expected.
ERROR: gcloud failed to load (gcloud.interactive): Problem loading gcloud.interactive: cannot import name 'Mapping' from 'collections' (/Users/.../.pyenv/versions/3.10.2/lib/python3.10/collections/__init__.py).
[...]

> gcloud app
ERROR: (gcloud.app) Command name argument expected.
ERROR: gcloud crashed (CommandLoadFailure): Problem loading gcloud.app.deploy: module 'collections' has no attribute 'Mapping'.
[...]

ap...@google.com <ap...@google.com> #32Aug 20, 2020 10:31PM

As of 371.0.0, there are 8 unresolved issues that require patching. Patch file attached; online link below:

https://github.com/sudoforge/pkgbuilds/blob/master/google-cloud-sdk/0004-collections-abc.patch

ap...@google.com <ap...@google.com> #33Aug 24, 2020 04:17PM

Somewhat hilariously, 370.0.0 actually introduced the removal of a workaround to support the collections -> collections.abc change for newer versions of Python.

➜ diff {369,370}/platform/bq/bigquery_client.py | head -10
--- 369/platform/bq/bigquery_client.py    1980-01-01 01:00:00.000000000 -0700
+++ 370/platform/bq/bigquery_client.py    1980-01-01 01:00:00.000000000 -0700
@@ -58,9 +58,6 @@

 _GCS_SCHEME_PREFIX = 'gs://'

-collections_abc = collections
-if sys.version_info > (3, 8):
-  collections_abc = collections.abc

ap...@google.com <ap...@google.com> #34Aug 24, 2020 06:59PM

As of 372.0.0, there are unresolved issues in 8 different files that require patching. Patch file attached; online link below:

https://github.com/sudoforge/pkgbuilds/blob/master/google-cloud-sdk/0004-collections-abc.patch

ap...@google.com <ap...@google.com> #35Aug 31, 2020 04:38PM

Hello,

Thanks for your patience. Can you please provide us with some error trace logs?

ap...@google.com <ap...@google.com> #36Sep 2, 2020 03:26PM

With each new release lacking a fix, I publish a patch file containing fixes for the errors that I'm able to find. I do not utilize each and every command, so I am not currently able to provide a stack trace containing usage of each of the methods that my patch fixes.

If you are for some reason unable to view the patch and correlate the patches to broken areas of the codebase, I'd be happy to write a script to invoke a matrice of each gcloud subcommand with all of its flag variations. Requesting this seems... silly.

ap...@google.com <ap...@google.com> #37Oct 21, 2020 05:53PM

It's painfully obvious that you don't have adequate testing in place and that this would be a low priority subject (full 2 months to get solution from you). It would seem that this is a pet project of someone at the office.

In case I'm just "holding it wrong": do you have an "Enterprise Level" piece of software to handle the functions that your web interface doesn't do? (assuming your web interface is such "Enterprise Level piece of software" for the functions that it covers). Do you promote any 3rd party tool?

za...@gmail.com <za...@gmail.com> Oct 21, 2020 06:33PM

Accepted by za...@gmail.com.

ap...@google.com <ap...@google.com> #38Jul 20, 2023 06:28PM

Just checked with gcloud SDK 373.0.0. Looks like at least "gcloud" without parameters and "gcloud app" is now fixed. Haven't tried all other commands though.

as...@google.com <as...@google.com> #39Apr 30, 2024 08:26PM

You can look at the patch file I provide with each update to determine whether or not the issue is fixed.

Issue 138602561

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Sep 6, 2019 03:35PM

ap...@google.com <ap...@google.com> #3Sep 19, 2019 04:39PM

ap...@google.com <ap...@google.com> #4Sep 27, 2019 09:51PM

ap...@google.com <ap...@google.com> #5Sep 27, 2019 11:23PM

ap...@google.com <ap...@google.com> #6Sep 30, 2019 12:25AM

ap...@google.com <ap...@google.com> #7Sep 30, 2019 09:10PM

ap...@google.com <ap...@google.com> #8Oct 1, 2019 08:06PM

ap...@google.com <ap...@google.com> #9Oct 2, 2019 04:34PM

au...@google.com <au...@google.com> Oct 2, 2019 07:33PM

ap...@google.com <ap...@google.com> #10Oct 8, 2019 01:00AM

ap...@google.com <ap...@google.com> #11Oct 8, 2019 06:44PM

ap...@google.com <ap...@google.com> #12Oct 17, 2019 09:41PM

ap...@google.com <ap...@google.com> #13Oct 23, 2019 05:55PM

ap...@google.com <ap...@google.com> #14Oct 25, 2019 08:44PM

ap...@google.com <ap...@google.com> #15Oct 28, 2019 10:35PM

ap...@google.com <ap...@google.com> #16Nov 14, 2019 05:09AM

ap...@google.com <ap...@google.com> #17Nov 22, 2019 07:33PM

ap...@google.com <ap...@google.com> #18Nov 25, 2019 08:42PM

ap...@google.com <ap...@google.com> #19Dec 11, 2019 08:37PM

ap...@google.com <ap...@google.com> #20Dec 17, 2019 09:12PM

ap...@google.com <ap...@google.com> #21Jan 13, 2020 09:36PM

ap...@google.com <ap...@google.com> #22Jan 16, 2020 04:39PM

ap...@google.com <ap...@google.com> #23Feb 10, 2020 07:24PM

ap...@google.com <ap...@google.com> #24Feb 10, 2020 07:41PM

ap...@google.com <ap...@google.com> #25Feb 13, 2020 02:37PM

ap...@google.com <ap...@google.com> #26Feb 20, 2020 11:44PM

ap...@google.com <ap...@google.com> #27Mar 5, 2020 07:28PM

ap...@google.com <ap...@google.com> #28May 1, 2020 06:22PM

ap...@google.com <ap...@google.com> #29May 26, 2020 07:10PM

ap...@google.com <ap...@google.com> #30Jun 15, 2020 07:40PM

ap...@google.com <ap...@google.com> #31Jul 6, 2020 04:39PM

ap...@google.com <ap...@google.com> #32Aug 20, 2020 10:31PM

ap...@google.com <ap...@google.com> #33Aug 24, 2020 04:17PM

ap...@google.com <ap...@google.com> #34Aug 24, 2020 06:59PM

ap...@google.com <ap...@google.com> #35Aug 31, 2020 04:38PM

ap...@google.com <ap...@google.com> #36Sep 2, 2020 03:26PM

ap...@google.com <ap...@google.com> #37Oct 21, 2020 05:53PM

za...@gmail.com <za...@gmail.com> Oct 21, 2020 06:33PM

ap...@google.com <ap...@google.com> #38Jul 20, 2023 06:28PM

as...@google.com <as...@google.com> #39Apr 30, 2024 08:26PM

Add comment

Issue metadata