Status Update
Comments
ap...@google.com <ap...@google.com> #2
This is a particularly hard device to come by - do you happen to have access to the device? If so could you provide us with the output of: adb shell dumpsys media.camera > info.txt
Thanks!
ap...@google.com <ap...@google.com> #3
Stacktrace:
Caused by: java.lang.IllegalArgumentException: Can not get supported output size under supported maximum for the format: 34
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes(SupportedSurfaceCombination.java:355)
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions(SupportedSurfaceCombination.java:197)
at androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions(Camera2DeviceSurfaceManager.java:198)
at androidx.camera.core.CameraX.calculateSuggestedResolutions(CameraX.java:943)
at androidx.camera.core.CameraX.bindToLifecycle(CameraX.java:293)
at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:227)
Below are some findings based on our debugging
When Dex is connected
previewConfig.getMaxResolution() is returning "731x411" as maxSize.
Inside Preview.Builder.build() -> Default_MAX_resolution is set to "CameraX.getSurfaceManager().getPreviewSize()" which is 731x411
this is being picked as maxSize.
While rendering maxSize is 731x411 and minSize is 640x480 and below are available outputSizes
0 = {Size@11860} "4032x3024"
1 = {Size@11861} "3984x2988"
2 = {Size@11862} "4032x2268"
3 = {Size@11863} "3024x3024"
4 = {Size@11864} "2976x2976"
5 = {Size@11865} "3840x2160"
6 = {Size@11866} "3264x2448"
7 = {Size@11867} "4032x1960"
8 = {Size@11868} "2880x2160"
9 = {Size@11869} "3264x1836"
10 = {Size@11870} "2160x2160"
11 = {Size@11871} "2560x1440"
12 = {Size@11872} "2224x1080"
13 = {Size@11873} "2048x1152"
14 = {Size@11874} "1920x1080"
15 = {Size@11875} "1440x1080"
16 = {Size@11876} "1088x1088"
17 = {Size@11877} "1280x720"
18 = {Size@11878} "1024x768"
19 = {Size@11879} "1056x704"
20 = {Size@11880} "960x720"
21 = {Size@11881} "960x540"
22 = {Size@11882} "720x720"
23 = {Size@11883} "800x450"
24 = {Size@11884} "720x480"
25 = {Size@11885} "640x480"
26 = {Size@11886} "352x288"
27 = {Size@11887} "320x240"
28 = {Size@11888} "256x144"
29 = {Size@11889} "176x144"
and couldn't find any size in this range.
When Dex not connected
minsize = 640x480
maxsize = 1920x1080
0 = {Size@11836} "4032x3024"
1 = {Size@11837} "3984x2988"
2 = {Size@11838} "4032x2268"
3 = {Size@11839} "3024x3024"
4 = {Size@11840} "2976x2976"
5 = {Size@11841} "3840x2160"
6 = {Size@11842} "3264x2448"
7 = {Size@11843} "4032x1960"
8 = {Size@11844} "2880x2160"
9 = {Size@11845} "3264x1836"
10 = {Size@11846} "2160x2160"
11 = {Size@11847} "2560x1440"
12 = {Size@11848} "2224x1080"
13 = {Size@11849} "2048x1152"
14 = {Size@11850} "1920x1080"
15 = {Size@11851} "1440x1080"
16 = {Size@11852} "1088x1088"
17 = {Size@11853} "1280x720"
18 = {Size@11854} "1024x768"
19 = {Size@11855} "1056x704"
20 = {Size@11856} "960x720"
21 = {Size@11857} "960x540"
22 = {Size@11858} "720x720"
23 = {Size@11859} "800x450"
24 = {Size@11860} "720x480"
25 = {Size@11861} "640x480"
26 = {Size@11862} "352x288"
27 = {Size@11863} "320x240"
28 = {Size@11864} "256x144"
29 = {Size@11865} "176x144"
and we have 12 available sizes in this range
Camera2DeviceSurfaceManager.java:: getPreviewSize()
mCameraSupportedSurfaceCombinationMap.get(cameraId).getSurfaceDefinition().getPreviewSize() = "1920x1080"
cameraId=0
ap...@google.com <ap...@google.com> #4
The issue root cause is that CameraX will default filter out sizes smaller than 640x480. For Preview, the max size will be limited to under display size. I checked the HW spec info for the issue related devices. Display size of FUJITSU F-04J/F-05J is 360x640. That will result int that no size exists in the conditions that is larger or equal to 640x480 and smaller or equal to 360x640.
A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
For device FUJITSU arrowsM04, I checked its HW spec info and its display size I found is 1280x720. It seems that the problem should not exist in the device.
Could you confirm that the problem exist on arrowsM04 device? What will be the returned value when using Display#getRealSize to obtain the display size?
ap...@google.com <ap...@google.com> #5
> A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
OK. I will try it.
> Could you confirm that the problem exist on arrowsM04 device?
We receive the crash report (Crashlytics) that this crash has occurred on arrowsM04.
We don't have this device so we can't confirm that the problem really exist on arrowsM04.
> What will be the returned value when using Display#getRealSize to obtain the display size?
We can't investigate it for the same reason.
Thank you.
ap...@google.com <ap...@google.com> #6
This issue happened on devices that the display size is smaller than 640x480. In original auto-resolution mechanism, supported sizes smaller than 640x480 will be default filter out.
The auto-resolution mechanism encodes the guaranteed configurations tables in CameraDevice#createCaptureSession(SessionConfiguration). It defines that the PREVIEW size is the small one of the device display size and 1080p. The PREVIEW size will be the maximal size limitation for Preview use case. The reason it limits the size to display size and 1080p is the stream output in display size or 1080p has been able to provide good enough preview quality. Therefore, auto-resolution mechanism will limit the selected size to be smaller than the small one of the device display size and 1080p.
With above two conditions, in this issue, all sizes smaller than 640x480 have been filter out, therefore, there is no size smaller than the display size 320x240 can be selected to use. And cause the exception.
Solution:
When the display size is smaller than 640x480, auto-resolution mechanism won't filter out those small sizes smaller than 640x480. This makes those small size be left and can be selected for the Preview use case on small display devices.
The solution has been merged and will be included in next CameraX release.
ap...@google.com <ap...@google.com> #7
Hello.
This crash still occurs.
- CAMERAX VERSION: 1.0.0-beta4
- ANDROID OS BUILD NUMBER: Android 7.1.1
- DEVICE NAME: FUJITSU F-02H
We receive following crash report from FUJITSU F-02H. So far We have received this crash report only from F-02H.
java.lang.IllegalArgumentException
Can not get supported output size under supported maximum for the format: 34
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes (SupportedSurfaceCombination.java:349)
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions (SupportedSurfaceCombination.java:197)
androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions (Camera2DeviceSurfaceManager.java:198)
androidx.camera.core.CameraX.calculateSuggestedResolutions (CameraX.java:949)
androidx.camera.core.CameraX.bindToLifecycle (CameraX.java:351)
androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle (ProcessCameraProvider.java:230)
(our application's package name).CameraFragment.bindCameraUseCases (CameraFragment.java:174)
ap...@google.com <ap...@google.com> #8
Could you help to provide the following information to clarify the issue?
1. Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
2. Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
ap...@google.com <ap...@google.com> #9
- Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
Yes
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
Since we don't have this device, we'll try to collect this information in the next version of our app. The next version will be released later this month.
au...@google.com <au...@google.com>
ap...@google.com <ap...@google.com> #10
Hello.
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
We have collected the output of the device where the crash occurs.
Device1
- Model : arrows Be F-05J
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Device2
- Model : Fujitsu arrows M04
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Additional Information
CameraX version : 1.0.0-beta04
We collect the supported output sizes by following code.
val errorString = buildString {
append("The supported output sizes of ImageFormat.PRIVATE: ")
(requireContext().getSystemService(Context.CAMERA_SERVICE) as CameraManager).apply {
cameraIdList.forEachIndexed { index, cameraId ->
val msg = if (VERSION.SDK_INT >= VERSION_CODES.M) {
val configurationMap =
getCameraCharacteristics(cameraId).get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val sizes = configurationMap?.getOutputSizes(ImageFormat.PRIVATE)
"CameraId $index: ${sizes?.joinToString(" ,")}"
} else {
"CameraId $index: This device version is under M."
}
append(msg)
}
}
}
ap...@google.com <ap...@google.com> #11
ap...@google.com <ap...@google.com> #12
I tried to find the device specs and both 720x1280
size display. For the camera id 0 device, it is a different case that the display size is larger than 640x480
but the device only supports a 480x480
size. The case also caused the same IllegalArgumentException and was also fixed by 1.0.0-beta04
release. Before 480x480
size would be filtered out and then caused the IllegalArgumentException. After it was merged, the 640x480
size threshold was removed and then the 480x480
size would be kept and selected to use.
It looks like 1.0.0-beta04
release had been used to collect the supported sizes information. But the issue should have been fixed by 1.0.0-beta04
release. Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
CameraX's 1.0.0-beta04
version. Maybe you can also consider to upgrade to the latest 1.0.0-rc01
version for your application. Thanks.
ap...@google.com <ap...@google.com> #13
Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
We collect informations only from the device on which IllegalArgumentException happened.
Our latest app uses CameraX version 1.0.0-beta10
and this issue still occurres.
However we don't receive crash report from Fujitsu arrows Be F-05J
or Fujitsu arrows M04
so far. (This doesn't mean this issue is fixed on these devices because our app is heavily rely on camera so these device's user wouldn't use our app anymore.)
Instead, we receive crash report from
- Model : Fujitsu F-03K
- Android Version : 7.1.2
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0 : 480x480
CameraId 1 : 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
ap...@google.com <ap...@google.com> #14
I missed some settings when I simulated the issue by robolectric test so that I was not able to reproduce it. Now, I can reproduce the issue if the device only supports one 480x480 resolution. I'm working on the solution and target to make it included in next release.
ap...@google.com <ap...@google.com> #15
Branch: androidx-main
commit 69d15dff7bb857ee33a0f643ff42a0f8bc475ab2
Author: charcoalchen <charcoalchen@google.com>
Date: Fri Jan 08 18:30:03 2021
Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Do not filter out sizes smaller than 640x480 when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Relnote:"Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480."
Bug: 150506192
Test: SupportedSurfaceCombinationTest
Change-Id: I2a63ce8e2ad42a9cc060c8635ac3603bf440b1ec
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
ap...@google.com <ap...@google.com> #16
ap...@google.com <ap...@google.com> #17
Branch: androidx-master-dev
commit 142d7af5f87c237b90314af7460b7d90637cacbc
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Oct 09 14:11:18 2019
API lint check for the StreamFiles is enabled for androidx
Existing issues are suppressed with updated baseline and the
StreamFiles is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I77227d3c53d9e31bcebc328a17da97e2d5de4c44
M browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M core/core-ktx/api/api_lint.ignore
M core/core/api/api_lint.ignore
M documentfile/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M security/crypto/api/api_lint.ignore
M webkit/api/api_lint.ignore
ap...@google.com <ap...@google.com> #18
Branch: androidx-master-dev
commit aaeaf1ca6fd733b70d51bf9afe64544c18392900
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Fri Nov 22 23:06:16 2019
API lint check for the ParcelableList is disabled for androidx
ParcelableList is moved to the
"// The list of checks that are hidden as they are not useful in androidx"
section in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: If0f30e1460230006c1c2ef9ef1e7b51be845ddf8
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
ap...@google.com <ap...@google.com> #19
Branch: androidx-master-dev
commit 2f36c768c627b1cce422c265808c0e20a0f4deba
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Dec 11 09:13:25 2019
API lint check for the UserHandleName is commented
The UserHandleName is placed under
"// We should only treat these as warnings"
comment in the --hide section of the API_LINT_ARGS
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I8ff0e1754fcac55bece7ea6da01bc898a9b01516
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
ap...@google.com <ap...@google.com> #20
Branch: androidx-master-dev
commit fff393746a891b52038b9fb5debe8e3ce35cc236
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Dec 17 22:00:39 2019
API lint check for the TopLevelBuilder is enabled for androidx
Existing issues are suppressed with updated baseline and the
TopLevelBuilder is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I7b99f947943afd9ad9a35234599a12707a2ed675
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
M navigation/navigation-runtime/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M paging/rxjava2/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore
M ui/ui-framework/api/api_lint.ignore
M work/workmanager-testing/api/api_lint.ignore
ap...@google.com <ap...@google.com> #21
Branch: androidx-master-dev
commit df260bdcbf037df940753dfce5b4a61b3422a0a1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sat Jan 11 22:33:16 2020
API lint check for the CommonArgsFirst is enabled for androidx
CommonArgsFirst is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ia45774f5655b02eb8286b2bade8718c992a12137
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
ap...@google.com <ap...@google.com> #22
Branch: androidx-master-dev
commit 7921fbf64d00b2a7968f94d3b56dc1759158249a
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sat Jan 11 17:54:21 2020
API lint check for the NoByteOrShort is enabled for androidx
Existing issues are suppressed with updated baseline and the
NoByteOrShort is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I1540206cc7e705c6fe2beb76cfc3c5d7472bb24e
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M core/core-ktx/api/api_lint.ignore
M exifinterface/exifinterface/api/api_lint.ignore
A ui/ui-util/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
ap...@google.com <ap...@google.com> #23
Branch: master
commit d32d4d72493eec7e6130cd478384c1dc3426ab37
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sat Feb 08 21:59:21 2020
False positive warnings for MissingJvmStatic are fixed.
'@JvmOverloads' annotation cannot be used on interface methods
Bug: 138602561
Test: ./gradlew test
Change-Id: I8ec9f0f0a1e77f8a6b4786573eba5ed67ad78f1e
M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt
ap...@google.com <ap...@google.com> #24
Branch: master
commit 5fc4d6bbfb95eb3a52100f9c052cffd6c74f0cec
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sat Feb 08 13:37:08 2020
False positive warnings for MissingJvmStatic are fixed.
Companion object constants with const modifier should not use @JvmField annotation
Bug: 138602561
Test: ./gradlew test
Change-Id: I8535fb72416c0d2a92ca179fa27cebb32192bdb8
M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/main/java/com/android/tools/metalava/model/DefaultModifierList.kt
M src/main/java/com/android/tools/metalava/model/ModifierList.kt
M src/main/java/com/android/tools/metalava/model/psi/PsiModifierItem.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt
ap...@google.com <ap...@google.com> #25
Branch: master
commit d97c1b33c7cdeb764e9e39047bf058122a42208f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Feb 10 21:16:39 2020
Fields that should be flagged with MissingJvmStatic are now flagged.
Public, non-const properties which are effective constants in a companion
object that are missing @JvmField annotation are now flagged with
MissingJvmStatic warning.
Bug: 138602561
Test: ./gradlew test
Change-Id: I02a8c8ee81e2db619413fdca4a588d1d9bb140f3
M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt
ap...@google.com <ap...@google.com> #26
Branch: androidx-master-dev
commit ba95f70d6f212b92b488b172a67659d9b8562307
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 17:07:18 2019
API lint check for the BuilderSetStyle is enabled for androidx
Existing issues are suppressed with updated baseline and the
BuilderSetStyle is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I88a5da3881049d3048efbd9e45f6b04cfe7589a1
A animation/animation/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M recyclerview/recyclerview-selection/api/api_lint.ignore
ap...@google.com <ap...@google.com> #27
Branch: master
commit e83d72690645dacc5af1183908a6035b4fa4e8da
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Mar 02 01:27:53 2020
Fixed flagging of public, non-const properties in a companion object with MissingJvmStatic
Non-public properties in a companion object should not be flagged with MissingJvmStatic.
Fixed writing ID for MissingJvmstatic in api_lint.ignore file.
Bug: 138602561
Test: ./gradlew test
Change-Id: I58db4ad1108a79f0a796e4d5dd43236246b52785
M src/main/java/com/android/tools/metalava/Baseline.kt
M src/main/java/com/android/tools/metalava/KotlinInteropChecks.kt
M src/test/java/com/android/tools/metalava/KotlinInteropChecksTest.kt
ap...@google.com <ap...@google.com> #28
Branch: androidx-master-dev
commit 72e4fe48dda674f42f4f8ed5a265edddd4abf177
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Apr 29 23:57:31 2020
API lint check for the UseIcu is enabled for androidx
Existing issues are suppressed with updated baseline and the
UseIcu is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Icbdaccad1078623e9e968651aff9c0f04d166905
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
ap...@google.com <ap...@google.com> #29
Branch: androidx-master-dev
commit 72583b1a33918bcd4064704eeeb84a13e44ad45d
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Thu Mar 19 18:00:55 2020
API lint check for the MissingJvmstatic is enabled for androidx
The check is enabled only for projects intended to be accessed from
Java-language source code.
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I8ff95224f8246426f88a2c49c563e268080905d5
M buildSrc/src/main/kotlin/androidx/build/AndroidXExtension.kt
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M datastore/datastore-preferences/api/1.0.0-alpha01.txt
M datastore/datastore-preferences/api/current.txt
M datastore/datastore-preferences/api/public_plus_experimental_1.0.0-alpha01.txt
M datastore/datastore-preferences/api/public_plus_experimental_current.txt
M datastore/datastore-preferences/api/restricted_1.0.0-alpha01.txt
M datastore/datastore-preferences/api/restricted_current.txt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/Preferences.kt
M paging/common/api/api_lint.ignore
ap...@google.com <ap...@google.com> #30
Branch: androidx-master-dev
commit 5bb26c0c742912c5fe99ffd46e3558c556f2de0a
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Dec 03 17:54:01 2019
API lint check for the NotCloseable is enabled for androidx
Existing issues are suppressed with updated baseline and the
NotCloseable is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I6e40ebb4a9531766dbb4c064ba6e10feab26d635
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/compose-runtime/api/api_lint.ignore
M concurrent/futures/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore
M ui/ui-graphics/api/api_lint.ignore
A ui/ui-material/api/api_lint.ignore
M vectordrawable/vectordrawable-animated/api/api_lint.ignore
ap...@google.com <ap...@google.com> #31
Branch: androidx-master-dev
commit 017c121d8aede0439072de34890e61fbab5c3c59
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Jul 05 00:51:15 2020
API lint check for the MissingJvmstatic is enabled for androidx
The check is enabled only for projects intended to be accessed from
Java-language source code.
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ic4468e8bedf6c1479b54983a2dfecd57cdd06e2c
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
ap...@google.com <ap...@google.com> #32
Branch: androidx-master-dev
commit 4a6bc898df028ed81a424f0a970d4ca5c40bf589
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Feb 19 03:55:58 2020
API lint check for the ExecutorRegistration is enabled for androidx
Existing issues are suppressed with updated baseline and the
ExecutorRegistration is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I46c81f7f8a4906149ac241a7d7d8ef5eedcd1724
M activity/activity/api/api_lint.ignore
M appcompat/appcompat/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/interop/Camera2Interop.java
M compose/runtime/runtime/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M contentpager/contentpager/api/api_lint.ignore
M core/core/api/api_lint.ignore
M emoji/core/api/api_lint.ignore
A enterprise/feedback/api/api_lint.ignore
A enterprise/feedback/testing/api/api_lint.ignore
M leanback/leanback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M mediarouter/mediarouter/api/api_lint.ignore
M navigation/navigation-runtime/api/api_lint.ignore
M navigation/navigation-ui/api/api_lint.ignore
M paging/common/api/api_lint.ignore
A paging/runtime/api/api_lint.ignore
M preference/preference/api/api_lint.ignore
A print/print/api/api_lint.ignore
M recyclerview/recyclerview-selection/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M security/crypto/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M slices/view/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
A window/window-extensions/api/api_lint.ignore
M window/window-sidecar/api/api_lint.ignore
ap...@google.com <ap...@google.com> #33
Branch: androidx-master-dev
commit aefc62cba13de9888609b7372ddaf808c263a80b
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Aug 24 09:02:19 2020
Add missing API baselines for aosp/1242687
Relnote: n/a
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I9869a6f29a9844392ecd537a029c708fde09707e
M room/runtime/api/api_lint.ignore
ap...@google.com <ap...@google.com> #34
Branch: androidx-master-dev
commit 5e7fc48929b3fd30a0717ae423b7814c42a4c941
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun May 17 18:28:55 2020
API lint check for the CallbackMethodName is enabled for androidx
Existing issues are suppressed with updated baseline and the
CallbackMethodName is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Id5b690751b23319580b109d5cb1039d3ed592617
M activity/activity/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/ui/ui/api/api_lint.ignore
M contentpager/contentpager/api/api_lint.ignore
M customview/customview/api/api_lint.ignore
M leanback/leanback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M preference/preference/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M remotecallback/remotecallback/api/api_lint.ignore
M swiperefreshlayout/swiperefreshlayout/api/api_lint.ignore
M wear/wear/api/api_lint.ignore
ap...@google.com <ap...@google.com> #35
Branch: androidx-master-dev
commit fdb836b6143bae101047a1a0241f69a1cb82294e
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon May 18 02:36:46 2020
API lint check for the GetterOnBuilder is enabled for androidx
Existing issues are suppressed with updated baseline and the
GetterOnBuilder is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I4b717667f833b8240b1f4432344026f44dd0d93e
M appcompat/appcompat/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/ui/ui-graphics/api/api_lint.ignore
M compose/ui/ui-text/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
ap...@google.com <ap...@google.com> #36
Branch: androidx-master-dev
commit 012a88b4545d870c4df83783cbb922f2967ec9f5
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed May 20 00:06:53 2020
API lint check for the StaticFinalBuilder is enabled for androidx
Existing issues are suppressed with updated baseline and the
StaticFinalBuilder is turned into an error in androidx configuration
Relnote: API lint check for the StaticFinalBuilder is enabled for androidx
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I2b11be1bb370e178e3e0d1d1083d43af38eece23
M appcompat/appcompat/api/api_lint.ignore
A appsearch/appsearch/api/api_lint.ignore
A biometric/biometric/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-core/api/api_lint.ignore
M camera/camera-core/api/public_plus_experimental_1.0.0-beta07.txt
M camera/camera-core/api/public_plus_experimental_1.0.0-beta09.txt
M camera/camera-core/api/public_plus_experimental_current.txt
M camera/camera-core/src/main/java/androidx/camera/core/UseCaseGroup.java
M camera/camera-core/src/main/java/androidx/camera/core/ViewPort.java
M core/core-animation/api/api_lint.ignore
M core/core/api/api_lint.ignore
M enterprise/feedback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M tv-provider/tv-provider/api/api_lint.ignore
M webkit/webkit/api/api_lint.ignore
M work/workmanager-testing/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
ap...@google.com <ap...@google.com> #37
Branch: androidx-master-dev
commit 757ff428f74b1d85f4a932e55fc7d79aabf555b9
Author: Alexander Dorokhine <adorokhine@google.com>
Date: Tue Oct 20 22:30:12 2020
Enable API lint check for MissingGetterMatchingBuilder in androidx.
Existing issues are suppressed with updated baseline and
MissingGetterMatchingBuilder is turned into an error in androidx
configuration
This linter is enabled in framework, and its lack in androidx made it
more difficult to share code.
Relnote: API lint check for MissingGetterMatchingBuilder is enabled for androidx
Bug: 138602561
Bug: 171261337
Test: ./gradlew checkApi
Change-Id: I4bbeacf9869d8338a3d7086acb40bc56ec68c3f9
M activity/activity/api/api_lint.ignore
M appsearch/appsearch/api/api_lint.ignore
M autofill/autofill/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M camera/camera-core/api/api_lint.ignore
M compose/ui/ui/api/api_lint.ignore
M core/core/api/api_lint.ignore
M heifwriter/heifwriter/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/session/api/api_lint.ignore
M mediarouter/mediarouter/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
M navigation/navigation-common/api/api_lint.ignore
A navigation/navigation-fragment/api/api_lint.ignore
M navigation/navigation-runtime/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M recommendation/recommendation/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M security/crypto/api/api_lint.ignore
A security/identity-credential/api/api_lint.ignore
M textclassifier/textclassifier/api/api_lint.ignore
M tv-provider/tv-provider/api/api_lint.ignore
A wear/wear-complications-data/api/api_lint.ignore
A wear/wear-watchface/api/api_lint.ignore
M webkit/webkit/api/api_lint.ignore
M work/workmanager-testing/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
za...@gmail.com <za...@gmail.com>
ap...@google.com <ap...@google.com> #38
Branch: androidx-master-dev
commit 5e7fc48929b3fd30a0717ae423b7814c42a4c941
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun May 17 18:28:55 2020
API lint check for the CallbackMethodName is enabled for androidx
Existing issues are suppressed with updated baseline and the
CallbackMethodName is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Id5b690751b23319580b109d5cb1039d3ed592617
M activity/activity/api/api_lint.ignore
M browser/browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M compose/ui/ui/api/api_lint.ignore
M contentpager/contentpager/api/api_lint.ignore
M customview/customview/api/api_lint.ignore
M leanback/leanback/api/api_lint.ignore
M media/media/api/api_lint.ignore
M media2/common/api/api_lint.ignore
M preference/preference/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M remotecallback/remotecallback/api/api_lint.ignore
M swiperefreshlayout/swiperefreshlayout/api/api_lint.ignore
M wear/wear/api/api_lint.ignore
as...@google.com <as...@google.com> #39
Looks like 2 have bugs and only SamShouldBeLast
needs to be enabled?
// List of checks that have bugs, but should be enabled once fixed.
"StaticUtils", // b/135489083
"StartWithLower", // b/135710527
// The list of checks that are API lint warnings and are yet to be enabled
"SamShouldBeLast",
Description
Estimated workload: ~1 day per check
Technologies: Gradle, Metalava, API signature files
We have a number of API lint checks that are yet to be enabled. Some checks should be as simple as turning it on and whitelisting existing issues. Some checks will require improving the checks so it has less false positive results.