Fixed
Status Update
No update yet.
Comments
ap...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
jb...@google.com
ap...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit a7b3de1d4990e5f306048aa70e6af0240717c671
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Aug 15 15:24:03 2019
Use ExitAnimationCompleteMarker with Animations and Animators
Animations, Animators, and Transitions are currently all handled
separately by the FragmentManager. Looking toward the future it would be
nice if these and any other animation systems could be handled in the
same (or at least a similar) way by the FragmentManager.
This change uses the ExitAnimationCompleteMarker interface to allow
proper behavior when Animations and Animators are ended or canceled. A
cancel method was added to allow animation components to define how they
should be handled when the FragmentManager needs to cancel an animation
early. When animations are ended, the animation component removes the
ExitAnimationCompleteMarker and that notifies the FragmentManager that
the animation has ended, the view can be destroyed, and the fragment can
be moved to the proper state.
Test: all tests pass
BUG: 138741697
Change-Id: I315b814132a57ab89c0ccd127161b28e60628996
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransition.java
https://android-review.googlesource.com/1103911
https://goto.google.com/android-sha1/a7b3de1d4990e5f306048aa70e6af0240717c671
Branch: androidx-master-dev
commit a7b3de1d4990e5f306048aa70e6af0240717c671
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Aug 15 15:24:03 2019
Use ExitAnimationCompleteMarker with Animations and Animators
Animations, Animators, and Transitions are currently all handled
separately by the FragmentManager. Looking toward the future it would be
nice if these and any other animation systems could be handled in the
same (or at least a similar) way by the FragmentManager.
This change uses the ExitAnimationCompleteMarker interface to allow
proper behavior when Animations and Animators are ended or canceled. A
cancel method was added to allow animation components to define how they
should be handled when the FragmentManager needs to cancel an animation
early. When animations are ended, the animation component removes the
ExitAnimationCompleteMarker and that notifies the FragmentManager that
the animation has ended, the view can be destroyed, and the fragment can
be moved to the proper state.
Test: all tests pass
BUG: 138741697
Change-Id: I315b814132a57ab89c0ccd127161b28e60628996
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransition.java
jb...@google.com
This issue has been fixed internally and will be available in the Fragment 1.2.0-alpha03 release.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit a9bbe1a2a1bf4b6285377352808748888786062a
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 03 15:09:20 2019
Add test to ensure child fragments call onDestroyView on config change
If a child fragment has animation and the parent does not, the view for
a child fragment should still be destroyed when the parent fragment's view is.
Test: Added Test
BUG: 138741697
Change-Id: I376e59515490220959aaebca5cbd78757887b2c7
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.kt
https://android-review.googlesource.com/1113331
https://goto.google.com/android-sha1/a9bbe1a2a1bf4b6285377352808748888786062a
Branch: androidx-master-dev
commit a9bbe1a2a1bf4b6285377352808748888786062a
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 03 15:09:20 2019
Add test to ensure child fragments call onDestroyView on config change
If a child fragment has animation and the parent does not, the view for
a child fragment should still be destroyed when the parent fragment's view is.
Test: Added Test
BUG: 138741697
Change-Id: I376e59515490220959aaebca5cbd78757887b2c7
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.kt
Description