Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
Two parts to this:
1) Benchmark configuration argument, to loop only once (this is pretty simple, variant of "androidx.benchmark.startupMode.enable=true")
2) Change presubmit to pass that additional instrumentation-arg, and additionally match "androidBenchmark.apk" APKs
1) Benchmark configuration argument, to loop only once (this is pretty simple, variant of "androidx.benchmark.startupMode.enable=true")
2) Change presubmit to pass that additional instrumentation-arg, and additionally match "androidBenchmark.apk" APKs
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e21e3aa1642678d22ead8a88f434ccddc1802f82
Author: Chris Craik <ccraik@google.com>
Date: Thu Aug 01 11:04:23 2019
Add a "Dry Run" benchmark mode for presubmit
Bug: 138785848
Test: ./gradlew bench:b-c:cC bench:b-j:cC bench:i-t:d-r-b:cC bench:i-t:s-b:cC
A benchmark dry run produces no output, and only runs the loop once.
This is useful for validating correctness quickly, e.g. for presubmit.
Change-Id: Ied4a601482d785383a2a68d528651f7c9d180802
M benchmark/common/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
A benchmark/integration-tests/dry-run-benchmark/.gitignore
A benchmark/integration-tests/dry-run-benchmark/README.md
A benchmark/integration-tests/dry-run-benchmark/build.gradle
A benchmark/integration-tests/dry-run-benchmark/src/androidTest/AndroidManifest.xml
A benchmark/integration-tests/dry-run-benchmark/src/androidTest/java/androidx/benchmark/integration/dryrun/benchmark/ArgumentInjectingApplication.kt
A benchmark/integration-tests/dry-run-benchmark/src/androidTest/java/androidx/benchmark/integration/dryrun/benchmark/DryRunBenchmark.kt
A benchmark/integration-tests/dry-run-benchmark/src/main/AndroidManifest.xml
M settings.gradle
https://android-review.googlesource.com/1094851
https://goto.google.com/android-sha1/e21e3aa1642678d22ead8a88f434ccddc1802f82
Branch: androidx-master-dev
commit e21e3aa1642678d22ead8a88f434ccddc1802f82
Author: Chris Craik <ccraik@google.com>
Date: Thu Aug 01 11:04:23 2019
Add a "Dry Run" benchmark mode for presubmit
Bug: 138785848
Test: ./gradlew bench:b-c:cC bench:b-j:cC bench:i-t:d-r-b:cC bench:i-t:s-b:cC
A benchmark dry run produces no output, and only runs the loop once.
This is useful for validating correctness quickly, e.g. for presubmit.
Change-Id: Ied4a601482d785383a2a68d528651f7c9d180802
M benchmark/common/src/main/java/androidx/benchmark/Arguments.kt
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
A benchmark/integration-tests/dry-run-benchmark/.gitignore
A benchmark/integration-tests/dry-run-benchmark/README.md
A benchmark/integration-tests/dry-run-benchmark/build.gradle
A benchmark/integration-tests/dry-run-benchmark/src/androidTest/AndroidManifest.xml
A benchmark/integration-tests/dry-run-benchmark/src/androidTest/java/androidx/benchmark/integration/dryrun/benchmark/ArgumentInjectingApplication.kt
A benchmark/integration-tests/dry-run-benchmark/src/androidTest/java/androidx/benchmark/integration/dryrun/benchmark/DryRunBenchmark.kt
A benchmark/integration-tests/dry-run-benchmark/src/main/AndroidManifest.xml
M settings.gradle
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 8661661d68abc3ece25e2b7a5b5edad3c3ec8e23
Author: Chris Craik <ccraik@google.com>
Date: Mon Mar 23 11:26:58 2020
Make output enable control bundle metric output
Test: ./gradlew bench:b-c:cC bench:b-j:cC
Bug: 138785848
Change-Id: I223b320653523d390a5419c982cde9b5b94522db
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
https://android-review.googlesource.com/1266937
Branch: androidx-master-dev
commit 8661661d68abc3ece25e2b7a5b5edad3c3ec8e23
Author: Chris Craik <ccraik@google.com>
Date: Mon Mar 23 11:26:58 2020
Make output enable control bundle metric output
Test: ./gradlew bench:b-c:cC bench:b-j:cC
Bug: 138785848
Change-Id: I223b320653523d390a5419c982cde9b5b94522db
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
cc...@google.com <cc...@google.com> #5
This landed a long time ago, should have been marked fixed.
Description