Selection not updated to reflect items removed from adapter. [138932671]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ss...@gmail.com

created issue #1

Aug 5, 2019 05:55PM

Artifact used: androidx.recyclerview:recyclerview-selection:1.0.0
Version used: N/A
Theme used: N/A
Devices/Android versions reproduced on: Emulator / Android 9.0 (Google APIs)

public class MyAdapter extends RecyclerView.Adapter<String> {
private List<String> mData;

public MyAdapter () {
mData = new ArrayList<>();
mData.add("Test1");
mData.add("Test2");
}

public void removeFirst() {
mData.remove(0);
notifyItemRemoved(0);
}
}

Suppose that the first item is selected. Removing it calling MyAdapter.removeFirst() will also call notifyItemRemoved() but the selection tracker observe are not issued (none of its callbacks are invoked). In fact, the selection tracker keeps the selection state saying that there is a selection.

Comments

vi...@google.com <vi...@google.com> #2Sep 27, 2019 08:12AM

Assigned to vi...@google.com.

since these are in public API (:/) we need to do this in 1.2

ss...@gmail.com <ss...@gmail.com> #3Sep 27, 2019 11:30AM

since it is already marked as deprecated, we can probably do it by now.

ss...@gmail.com <ss...@gmail.com> #4Oct 3, 2019 02:17PM

Opening diff shortly

SelectionTrackerIssue.zip

826 KB

Download

vi...@google.com <vi...@google.com> #5Oct 11, 2019 11:37AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

vi...@google.com <vi...@google.com> Jan 14, 2020 12:11PM

Reassigned to sh...@google.com.

sh...@google.com <sh...@google.com> Jan 14, 2020 05:18PM

Reassigned to sm...@google.com.

sm...@google.com <sm...@google.com> #6Jan 28, 2020 07:07PM

Thanks for reporting the issue.

Looks like an oversight where SelectionTracker's AdapterObserver is simply ignoring rangeRemoved events. I'll aim to land a fix for this in the 1.1 stable release (either the initial release, or a fast-follow-on point release).

ap...@google.com <ap...@google.com> #7Aug 12, 2020 09:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3b4d015eaebacb3ba82f67248cdc5befbffbc3d0
Author: Steve McKay <smckay@google.com>
Date: Mon Aug 10 17:34:07 2020

Fix issue where selection wasn't update when corresponding items removed from adapter.

Add ItemTouchHelper based swipe away support to Fancy demo app to help provide better test bed (for me...debugging :)
Improved organization of code in Fancy demo activity, to help keep concepts clear and separate for readers.
Update DemoAdapter to support removing items (and generally improve organization).
Move selection demos into RecyclerView/Selection/... "folder" of the samples app.

Bug: 138932671
Test: Manual test of demo app + addition of new test coverage in DefaultSelectionTracker.
Change-Id: Ic7924aca017b35aae65195f2c40e49641177471f

M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestAdapter.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestSelectionObserver.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/DefaultSelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/ItemKeyProvider.java
M samples/Support7Demos/src/main/AndroidManifest.xml
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/DemoAdapter.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/DemoDetailsLookup.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/DemoHeaderHolder.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoActivity.java
M samples/Support7Demos/src/main/res/layout/selection_demo_layout.xml
M samples/Support7Demos/src/main/res/menu/selection_demo_actions.xml
M samples/Support7Demos/src/main/res/values/strings.xml

https://android-review.googlesource.com/1396972

sm...@google.com <sm...@google.com> #8Aug 12, 2020 09:56PM

Marked as fixed.

Fix will appear in 1.1.0-rc02.

ap...@google.com <ap...@google.com> #9Aug 19, 2020 12:20AM

Project: platform/frameworks/support
Branch: snap-temp-L55000000669795486

commit 9335df63d373a327e06e21e7258660f9bcc429fb
Author: Steve McKay <smckay@google.com>
Date: Mon Aug 10 17:34:07 2020

Fix issue where selection wasn't update when corresponding items removed from adapter.

Add ItemTouchHelper based swipe away support to Fancy demo app to help provide better test bed (for me...debugging :)
Improved organization of code in Fancy demo activity, to help keep concepts clear and separate for readers.
Update FancySelectionDemoAdapter to support removing items (and generally improve organization).
Move selection demos into RecyclerView/Selection/... "folder" of the samples app.

Bug: 138932671
Test: Manual test of demo app + addition of new test coverage in DefaultSelectionTracker.
Change-Id: Ic7924aca017b35aae65195f2c40e49641177471f
(cherry picked from commit caddb9aae42e7ea049b1d3ab15f328353460a6cb)

M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestAdapter.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestSelectionObserver.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/DefaultSelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/ItemKeyProvider.java
M samples/Support7Demos/src/main/AndroidManifest.xml
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyDetailsLookup.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyHeaderHolder.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoActivity.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoAdapter.java
M samples/Support7Demos/src/main/res/menu/selection_demo_actions.xml
M samples/Support7Demos/src/main/res/values/strings.xml

https://android-review.googlesource.com/1404003

ap...@google.com <ap...@google.com> #10Aug 19, 2020 12:22AM

Project: platform/frameworks/support
Branch: snap-temp-L13100000669799324

commit 24d59b6e7a77af3ead3911e929174c086bdb1a0c
Author: Steve McKay <smckay@google.com>
Date: Mon Aug 10 17:34:07 2020

Fix issue where selection wasn't update when corresponding items removed from adapter.

Add ItemTouchHelper based swipe away support to Fancy demo app to help provide better test bed (for me...debugging :)
Improved organization of code in Fancy demo activity, to help keep concepts clear and separate for readers.
Update FancySelectionDemoAdapter to support removing items (and generally improve organization).
Move selection demos into RecyclerView/Selection/... "folder" of the samples app.

Bug: 138932671
Test: Manual test of demo app + addition of new test coverage in DefaultSelectionTracker.
Change-Id: Ic7924aca017b35aae65195f2c40e49641177471f
(cherry picked from commit caddb9aae42e7ea049b1d3ab15f328353460a6cb)

M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestAdapter.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestSelectionObserver.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/DefaultSelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/ItemKeyProvider.java
M samples/Support7Demos/src/main/AndroidManifest.xml
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyDetailsLookup.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyHeaderHolder.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoActivity.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoAdapter.java
M samples/Support7Demos/src/main/res/menu/selection_demo_actions.xml
M samples/Support7Demos/src/main/res/values/strings.xml

https://android-review.googlesource.com/1404339

ap...@google.com <ap...@google.com> #11Aug 19, 2020 01:54AM

Project: platform/frameworks/support
Branch: snap-temp-L10500000669872246

commit ea538c8ae5bf29fecbc39bb30dbfc9974d5b3bb7
Author: Steve McKay <smckay@google.com>
Date: Mon Aug 10 17:34:07 2020

Fix issue where selection wasn't update when corresponding items removed from adapter.

Add ItemTouchHelper based swipe away support to Fancy demo app to help provide better test bed (for me...debugging :)
Improved organization of code in Fancy demo activity, to help keep concepts clear and separate for readers.
Update FancySelectionDemoAdapter to support removing items (and generally improve organization).
Move selection demos into RecyclerView/Selection/... "folder" of the samples app.

Bug: 138932671
Test: Manual test of demo app + addition of new test coverage in DefaultSelectionTracker.
Change-Id: Ic7924aca017b35aae65195f2c40e49641177471f
(cherry picked from commit caddb9aae42e7ea049b1d3ab15f328353460a6cb)

M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestAdapter.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestSelectionObserver.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/DefaultSelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/ItemKeyProvider.java
M samples/Support7Demos/src/main/AndroidManifest.xml
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyDetailsLookup.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyHeaderHolder.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoActivity.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoAdapter.java
M samples/Support7Demos/src/main/res/menu/selection_demo_actions.xml
M samples/Support7Demos/src/main/res/values/strings.xml

https://android-review.googlesource.com/1404370

ap...@google.com <ap...@google.com> #12Aug 19, 2020 01:57AM

Project: platform/frameworks/support
Branch: snap-temp-L85700000669873256

commit 8b02837e39b9aecaa2a558307890de302da2fe8d
Author: Steve McKay <smckay@google.com>
Date: Mon Aug 10 17:34:07 2020

Fix issue where selection wasn't update when corresponding items removed from adapter.

Add ItemTouchHelper based swipe away support to Fancy demo app to help provide better test bed (for me...debugging :)
Improved organization of code in Fancy demo activity, to help keep concepts clear and separate for readers.
Update FancySelectionDemoAdapter to support removing items (and generally improve organization).
Move selection demos into RecyclerView/Selection/... "folder" of the samples app.

Bug: 138932671
Test: Manual test of demo app + addition of new test coverage in DefaultSelectionTracker.
Change-Id: Ic7924aca017b35aae65195f2c40e49641177471f
(cherry picked from commit caddb9aae42e7ea049b1d3ab15f328353460a6cb)

M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestAdapter.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestSelectionObserver.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/DefaultSelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/ItemKeyProvider.java
M samples/Support7Demos/src/main/AndroidManifest.xml
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyDetailsLookup.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyHeaderHolder.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoActivity.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoAdapter.java
M samples/Support7Demos/src/main/res/menu/selection_demo_actions.xml
M samples/Support7Demos/src/main/res/values/strings.xml

https://android-review.googlesource.com/1404377

ap...@google.com <ap...@google.com> #13Aug 19, 2020 02:18AM

Project: platform/frameworks/support
Branch: snap-temp-L23500000669881336

commit 34de1726004bf0b9b9aad0622f656007e650ec8d
Author: Steve McKay <smckay@google.com>
Date: Mon Aug 10 17:34:07 2020

Fix issue where selection wasn't update when corresponding items removed from adapter.

Add ItemTouchHelper based swipe away support to Fancy demo app to help provide better test bed (for me...debugging :)
Improved organization of code in Fancy demo activity, to help keep concepts clear and separate for readers.
Update FancySelectionDemoAdapter to support removing items (and generally improve organization).
Move selection demos into RecyclerView/Selection/... "folder" of the samples app.

Bug: 138932671
Test: Manual test of demo app + addition of new test coverage in DefaultSelectionTracker.
Change-Id: Ic7924aca017b35aae65195f2c40e49641177471f
(cherry picked from commit caddb9aae42e7ea049b1d3ab15f328353460a6cb)

M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/DefaultSelectionTrackerTest.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestAdapter.java
M recyclerview/recyclerview-selection/src/androidTest/java/androidx/recyclerview/selection/testing/TestSelectionObserver.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/DefaultSelectionTracker.java
M recyclerview/recyclerview-selection/src/main/java/androidx/recyclerview/selection/ItemKeyProvider.java
M samples/Support7Demos/src/main/AndroidManifest.xml
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyDetailsLookup.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancyHeaderHolder.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoActivity.java
M samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/selection/fancy/FancySelectionDemoAdapter.java
M samples/Support7Demos/src/main/res/menu/selection_demo_actions.xml
M samples/Support7Demos/src/main/res/values/strings.xml

https://android-review.googlesource.com/1404357

an...@google.com <an...@google.com> #14Aug 19, 2020 02:18AM

The following changes were cherrypicked through Coastguard
Release Track: 4819333773066240
Changes: aosp/1404331