Fixed
Status Update
Comments
ch...@google.com <ch...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 06035833f0e98b6116774b743c75c2cc7c334326
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 15:52:36 2021
Create @AppCompatShadowedAttributes
This annotation is restricted to intra-androidx library usage. When
applied to a View in AppCompat, it will direct the annotation processor
to infer shadowed attributes for the View based on what interfaces from
Core it implements, e.g.: TintableBackgroundView.
Test: N/A
Relnote: Improved AppCompat support
Bug: 188446121
Change-Id: I2d7387a017585bcea14a8d8a857b9b60930bc1c5
M resourceinspection/resourceinspection-annotation/api/restricted_current.txt
A resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
https://android-review.googlesource.com/1709335
Branch: androidx-main
commit 06035833f0e98b6116774b743c75c2cc7c334326
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 15:52:36 2021
Create @AppCompatShadowedAttributes
This annotation is restricted to intra-androidx library usage. When
applied to a View in AppCompat, it will direct the annotation processor
to infer shadowed attributes for the View based on what interfaces from
Core it implements, e.g.: TintableBackgroundView.
Test: N/A
Relnote: Improved AppCompat support
Bug: 188446121
Change-Id: I2d7387a017585bcea14a8d8a857b9b60930bc1c5
M resourceinspection/resourceinspection-annotation/api/restricted_current.txt
A resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
ni...@google.com <ni...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 42f9ba7d4ccd46960123b403df5ca28803643059
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 17:41:24 2021
Refactor resource inspection processor model
Extract an Attribute interface to generate code for either shadowed or
annotated regular attributes.
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I131f017c433ec9e44a6fb364c903467894735377
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/InspectionCompanionGeneration.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
https://android-review.googlesource.com/1709337
Branch: androidx-main
commit 42f9ba7d4ccd46960123b403df5ca28803643059
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 17:41:24 2021
Refactor resource inspection processor model
Extract an Attribute interface to generate code for either shadowed or
annotated regular attributes.
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: I131f017c433ec9e44a6fb364c903467894735377
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/InspectionCompanionGeneration.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
sj...@google.com <sj...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 49d18d3f7b42f7a5675357bd51fa4ff22ac0b5d5
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 18:51:33 2021
Shadowed attributes annotation processing
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: Icf4eb2cab92ccde42daf583566f0ce7aca6d6d34
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
M resourceinspection/resourceinspection-processor/src/test/kotlin/androidx/resourceinspection/processor/ResourceInspectionProcessorTest.kt
https://android-review.googlesource.com/1709968
Branch: androidx-main
commit 49d18d3f7b42f7a5675357bd51fa4ff22ac0b5d5
Author: Ember Rose <emberrose@google.com>
Date: Mon May 17 18:51:33 2021
Shadowed attributes annotation processing
Test: ResourceInspectionProcessorTest
Bug: 188446121
Change-Id: Icf4eb2cab92ccde42daf583566f0ce7aca6d6d34
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/LayoutInspectionStep.kt
M resourceinspection/resourceinspection-processor/src/main/kotlin/androidx/resourceinspection/processor/Models.kt
M resourceinspection/resourceinspection-processor/src/test/kotlin/androidx/resourceinspection/processor/ResourceInspectionProcessorTest.kt
ch...@google.com <ch...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 6b505f5fbaa249d03647cfa5f236bea9a2967a12
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 12:31:44 2021
Document shadowed attribute interfaces
Test: N/A (docs)
Bug: 188446121
Change-Id: I025fe8f50202c9a30a0bcfcd24cd63047f9b4c75
M core/core/src/main/java/androidx/core/view/TintableBackgroundView.java
M core/core/src/main/java/androidx/core/widget/AutoSizeableTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCheckedTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundButton.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundDrawablesView.java
M core/core/src/main/java/androidx/core/widget/TintableImageSourceView.java
M resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
https://android-review.googlesource.com/1711028
Branch: androidx-main
commit 6b505f5fbaa249d03647cfa5f236bea9a2967a12
Author: Ember Rose <emberrose@google.com>
Date: Tue May 18 12:31:44 2021
Document shadowed attribute interfaces
Test: N/A (docs)
Bug: 188446121
Change-Id: I025fe8f50202c9a30a0bcfcd24cd63047f9b4c75
M core/core/src/main/java/androidx/core/view/TintableBackgroundView.java
M core/core/src/main/java/androidx/core/widget/AutoSizeableTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCheckedTextView.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundButton.java
M core/core/src/main/java/androidx/core/widget/TintableCompoundDrawablesView.java
M core/core/src/main/java/androidx/core/widget/TintableImageSourceView.java
M resourceinspection/resourceinspection-annotation/src/main/java/androidx/resourceinspection/annotation/AppCompatShadowedAttributes.java
Description
The hidden API needs to be restored so we can retain binary compatibility. Currently, any app that upgrades to Core 1.2.0-alpha03 that uses DrawerLayout (say, 1.1.0-alpha02) will fail with an exception:
java.lang.NoSuchMethodError: No static method wrap(Landroid/view/WindowInsets;)Landroidx/core/view/WindowInsetsCompat;
at androidx.drawerlayout.widget.DrawerLayout.onLayout(DrawerLayout.java:1310)