Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Aug 8, 2019 05:33AM

https://android-review.googlesource.com/979408 removed the hidden WindowInsetsCompat.wrap() API that DrawerLayout 1.1.0 (and previous versions?) depend on.

The hidden API needs to be restored so we can retain binary compatibility. Currently, any app that upgrades to Core 1.2.0-alpha03 that uses DrawerLayout (say, 1.1.0-alpha02) will fail with an exception:

java.lang.NoSuchMethodError: No static method wrap(Landroid/view/WindowInsets;)Landroidx/core/view/WindowInsetsCompat;
at androidx.drawerlayout.widget.DrawerLayout.onLayout(DrawerLayout.java:1310)

Comments

ch...@google.com <ch...@google.com> #2Aug 8, 2019 05:38AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3506351

Clean-up SavedState Serialization Reified functions

Expand for full commit details

Clean-up SavedState Serialization Reified functions 
 
- Ensure their positioning and "call hierarchy" match each other. 
- Make the KDocs consistent with KTX Serialization. 
 
RelNote: "N/A" 
Bug: b/399629301 
Test: N/A 
Change-Id: Icb6924b6f1929d4a3c00ded922c74e83fbe163f1

Files:

M lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegates.kt
M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegates.kt

Hash: 4f4e3cf53813a572ddd78967a279e9d5415ac615
Date: Mon Feb 24 13:54:34 2025

ni...@google.com <ni...@google.com> #3Aug 10, 2019 12:46PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3517474

Rename file SavedStateDelegates to SavedStateDelegate

Expand for full commit details

Rename file SavedState*Delegates to SavedState*Delegate 
 
- File name now matches the class name `SavedState*Delegate`. 
- That is consistent with `SavedStateDecoder.kt` and `SavedStateEncoder.kt` that are named after the `internal class` but expose only top-level functions (`SavedStateDecoderKt.method()` or `SavedStateEncoderKt.method()`). 
 
RelNote: "Rename `SavedState*Delegates` to `SavedState*Delegate`." 
Bug: 399629301 
Test: N/A 
Change-Id: I8589b62294646cb4529869228ea0185dac6087e6

Files:

M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegateTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegate.kt
M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegate.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegateTest.kt

Hash: d749bb5032edfe9547da480963da3c559b874023
Date: Fri Feb 28 14:18:38 2025

sj...@google.com <sj...@google.com> #4Aug 10, 2019 01:02PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3506352

Rename SavedStateConfig to SavedStateConfiguration

Expand for full commit details

Rename SavedStateConfig to SavedStateConfiguration 
 
- Previously called `SavedStateConfig`, we have decide to match the name used by the other KotlinX Serialization format configs. 
 
RelNote: "Rename `SavedStateConfig` to `SavedStateConfiguration`." 
Bug: 399629301 
Test: N/A 
Change-Id: I043a5be95276ef617588559f5e3fcdb15905b793

Files:

M lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-savedstate/bcv/native/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegatesTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegates.kt
M savedstate/savedstate-compose/src/androidInstrumentedTest/kotlin/androidx/savedstate/compose/serialization/serializers/MutableStateSerializerTest.android.kt
M savedstate/savedstate-samples/src/main/java/androidx/savedstate/SavedStateCodecSamples.kt
M savedstate/savedstate/api/current.txt
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/bcv/native/current.txt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/ClassDiscriminatorMode.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateConfiguration.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegates.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTestUtils.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/MutableStateFlowSerializerTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecClassDiscriminatorAllObjectsTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecClassDiscriminatorPolymorphicTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecEncodeDefaultsTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegatesTest.kt
M savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/utils/SavedStateSerializationBaseTest.kt

Hash: db71d74194b21d66c591aebfa5b6ea0398f0cd51
Date: Mon Feb 24 14:33:00 2025

ch...@google.com <ch...@google.com> #5Oct 2, 2019 10:22PM

Marked as fixed.

Android API Change

This bug was referenced by a recent CL that changed the Android API surface area.

The Android API Council regularly reviews API changes for consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.

We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.

Changes to lifecycle/lifecycle-viewmodel-savedstate/api/current.txt

androidx.lifecycle.serialization
androidx.lifecycle.serialization.SavedStateHandleDelegateKt
androidx.lifecycle.serialization.SavedStateHandleDelegatesKt

Changes to savedstate/savedstate/api/current.txt

androidx.savedstate.serialization
androidx.savedstate.serialization.SavedStateRegistryOwnerDelegateKt
androidx.savedstate.serialization.SavedStateRegistryOwnerDelegatesKt

http://go/agw/platform/frameworks/support/+/d749bb5032edfe9547da480963da3c559b874023%5E%21
https://android-review.googlesource.com/3517474

[Gerrit:https://android-review.googlesource.com/3517474]
[API-Approvers:ilake@google.com]
[Branch:androidx-main]

[LIBRARY_API_REVIEW_TAG:lifecycle/lifecycle-viewmodel-savedstate/api/current.txt]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]

IssueTracker

Restore binary compatibility between Core 1.2.0 and DrawerLayout 1.1.0

Status Update

Description

Comments

ch...@google.com <ch...@google.com> #2Aug 8, 2019 05:38AM

ni...@google.com <ni...@google.com> #3Aug 10, 2019 12:46PM

sj...@google.com <sj...@google.com> #4Aug 10, 2019 01:02PM

ch...@google.com <ch...@google.com> #5Oct 2, 2019 10:22PM

Android API Change

Issue 139103874

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> #2Aug 8, 2019 05:38AM

ni...@google.com <ni...@google.com> #3Aug 10, 2019 12:46PM

sj...@google.com <sj...@google.com> #4Aug 10, 2019 01:02PM

ch...@google.com <ch...@google.com> #5Oct 2, 2019 10:22PM

Android API Change

Add comment

Issue metadata