Fixed
Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9e4b8cecfebffcc056bad20f28a53f476200b343
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Aug 21 00:07:10 2019
Change FragmentContainerView draw order when popping
Currently FragmentContainerView always draws disappearing views first so
they appear below any views that are entering. When views are being
popped they are exiting, but the expected behavior is that they exit on
top of the view that is returning as a result of the pop.
This change introduces a method in FragmentManager that allows the
default FragmentContainerView drawing order to be reversed so that
exiting views are once again on top. This method is called when
Fragment are removed from the FragmentManager. If the removal is not
caused by a pop, the drawing order remains the same, if the removal is
caused by a pop, the drawing order is reversed.
Test: Added tests, tested in app
Bug: 139104187
Change-Id: I6cbbc91ad84b21197dcfc2776d602070362f44f4
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
https://android-review.googlesource.com/1105891
https://goto.google.com/android-sha1/9e4b8cecfebffcc056bad20f28a53f476200b343
Branch: androidx-master-dev
commit 9e4b8cecfebffcc056bad20f28a53f476200b343
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Aug 21 00:07:10 2019
Change FragmentContainerView draw order when popping
Currently FragmentContainerView always draws disappearing views first so
they appear below any views that are entering. When views are being
popped they are exiting, but the expected behavior is that they exit on
top of the view that is returning as a result of the pop.
This change introduces a method in FragmentManager that allows the
default FragmentContainerView drawing order to be reversed so that
exiting views are once again on top. This method is called when
Fragment are removed from the FragmentManager. If the removal is not
caused by a pop, the drawing order remains the same, if the removal is
caused by a pop, the drawing order is reversed.
Test: Added tests, tested in app
Bug: 139104187
Change-Id: I6cbbc91ad84b21197dcfc2776d602070362f44f4
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
jb...@google.com
This has been fixed internally and will be available in the Fragment 1.2.0-alpha03 release.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2d0a22f1ddeb3b7e9d0002f0e089a25b7ef64f1c
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Aug 23 07:54:04 2019
Change nav integration all to use pop exit animations
Changed the default animations to use a pop_exit animation with a slide
and a pop_enter that does nothing to verify the animations when a
Fragment is popped.
Test: tested in app
BUG: 139104187
Change-Id: I136f37aa3b325a4141de83b0bd391117f3c80f31
M navigation/integration-tests/testapp/src/main/res/anim/nav_default_pop_enter_anim.xml
M navigation/integration-tests/testapp/src/main/res/anim/nav_default_pop_exit_anim.xml
https://android-review.googlesource.com/1105892
https://goto.google.com/android-sha1/2d0a22f1ddeb3b7e9d0002f0e089a25b7ef64f1c
Branch: androidx-master-dev
commit 2d0a22f1ddeb3b7e9d0002f0e089a25b7ef64f1c
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Aug 23 07:54:04 2019
Change nav integration all to use pop exit animations
Changed the default animations to use a pop_exit animation with a slide
and a pop_enter that does nothing to verify the animations when a
Fragment is popped.
Test: tested in app
BUG: 139104187
Change-Id: I136f37aa3b325a4141de83b0bd391117f3c80f31
M navigation/integration-tests/testapp/src/main/res/anim/nav_default_pop_enter_anim.xml
M navigation/integration-tests/testapp/src/main/res/anim/nav_default_pop_exit_anim.xml
pe...@gmail.com
It's beautiful...
So it's in unstable release since Aug. Not much use for stable projects that need stable libraries right?
Release early release often.
Backport fixes.
Come on Google, step up your game!
So it's in unstable release since Aug. Not much use for stable projects that need stable libraries right?
Release early release often.
Backport fixes.
Come on Google, step up your game!
ka...@gmail.com
We use FragmentContainerView in production with version 1.2.0-rc03 and consider it production-ready.
Description
Version used: 1.2.0-alpha02
Devices/Android versions reproduced on: Android Emulator API 27
FragmentContainerView always draws entering fragments on top exiting ones. This breaks animations when navigating backwards. Please see attached video and sample project.
Should FragmentContainterView reverse draw order when fragment is being popped off backstack?