Status Update
No update yet.
Comments
ap...@google.com
Hi. Thanks for reporting this. Fixed in alpha-04
da...@google.com
do...@traveloka.com
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
da...@google.com
do...@traveloka.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
[Deleted User] <[Deleted User]>
da...@google.com
Hey, thank you so much for the reproducible project. The legacy hash is based on CREATE statements and it looks like that our backwards compatibility logic missed a detail.
In Room 2.2.0 we updated the CREATE INDEX statement to also included IF NOT EXSIST. We remove the latter section when calculating the legacy hash, buuuut turns out that the previous CREATE INDEX statement had two spaces between the CREATE and INDEX words, while the updated statement along with the backward compatibility adjustment makes it have one, causing the hash to be different.
I'll try to fix this soon, might end up in a Room 2.2.3 release.
da...@google.com
ap...@google.com
Branch: androidx-master-dev
commit 40e267943a2398b9e4177f2642f9577455821ff6
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Dec 05 09:02:11 2019
Leave extra space between CREATE and INDEX in legacy hash calculation.
When calculating the legacy hash not only must IF NOT EXISTS be removed
from the CREATE INDEX statement, but an extra space has to be preserved
since versions of Room before 2.2 had such typo and is considered
during legacy hash calculations.
Bug: 139306173
Test: ./gradlew vo.DatabaseTest
Change-Id: If1d9ad8f57b4953fb41f938d00a70199038e2266
M room/compiler/src/main/kotlin/androidx/room/vo/Database.kt
M room/compiler/src/test/kotlin/androidx/room/vo/DatabaseTest.kt
Description