Add API to display hyperlinks [139312671]

Fixed

Feature Request

compose-roadmap-proposal

Status Update

No update yet.

Description

si...@google.com

created issue #1

Aug 12, 2019 10:30PM

Hyperlinks have some support on Android.

We have the Linkify and LinkifyCompat classes. Moreover, URLSpan on android handles the visual aspects of the links and also touch handling.

However, the current system suffers a lot from a few behaviors:
- linkify using patterns make text processing slow
- the developer had no control over the creation of URLSpans which caused them not to be able to have custom logic on click.

On android hyperlinks can be styled at the widget level.

This ticket is for the first step of hyperlink support which enables the display of hyperlinks.

related document:

https://docs.google.com/document/d/1RM4OMS4iwFXvmFbOefUUaxgRO9k4ZLt4j-jAHGQi8_Y/edit

Comments

si...@google.com <si...@google.com> Aug 12, 2019 10:38PM

Assigned to ha...@google.com.

si...@google.com <si...@google.com> #2Aug 13, 2019 02:07AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

si...@google.com <si...@google.com> Sep 23, 2019 04:43PM

Status: New

si...@google.com <si...@google.com> Oct 5, 2019 06:01AM

Assigned to an...@google.com.

si...@google.com <si...@google.com> Dec 3, 2019 12:35AM

Reassigned to no...@google.com.

si...@google.com <si...@google.com> #3Feb 4, 2020 02:42AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

no...@google.com <no...@google.com> #4Feb 6, 2020 07:59PM

Reassigned to an...@google.com.

deleted

si...@google.com <si...@google.com> Mar 19, 2020 07:23PM

Reassigned to no...@google.com.

si...@google.com <si...@google.com> #5Apr 23, 2020 06:21PM

Reassigned to an...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

si...@google.com <si...@google.com> #6May 4, 2020 10:05PM

removed from June release since we will not be able to finish these tasks until June.

si...@google.com <si...@google.com> May 26, 2020 01:22AM

Reassigned to si...@google.com.

si...@google.com <si...@google.com> Jun 16, 2020 05:34AM

Accepted by si...@google.com.

si...@google.com <si...@google.com> #7Jun 24, 2020 02:29PM

This ticket is a candidate for punt since the how to do it will require some time to innovate, discuss.

si...@google.com <si...@google.com> Oct 29, 2020 05:51PM

Assigned to si...@google.com.

si...@google.com <si...@google.com> Feb 11, 2021 01:20AM

Reassigned to an...@google.com.

si...@google.com <si...@google.com> Apr 14, 2021 07:41PM

Reassigned to si...@google.com.

si...@google.com <si...@google.com> Oct 8, 2021 03:10PM

Reassigned to an...@google.com.

ub...@gmail.com <ub...@gmail.com> #8Jun 8, 2022 09:44PM

Any progress here?

[Deleted User] <[Deleted User]> #9Oct 18, 2022 06:46PM

This ticket (marked as duplicate) contains a sample project and a video which might be helpful to the engineer working on this.

ClickableText with AnnotatedString using UrlAnnotation with Talkback enabled does not call onClick()

ub...@gmail.com <ub...@gmail.com> #10Nov 2, 2022 09:34AM

Related issue regarding styled string resources: https://issuetracker.google.com/issues/139320238

In particular, internationalization concerns described in https://issuetracker.google.com/issues/139320238#comment12

gr...@google.com <gr...@google.com> #11Jan 17, 2023 11:34PM

If this ever does get implemented, note that it would be nice to have the cursor icon change when hovering over a link.

aa...@marinosoftware.com <aa...@marinosoftware.com> #12Jun 1, 2023 01:31PM

@#8 They said it's due to be finished in June. What year is anyone's guess.

si...@google.com <si...@google.com> Jun 5, 2023 06:31PM

Reassigned to so...@google.com.

so...@google.com <so...@google.com> Sep 7, 2023 05:34PM

Accepted by so...@google.com.

so...@google.com <so...@google.com> Feb 12, 2024 10:23AM

Marked as fixed.

so...@google.com <so...@google.com> Feb 19, 2024 12:40PM

Status: In Progress (Accepted) (reopened)

ap...@google.com <ap...@google.com> #13Apr 4, 2024 04:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit f87f07f58309f38933b32309e93a944420a185be
Author: Anastasia Soboleva <soboleva@google.com>
Date: Thu Mar 28 15:06:28 2024

Implement links interactiom listeners and styling through annotation only

LinkInteractionListener is set on LinkAnnotation. Currently only has a click function but is a fun interface. In the future can be extended to support onHover or other interactions that are needed. Note that Clickable should ideally have it non-null but this wouldn't work as we need to restore it.

LinkAnnotation now takes the style, focusStyle and hoverStyle.

Test: ui:ui-text:test, ui:ui-text:cC, f:f:cC in text folder
Relnote: "LinkAnnotation now takes the state-based styling arguments and a LinkInteractionListener. Add this annotation to the AnnotatedString to get a hyperlink. By passing focusedState and/or hoveredState you can define the visual conficuration for links when they are focused and/or hovered."
Bug: 139312671

Change-Id: I81ce4350b8a1e37881000fd82f081b7afb8e0f42

M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/Hyperlinks.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/BasicTextLinkTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/BasicTextSemanticsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextLinkScope.kt
M compose/ui/ui-text/api/api_lint.ignore
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/samples/src/main/java/androidx/compose/ui/text/samples/AnnotatedStringBuilderSamples.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/AnnotatedStringFromHtmlTest.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/platform/AndroidAccessibilitySpannableStringTest.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/AnnotatedStringBuilderTest.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/input/TextFieldValueTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/LinkAnnotation.kt
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/LinkInteractionListener.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt

https://android-review.googlesource.com/3008514

ap...@google.com <ap...@google.com> #14Apr 8, 2024 09:37AM

Project: platform/frameworks/support
Branch: androidx-main

commit efd00b74fb310a1dc2ec3881c1539fb9a447eaef
Author: Anastasia Soboleva <soboleva@google.com>
Date: Wed Apr 03 18:16:26 2024

Add TextDefaults object to material and material3

It provides methods to construct AnnotatedString from the html string and LinkAnnotation where links will get their styling according to the Material theme

TextDefaults.Url() and TextDefaults.Clickable() composable functions that don't return Unit should normally start with lower case letter. But these are factory methods, they are upper-cased to imitate the LinkAnnotation.Url constructor.

Test: TextTest
Test: demo
Bug: 139312671
Relnote: "Added a TextDefaults object that contains methods to construct a LinkAnnotation and parse HTML-tagged string which apply MaterialTheme to the links"

Change-Id: I98532f3512d1930416f66dd195746eeeba884497

M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/Hyperlinks.kt
M compose/material/material/api/api_lint.ignore
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/build.gradle
M compose/material/material/lint-baseline.xml
A compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextSamples.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/TextTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material3/material3/api/api_lint.ignore
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/lint-baseline.xml
A compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/TextSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TextTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Text.kt

https://android-review.googlesource.com/3024605

ap...@google.com <ap...@google.com> #15Apr 8, 2024 04:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit c70a4c6be82ef1bcc338b20d663b55545caebdf9
Author: Anastasia Soboleva <soboleva@google.com>
Date: Thu Apr 04 14:47:32 2024

Update LinkAnnotation savers to save/restore styles

Added demo that creates a custom listener. We should eventually add some edit/replace methods to the AnnotatedString
to make things like this easier to implement.

Bug: 139312671
Test: SaversTest
Test: demo

Change-Id: I3613a30733ba87321e4cb72a3414c0f9522ad529

M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/Hyperlinks.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt

https://android-review.googlesource.com/3027704

ap...@google.com <ap...@google.com> #16Apr 9, 2024 12:32PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 703f585278dc1f9343659fd2ffa1b415e4366ba7
Author: Anastasia Soboleva <soboleva@google.com>
Date: Fri Apr 05 15:45:22 2024

Update a11y support for links in text

Fixes: 139312671
Test: demo with Talkback on
Test: AndroidAccessibilitySpannableStringTest

Change-Id: I11ef6b96dc1f791dd266e6cb5100f265ac6c2456

M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/Hyperlinks.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/BasicTextSemanticsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextLinkScope.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/platform/AndroidAccessibilitySpannableStringTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidAccessibilitySpannableString.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/URLSpanCache.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt

https://android-review.googlesource.com/3027712

ap...@google.com <ap...@google.com> #17Apr 10, 2024 09:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9b67b3756698b4bfa17b9060908daa5da950d250
Author: Anastasia Soboleva <soboleva@google.com>
Date: Wed Apr 10 12:20:08 2024

Add pressed styling to the link

We now basically support similar styling options as web. We don't have "visited"
which is to be handled by developers if needed. This CL adds missing pressed styling option which corresponds to "active" in css.

Test: compose:f:f:cC, compose:ui:ui-text:cC
Test: demo
Bug: 139312671
Relnote: "Text links got pressed state styling option in addition to normal styling, hovered and focused"
Change-Id: I5f864b3fd1b1af6ff39dee03e1aa65ede7e16d32

M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/Hyperlinks.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/BasicTextLinkTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextLinkScope.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Text.kt
M compose/ui/ui-text/api/api_lint.ignore
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/AnnotatedStringFromHtmlTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/Html.android.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Html.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/LinkAnnotation.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/Html.skiko.kt

https://android-review.googlesource.com/3035615

ap...@google.com <ap...@google.com> #18Apr 11, 2024 09:20AM

Project: platform/frameworks/support
Branch: androidx-main

commit 04ffaa7cede823e9e17ceb68dce1e4583c84ccb3
Author: Anastasia Soboleva <soboleva@google.com>
Date: Wed Apr 10 12:34:58 2024

Add pressed styling for links in material/material3

Test: TextTest
Bug: 139312671
Relnote: "Text links got pressed state styling option in addition to normal styling, hovered and focused. TextDefaults methods each got a pressedStyle argument to support that."

Change-Id: Ic473f81fd32d95ad84d6bc452c8dcbf6de7ba4ba

M compose/material/material/api/api_lint.ignore
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Text.kt

https://android-review.googlesource.com/3035616

na...@google.com <na...@google.com> #19Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.7.0-alpha07
androidx.compose.foundation:foundation-android:1.7.0-alpha07
androidx.compose.foundation:foundation-desktop:1.7.0-alpha07
androidx.compose.material:material:1.7.0-alpha07
androidx.compose.material:material-android:1.7.0-alpha07
androidx.compose.material:material-desktop:1.7.0-alpha07
androidx.compose.material3:material3:1.3.0-alpha05
androidx.compose.material3:material3-android:1.3.0-alpha05
androidx.compose.material3:material3-desktop:1.3.0-alpha05
androidx.compose.ui:ui:1.7.0-alpha07
androidx.compose.ui:ui-android:1.7.0-alpha07
androidx.compose.ui:ui-desktop:1.7.0-alpha07
androidx.compose.ui:ui-text:1.7.0-alpha07
androidx.compose.ui:ui-text-android:1.7.0-alpha07
androidx.compose.ui:ui-text-desktop:1.7.0-alpha07

za...@gmail.com <za...@gmail.com> #20Jun 6, 2024 03:02PM

Comment has been deleted.

Message last modified on Jun 6, 2024 11:47PM

Issue 139312671

Description

Issue summary

Comments

si...@google.com <si...@google.com> Aug 12, 2019 10:38PM

si...@google.com <si...@google.com> #2Aug 13, 2019 02:07AM

si...@google.com <si...@google.com> Sep 23, 2019 04:43PM

si...@google.com <si...@google.com> Oct 5, 2019 06:01AM

si...@google.com <si...@google.com> Dec 3, 2019 12:35AM

si...@google.com <si...@google.com> #3Feb 4, 2020 02:42AM

no...@google.com <no...@google.com> #4Feb 6, 2020 07:59PM

si...@google.com <si...@google.com> Mar 19, 2020 07:23PM

si...@google.com <si...@google.com> #5Apr 23, 2020 06:21PM

si...@google.com <si...@google.com> #6May 4, 2020 10:05PM

si...@google.com <si...@google.com> May 26, 2020 01:22AM

si...@google.com <si...@google.com> Jun 16, 2020 05:34AM

si...@google.com <si...@google.com> #7Jun 24, 2020 02:29PM

si...@google.com <si...@google.com> Oct 29, 2020 05:51PM

si...@google.com <si...@google.com> Feb 11, 2021 01:20AM

si...@google.com <si...@google.com> Apr 14, 2021 07:41PM

si...@google.com <si...@google.com> Oct 8, 2021 03:10PM

ub...@gmail.com <ub...@gmail.com> #8Jun 8, 2022 09:44PM

[Deleted User] <[Deleted User]> #9Oct 18, 2022 06:46PM

ub...@gmail.com <ub...@gmail.com> #10Nov 2, 2022 09:34AM

gr...@google.com <gr...@google.com> #11Jan 17, 2023 11:34PM

aa...@marinosoftware.com <aa...@marinosoftware.com> #12Jun 1, 2023 01:31PM

si...@google.com <si...@google.com> Jun 5, 2023 06:31PM

so...@google.com <so...@google.com> Sep 7, 2023 05:34PM

so...@google.com <so...@google.com> Feb 12, 2024 10:23AM

so...@google.com <so...@google.com> Feb 19, 2024 12:40PM

ap...@google.com <ap...@google.com> #13Apr 4, 2024 04:49PM

ap...@google.com <ap...@google.com> #14Apr 8, 2024 09:37AM

ap...@google.com <ap...@google.com> #15Apr 8, 2024 04:52PM

ap...@google.com <ap...@google.com> #16Apr 9, 2024 12:32PM

ap...@google.com <ap...@google.com> #17Apr 10, 2024 09:16PM

ap...@google.com <ap...@google.com> #18Apr 11, 2024 09:20AM

na...@google.com <na...@google.com> #19Apr 17, 2024 05:17PM

za...@gmail.com <za...@gmail.com> #20Jun 6, 2024 03:02PM

Add comment

Issue metadata