IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date:   Fri Jul 10 16:23:09 2020

    Semantics no-op cleanups
   
    Partly in response to lmr's broad code review, I did a pass of
    superficial API/implementation cleanup.  The main changes are:
   
    - I changed each Boolean SemanticsProperty where false is equivalent to
      not being present to take "Unit" instead.  This is conceptually
      clearer: it avoids questions like "can I cancel out a semantics from a
      merged child by setting it to false?"  Because "property = Unit" looks
      weird, I also changed the style of these to "property()".
   
    - I moved the Semantics id generator closer to where it's used, in
      SemanticsModifierCore.  I made it internal and an AtomicInt.
      (Note that integer ids are heavily used in the Android
      AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
   
    - I deleted dead code.  Some examples include SemanticsHintOverrides,
      a public API not connected to anything, and SemanticsPropertyKey
      merge() open method which is never called.  (In both cases I have
      a different plan in mind for accessibility.)
   
    Fixes: 145951226
    Fixes: 145955412
    Test: existing tests
    Relnote: "Single-value semantics properties now use a calling style.
    For example, 'semantics { hidden = true }' is now written as:
    'semantics { hidden() }'."
   
    Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M       ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M       ui/ui-core/api/0.1.0-dev15.txt
M       ui/ui-core/api/current.txt
M       ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-core/api/public_plus_experimental_current.txt
M       ui/ui-core/api/restricted_0.1.0-dev15.txt
M       ui/ui-core/api/restricted_current.txt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M       ui/ui-foundation/api/0.1.0-dev15.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M       ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M       ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M       ui/ui-text/api/0.1.0-dev15.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev15.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

test

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e2e911e8fcb08867b586cd4b0d92319dfa04e6db
Author: Siyamed Sinir <siyamed@google.com>
Date:   Mon Oct 28 21:14:23 2019

    Remove selectionColor from Text composable
   
    Even though Text should define a selection color in the future:
    - selection state of Text will probably more complicated than just a color
    - initially it is better SelectionContainer to define those values
    - it is better to enable this to be themed
   
    Therefore selectionColor should not be a part of the Text composable as it is
    right now. aosp/1149085 tries to introduce a selection style, and lets
    SelectionContainer to install the selection style.
   
    Test: ./gradlew ui:ui-framework:test
    Test: ./gradlew ui:ui-framework:connectedAndroidTest
    Test: ./gradlew ui:ui-text:test
    Test: ./gradlew ui:ui-text:connectedAndroidTest
   
    Bug: 139320372
    Change-Id: I62aa2c45b59ab4d6991894795b12f61ab06806e0

M       ui/ui-foundation/integration-tests/foundation-demos/src/main/java/androidx/ui/foundation/demos/PopupActivity.kt
M       ui/ui-framework/api/0.1.0-dev03.txt
M       ui/ui-framework/api/api_lint.ignore
M       ui/ui-framework/api/current.txt
M       ui/ui-framework/api/public_plus_experimental_0.1.0-dev03.txt
M       ui/ui-framework/api/public_plus_experimental_current.txt
M       ui/ui-framework/api/restricted_0.1.0-dev03.txt
M       ui/ui-framework/api/restricted_current.txt
M       ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/autofill/ExplicitAutofillTypesActivity.kt
M       ui/ui-framework/src/androidTest/java/androidx/ui/core/test/TextFieldTest.kt
M       ui/ui-framework/src/main/java/androidx/ui/core/PasswordTextField.kt
M       ui/ui-framework/src/main/java/androidx/ui/core/Text.kt
M       ui/ui-framework/src/main/java/androidx/ui/core/TextField.kt
M       ui/ui-framework/src/main/java/androidx/ui/core/TextFieldDelegate.kt
M       ui/ui-framework/src/test/java/androidx/ui/core/TextFieldDelegateTest.kt
M       ui/ui-text/api/0.1.0-dev03.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev03.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev03.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeInputField.kt
M       ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldFocusTransition.kt
M       ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldTrickyUseCase.kt
M       ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeVariousInputField.kt
D       ui/ui-text/src/main/java/androidx/ui/input/EditorStyle.kt

https://android-review.googlesource.com/1153315
https://goto.google.com/android-sha1/e2e911e8fcb08867b586cd4b0d92319dfa04e6db

This bug was referenced by a recent CL that changed the Android API surface area.

The Android API Council <http://go/android-api-council> regularly reviews API changes for
consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out
if you'd like us to review it sooner.

CHANGES TO ui/ui-framework/api/current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.core
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.PasswordTextFieldKt
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.TextFieldKt
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.TextKt

CHANGES TO ui/ui-framework/api/public_plus_experimental_current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.core
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.PasswordTextFieldKt
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.TextFieldKt
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.core.TextKt

CHANGES TO ui/ui-text/api/current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.input
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.input.EditorStyle

CHANGES TO ui/ui-text/api/public_plus_experimental_current.txt

http://goto.google.com/android-api-diff/support/cur/pkg/androidx.ui.input
http://goto.google.com/android-api-diff/support/cur/clz/androidx.ui.input.EditorStyle

The links above may take several days to start working. Generated from http://go/support-current.txt/e2e911e8fcb08867b586cd4b0d92319dfa04e6db
CL: http://android-review.googlesource.com/1153315
API Approvers: siyamed@google.com

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see b/123001228#comment6

(bulk comment) Hi,

Can you please check if this task can be finished before  June, and if not remove `Jetpack Compose Major Release (May 2020)` hotlist?

(apologies if this is a double comment)

Thank you

(bulk comment)
Please ignore last comment related to the June release. It was caused by a mistake in the query I used. Thank you.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 93195d42d1f079136053e33ccec6e7d5ac839dfe
Author: Louis Pullen-Freilich <lpf@google.com>
Date:   Tue Nov 17 15:20:25 2020

    Adds AmbientTextSelectionColors to allow customizing the colors used for text selection
   
    Also sets the correct Material defaults in MaterialTheme
   
    Bug: b/139320372
    Bug: b/139320907
    Test: MaterialTextSelectionColorsScreenshotTest
    Test: TextSelectionColorsScreenshotTest
    Test: TextSelectionBackgroundColorTest
    Relnote: "MaterialTheme now sets the correct colors for selection handles and selection background. Non-Material apps can manually use AmbientTextSelectionColors to customize the colors used for selection."
    Change-Id: I1e6f4b495bdc713e162759a08ecf0a7311b26e33

M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextFieldDelegateIntegrationTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M       compose/material/material/api/current.txt
M       compose/material/material/api/public_plus_experimental_current.txt
M       compose/material/material/api/restricted_current.txt
A       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialTextSelectionColorsScreenshotTest.kt
A       compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTextSelectionColors.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTheme.kt
A       compose/material/material/src/test/kotlin/androidx/compose/material/TextSelectionBackgroundColorTest.kt
M       compose/ui/ui/api/current.txt
M       compose/ui/ui/api/public_plus_experimental_current.txt
M       compose/ui/ui/api/restricted_current.txt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/selection/SelectionHandlesTest.kt
A       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/selection/TextSelectionColorsScreenshotTest.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionHandles.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/TextSelectionColors.kt

https://android-review.googlesource.com/1502030