API for changing Selection background color [139320372]

Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Aug 13, 2019 01:42AM

No description yet.

Comments

si...@google.com <si...@google.com> Oct 26, 2019 04:37PM

Accepted by si...@google.com.

si...@google.com <si...@google.com> #2Oct 27, 2019 12:27AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

Message last modified on Nov 6, 2020 05:38AM

si...@google.com <si...@google.com> #3Oct 28, 2019 04:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

Message last modified on Nov 6, 2020 05:37AM

ap...@google.com <ap...@google.com> #4Nov 1, 2019 05:55AM

deleted

ap...@google.com <ap...@google.com> #5Nov 1, 2019 06:09AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

si...@google.com <si...@google.com> Nov 22, 2019 07:19AM

Assigned to si...@google.com.

si...@google.com <si...@google.com> Dec 3, 2019 06:33PM

Status: New

si...@google.com <si...@google.com> Jan 15, 2020 12:48AM

Assigned to an...@google.com.

si...@google.com <si...@google.com> #6Feb 4, 2020 02:41AM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

si...@google.com <si...@google.com> Apr 18, 2020 12:24AM

Reassigned to qq...@google.com.

si...@google.com <si...@google.com> #7May 4, 2020 10:12PM

(bulk comment) Hi,

Can you please check if this task can be finished before June, and if not remove `Jetpack Compose Major Release (May 2020)` hotlist?

(apologies if this is a double comment)

Thank you

si...@google.com <si...@google.com> #8May 4, 2020 10:26PM

(bulk comment)
Please ignore last comment related to the June release. It was caused by a mistake in the query I used. Thank you.

si...@google.com <si...@google.com> #9Sep 14, 2020 11:22PM

further postponing to category 3, since it doesn't look like we can accomplish this one. If time allows one of us will pick it up during category 2.

si...@google.com <si...@google.com> #10Nov 6, 2020 04:56PM

Reassigned to lp...@google.com.

related: b/139320907

ap...@google.com <ap...@google.com> #11Nov 20, 2020 11:49PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 93195d42d1f079136053e33ccec6e7d5ac839dfe
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Tue Nov 17 15:20:25 2020

Adds AmbientTextSelectionColors to allow customizing the colors used for text selection

Also sets the correct Material defaults in MaterialTheme

Bug:

b/139320372

Bug:

b/139320907

Test: MaterialTextSelectionColorsScreenshotTest
Test: TextSelectionColorsScreenshotTest
Test: TextSelectionBackgroundColorTest
Relnote: "MaterialTheme now sets the correct colors for selection handles and selection background. Non-Material apps can manually use AmbientTextSelectionColors to customize the colors used for selection."
Change-Id: I1e6f4b495bdc713e162759a08ecf0a7311b26e33

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextFieldDelegateIntegrationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialTextSelectionColorsScreenshotTest.kt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTextSelectionColors.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTheme.kt
A compose/material/material/src/test/kotlin/androidx/compose/material/TextSelectionBackgroundColorTest.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/selection/SelectionHandlesTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/selection/TextSelectionColorsScreenshotTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/SelectionHandles.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/selection/TextSelectionColors.kt

https://android-review.googlesource.com/1502030

lp...@google.com <lp...@google.com> Nov 20, 2020 11:58PM

Marked as fixed.