Support text auto sizing [139320827]

Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Aug 13, 2019 01:47AM

On Android TextView has autosize. Other platforms also has this property. Not sure if this is defined in CSS or HTML.

Comments

si...@google.com <si...@google.com> #2Feb 4, 2020 02:42AM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

si...@google.com <si...@google.com> Mar 26, 2020 04:32PM

Assigned to an...@google.com.

so...@google.com <so...@google.com> Feb 21, 2022 03:09PM

Reassigned to so...@google.com.

64...@gmail.com <64...@gmail.com> #3Sep 11, 2023 12:48PM

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

gl...@gmail.com <gl...@gmail.com> #4Oct 4, 2023 11:17AM

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

al...@gmail.com <al...@gmail.com> #5Mar 12, 2024 01:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

so...@google.com <so...@google.com> #6Jun 14, 2024 03:07PM

Reassigned to mu...@google.com.

Bugjuggler: wait until 2022-03-23

ap...@google.com <ap...@google.com> #7Aug 30, 2024 04:03PM

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.

jo...@google.com <jo...@google.com> #8Aug 30, 2024 05:13PM

Is there a replacement or should we just abandon TextClassifier for android older than API Level 26 ?

mu...@google.com <mu...@google.com> Sep 3, 2024 03:20PM

Accepted by mu...@google.com.

ap...@google.com <ap...@google.com> #9Sep 6, 2024 01:25PM

Abandon. The owning team had no plans to release a replacement library.

ap...@google.com <ap...@google.com> #10Sep 16, 2024 03:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5d923a5049d9f073055745cb2d2563066cc9d996
Author: Muhammad Ali Shah <muhammadalis@google.com>
Date: Thu Sep 12 13:26:43 2024

AutoSize: Implement MultiParagraphLayoutCache logic

Test: Checked valid and invalid sequences of font sizes, different constraints, different texts, Ellipsis/Visual overflow behavior, compatibility with the em unit and behavior when minLines is greater than 1. All works as intended.
Bug: 139320827
Change-Id: I38196267ae1d2b7605c64c1741d19883747f35b2

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNodeInvalidationTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNode.kt

https://android-review.googlesource.com/3259863

mu...@google.com <mu...@google.com> Sep 19, 2024 03:23PM

Assigned to co...@google.com.

lp...@google.com <lp...@google.com> Sep 19, 2024 05:14PM

Reassigned to jo...@google.com.

ap...@google.com <ap...@google.com> #11Oct 16, 2024 01:23PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3307918

Publish AutoSize Text

Expand for full commit details

Publish AutoSize Text

AutoSize is now public and sealed and does not expose any API. All methods are moved to the internal TextAutoSize, which will let us publish the API for custom AutoSize implementations in the future if needed.

Test: Existing
Bug: 139320827
Relnote: "Support for auto-sizing text. Pass an AutoSize instance (e.g. AutoSize.StepBased) to your favorite text composable (like BasicText) and see your text size adapt to the available space!"

Change-Id: Ice7e09b9cac7be10ab5e681ec57d994d50102583

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeText.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/AutoSizeTestUtils.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/ParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/androidUnitTest/kotlin/androidx/compose/foundation/text/AutoSizeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/AutoSize.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicText.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/AutoSizeTextLayoutScope.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/ParagraphLayoutCache.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/SelectableTextAnnotatedStringNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleElement.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNode.kt

Hash: 54dd40666510382dd44ed84ec92903dba3af5df8
Date: Mon Oct 14 16:43:38 2024

jo...@google.com <jo...@google.com> Oct 16, 2024 03:09PM

Marked as fixed.

eb...@netflix.com <eb...@netflix.com> #12Oct 28, 2024 11:01PM

Hello, out of curiosity, is is something for compose 1.8 or later?

jo...@google.com <jo...@google.com> #13Oct 29, 2024 07:46AM

This will land in 1.8, pending possible API refinements. We will comment on this issue when the change is included in a release.

pr...@google.com <pr...@google.com> #14Oct 30, 2024 05:38PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha05
androidx.compose.foundation:foundation-android:1.8.0-alpha05
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha05
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha05

an...@justdice.io <an...@justdice.io> #15Nov 1, 2024 10:59AM

I tested out androidx.compose.foundation:foundation:1.8.0-alpha05 and noticed that BasicText with an autoSize argument just cuts off the text with maxLines set to 1.

On Android Views, when using android:autoSizeTextType="uniform" and android:maxLines="1", the TextView properly sizes down until the min text size is reached.

<LinearLayout
        android:layout_width="15dp"
        android:layout_height="wrap_content">
        <TextView
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:autoSizeTextType="uniform"
            android:autoSizeMinTextSize="2sp"
            android:autoSizeMaxTextSize="14sp"
            android:maxLines="1"
            android:text="Test" />
</LinearLayout>

Box(Modifier.width(15.dp)) {
        BasicText("Test", autoSize = AutoSize.StepBased(2.sp, 14.sp), maxLines = 1)
}

jo...@google.com <jo...@google.com> #16Nov 1, 2024 02:06PM

Thanks for the report! Please file a new bug in this component for tracking purposes. Thank you!

an...@justdice.io <an...@justdice.io> #17Nov 1, 2024 02:15PM

Linked issue: https://issuetracker.google.com/issues/376834366

b9...@gmail.com <b9...@gmail.com> #18Dec 12, 2024 10:58AM

Any workable sample? I couldn't get any auto-sizing behavior.