IssueTracker

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link:      https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

#2, yeah, that's the same issue.

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.8.0-beta01
• androidx.compose.foundation:foundation-android:1.8.0-beta01
• androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
• androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

I agree with Comment #7, I think this is an important issue we should resolve (P2 at least).

Siyamed, if you / your team does not have time to look at this, feel free to assign to me - happy to take this over. As well as allowing changing the color, MaterialTheme should also be configured to set a color from the theme by default so that it is correct out of the box for typicaly use cases.

related: b/139320372

Thanks Louis.

Please keep in mind there are two main entry points: Text selection and TextField selection. as a note: In TextField it is possible that existing cursorColor defines those colors (or one of them)

it would be best to control selection as a whole for both of them I believe, but let's discuss it. Looks like material.TextField uses errorColor and activeColor as the cursor color. let's make sure we take that into account while designing the theming (they seem to be related)

open questions, assumptions that need verification:

• is cursorColor and selection color the same
• cursorColor is errorColor and activeColor in material.TextField, is there any relation
• Text and TextField should use a single selection color for consistency
• selection color is always the same for selection handle and selection background
• cursor color determines insertion (cursor) handle color as well (we do not have cursor handle yet)
• what the default color should be for light and dark mode
• shape of the cursor handle is not urgent, and possibly something we specifically don't want customization for the phone end user experience (similar to cursor animation)
• can there be a default color in foundation? choosing the text color, bg color etc too tricky. Using the exact text color wouldn't work since it would make text invisible.