SelectionContainer Magnifier [139320979]

Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Aug 13, 2019 02:10AM

No description yet.

Comments

si...@google.com <si...@google.com> #2Feb 4, 2020 02:42AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

si...@google.com <si...@google.com> Mar 26, 2020 04:32PM

Assigned to an...@google.com.

si...@google.com <si...@google.com> Aug 21, 2020 07:15PM

Reassigned to qq...@google.com.

si...@google.com <si...@google.com> Nov 13, 2020 12:50AM

Reassigned to an...@google.com.

kl...@google.com <kl...@google.com> #3Oct 21, 2021 04:29PM

Reassigned to kl...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

si...@google.com <si...@google.com> #4Oct 25, 2021 06:39AM

I think the title is misleading, as you mentioned it applies to both static text selection and also TextField selection.

si...@google.com <si...@google.com> #5Oct 25, 2021 07:58PM

I think the title is misleading

Sorry, I thought I entered the ticket with "SelectionContainer Magnifier" title and thought that it was confusing which resulted in comment#3.

I didn't realize that the title was changed on comment#3, I reverted my change.

kl...@google.com <kl...@google.com> Nov 12, 2021 12:38AM

Accepted by kl...@google.com.

ap...@google.com <ap...@google.com> #6Dec 7, 2021 04:11PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit adabe34b36e7ed63209e9a70d5c892a1290f20f3
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Nov 11 16:38:13 2021

Implement selection magnification for SelectionContainer.

Text _field_ selection magnification was implemented in aosp/1844741.
This change also refactors the text field magnifier a bit so both
magnifiers can share the animation code.

Fixes:

b/139320979

Test: Added SelectionMagnifierTest: ./gradlew :compose:foundation:foundation:connectedDebugAndroidTest
Relnote: "The magnifier widget now shows when dragging selection
handles in a SelectionContainer."
Change-Id: I30b386701480c51bf711c5d9936e7a5e6b7b5a71

M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionMagnifierTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
D compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/TextFieldMagnifier.desktop.kt
M compose/foundation/foundation/api/current.ignore
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.android.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.desktop.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.desktop.kt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/current.txt
D compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldMagnifierAndroidImplTest.kt
D compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/TextFieldMagnifier.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.android.kt
M compose/foundation/foundation/api/restricted_current.ignore
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextFieldMagnifierTest.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldMagnifier.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionMagnifier.kt

https://android-review.googlesource.com/1890195