Fixed
Status Update
Comments
si...@google.com <si...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
si...@google.com <si...@google.com>
kl...@google.com <kl...@google.com> #3
kl...@google.com <kl...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
st...@google.com <st...@google.com> #5
Related to
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 3e74e5ef9d8e4ab6c599c95fcc510fae230c2470
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Dec 07 19:54:49 2022
Introduce marquee modifier.
Unlike my first attempt at this, aosp/1931284, this time I tried to copy
the simplicity and behavior of the platform behavior as closely as
possible, with the simplest implementation possible.
However, like with that first attempt, this modifier can be used on
anything, not just text.
The modifier uses defaults that match the behavior of the platform, with
limited customization options for repitition count, speed, delay, and
spacing. This should solve all of the use cases of the platform feature,
and if we need to build something more complex we can do that later.
This implementation does not support content that accepts pointer events
or other input. I checked the platform implementation and it also
doesn't handle this well (e.g. if the text has a clickable link in it,
the link is only clickable at certain points in the animation and not
where it's rendered).
Fixes: b/139321650
Test: BasicMarqueeTest
Relnote: "Introduce experimental `Modifier.basicMarquee()` for displaying
content with a scrolling marquee effect."
Change-Id: I2df44c3343afa8400b0da768a642b77da94c103d
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/BasicMarqueeDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/samples/build.gradle
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BasicMarqueeSamples.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
https://android-review.googlesource.com/2334291
Branch: androidx-main
commit 3e74e5ef9d8e4ab6c599c95fcc510fae230c2470
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Dec 07 19:54:49 2022
Introduce marquee modifier.
Unlike my first attempt at this, aosp/1931284, this time I tried to copy
the simplicity and behavior of the platform behavior as closely as
possible, with the simplest implementation possible.
However, like with that first attempt, this modifier can be used on
anything, not just text.
The modifier uses defaults that match the behavior of the platform, with
limited customization options for repitition count, speed, delay, and
spacing. This should solve all of the use cases of the platform feature,
and if we need to build something more complex we can do that later.
This implementation does not support content that accepts pointer events
or other input. I checked the platform implementation and it also
doesn't handle this well (e.g. if the text has a clickable link in it,
the link is only clickable at certain points in the animation and not
where it's rendered).
Fixes:
Test: BasicMarqueeTest
Relnote: "Introduce experimental `Modifier.basicMarquee()` for displaying
content with a scrolling marquee effect."
Change-Id: I2df44c3343afa8400b0da768a642b77da94c103d
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/BasicMarqueeDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/samples/build.gradle
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BasicMarqueeSamples.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 7e514a1106d3ddf9d4d583f879bb0c1b34c27b28
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Dec 13 07:45:53 2022
Some marquee polish.
Follow-up to aops/2334291.
Cleans up some of the implementation code, and allows some properties to
be updated without recreating the whole modifier instance, addresses
some nits from the initial CL, and adds some tests.
Bug: b/139321650
Test: BasicMarqueeTest
Relnote: n/a
Change-Id: I5b8091a396f72c5d81f28e4fd846d9452a0e8308
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
https://android-review.googlesource.com/2348589
Branch: androidx-main
commit 7e514a1106d3ddf9d4d583f879bb0c1b34c27b28
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Dec 13 07:45:53 2022
Some marquee polish.
Follow-up to aops/2334291.
Cleans up some of the implementation code, and allows some properties to
be updated without recreating the whole modifier instance, addresses
some nits from the initial CL, and adds some tests.
Bug:
Test: BasicMarqueeTest
Relnote: n/a
Change-Id: I5b8091a396f72c5d81f28e4fd846d9452a0e8308
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
na...@google.com <na...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.4.0-alpha04
ph...@lu.ma <ph...@lu.ma> #9
Can we have some state for this modifier, so we know if content fits the container or it's gonna be animated? To match XML attribute behaviour, I'd like to draw gradient edges, but I don't need them in case content doesn't animate.
jo...@google.com <jo...@google.com> #10
I created a feature request for this:
Description
- Maybe it is another widget (i.e. MarqueeText or SlidingText)
- Depends on Animation, should be done via existing compose animation framework.