Text Marquee [139321650]

Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Aug 13, 2019 02:09AM

- We do not want to repeat the android structure and embed the marquee in the text widget.
- Maybe it is another widget (i.e. MarqueeText or SlidingText)
- Depends on Animation, should be done via existing compose animation framework.

Comments

si...@google.com <si...@google.com> #2Feb 4, 2020 02:41AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

si...@google.com <si...@google.com> May 26, 2020 01:47AM

Assigned to an...@google.com.

kl...@google.com <kl...@google.com> #3Jan 4, 2022 08:05PM

Accepted by kl...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

kl...@google.com <kl...@google.com> #4Jan 7, 2022 10:58PM

Design doc: https://docs.google.com/document/d/11-TD-Cr6_luQYztmOHNFUiOKGzZLKYgD9Zx0yjkyb74/edit?resourcekey=0-Z13UmPVZQVE2Z0pRs6-HoA

st...@google.com <st...@google.com> #5Jun 15, 2022 11:08AM

Related to b/185418980

ap...@google.com <ap...@google.com> #6Dec 13, 2022 11:23PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 3e74e5ef9d8e4ab6c599c95fcc510fae230c2470
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Dec 07 19:54:49 2022

Introduce marquee modifier.

Unlike my first attempt at this, aosp/1931284, this time I tried to copy
the simplicity and behavior of the platform behavior as closely as
possible, with the simplest implementation possible.

However, like with that first attempt, this modifier can be used on
anything, not just text.

The modifier uses defaults that match the behavior of the platform, with
limited customization options for repitition count, speed, delay, and
spacing. This should solve all of the use cases of the platform feature,
and if we need to build something more complex we can do that later.

This implementation does not support content that accepts pointer events
or other input. I checked the platform implementation and it also
doesn't handle this well (e.g. if the text has a clickable link in it,
the link is only clickable at certain points in the animation and not
where it's rendered).

Fixes:

b/139321650

Test: BasicMarqueeTest
Relnote: "Introduce experimental `Modifier.basicMarquee()` for displaying
content with a scrolling marquee effect."
Change-Id: I2df44c3343afa8400b0da768a642b77da94c103d

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/BasicMarqueeDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/samples/build.gradle
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BasicMarqueeSamples.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt

https://android-review.googlesource.com/2334291

ap...@google.com <ap...@google.com> #7Dec 14, 2022 02:16AM

Project: platform/frameworks/support
Branch: androidx-main

commit 7e514a1106d3ddf9d4d583f879bb0c1b34c27b28
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Dec 13 07:45:53 2022

Some marquee polish.

Follow-up to aops/2334291.

Cleans up some of the implementation code, and allows some properties to
be updated without recreating the whole modifier instance, addresses
some nits from the initial CL, and adds some tests.

Bug:

b/139321650

Test: BasicMarqueeTest
Relnote: n/a
Change-Id: I5b8091a396f72c5d81f28e4fd846d9452a0e8308

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt

https://android-review.googlesource.com/2348589

na...@google.com <na...@google.com> #8Jan 11, 2023 08:12PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.4.0-alpha04

ph...@lu.ma <ph...@lu.ma> #9Feb 1, 2023 08:47AM

Can we have some state for this modifier, so we know if content fits the container or it's gonna be animated? To match XML attribute behaviour, I'd like to draw gradient edges, but I don't need them in case content doesn't animate.

jo...@google.com <jo...@google.com> #10Feb 8, 2023 01:20PM

I created a feature request for this: https://issuetracker.google.com/268320333. Please add any information to that feature request instead of here!