Status Update
No update yet.
Comments
si...@google.com
First of all thanks for this detailed issue.
This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.
The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.
Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.
si...@google.com
si...@google.com
di...@google.com
Or is that option not available?
Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.
di...@google.com Restricted
di...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <
Link:
Fix POBox keyboard issue
Expand for full commit details
Fix POBox keyboard issue
Fix: 373743376
Fix: 329209241
Test: NullableInputConnectionWrapperTest
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt - M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt
Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024
ju...@gmail.com
Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.
no...@gmail.com
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.
se...@google.com
Yes, this fix is planned to be included in a future 1.7.x release.
se...@google.com
Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.
bu...@google.com
br...@gmail.com
+1 🙏
ap...@google.com
Branch: androidx-main
commit 358ce0cf2083f6d0e2e2a0897c860a6c1b71b514
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Nov 07 15:37:22 2022
Support for EmojiCompat in Compose
Add support for EmojiCompat for all Text and TextField in compose
This adds support for EmojiCompat to all Compose based applications.
EmojiCompat configuration must be done outside of Compose, and the global EmojiCompat config will be used.
This change enables automatic configuration of EmojiCompat to compose :ui:ui-text, similar to the configuration in appcompat.
Apps that wish to configure emojicompat monually should continue to disable [EmojiCompatIniitalizer] in their manifest.
Changes:
* Text, BasicText, *TextField, BasicTextField will all now call EmojiCompat.process as needed
* If EmojiCompat loads the font after a Paragraph or MultiParagraph is create, [hasStaleReslovedFonts] will become true
Bug:
Test: ./gradlew :com:ui:ui-text:cAT
Relnote: "Added EmojiCompat to Compose"
Change-Id: Ibf6f9f9d37c6280fe1b051269b127f0dfb1d6b6a
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/EmojiCompatDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/build.gradle
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphIntrinsicsTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/EmojiCompatStatusTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphIntrinsics.android.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/EmojiCompatStatus.kt
ap...@google.com
Branch: androidx-main
commit e5c660680805acb637b7a8b7ee26ba168562ef1f
Author: zzeng <zzeng@google.com>
Date: Mon Nov 21 16:08:50 2022
Let EmojiCompat supports returning emoji boundaries.
This is part of the effort to make Compose Apps use EmojiCompat to determine cursor movement or deletion.
Bug:
Test: ./gradlew :emoji2:emoji2:cAT
Relnote: "Added EmojiCompat to Compose"
Change-Id: I96f37bd992fc8cf305e4cb5e3bbe9ea3be19e52b
M emoji2/emoji2/api/current.txt
M emoji2/emoji2/api/public_plus_experimental_current.txt
M emoji2/emoji2/api/restricted_current.txt
M emoji2/emoji2/src/androidTest/java/androidx/emoji2/text/EmojiProcessorTest.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/EmojiCompat.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/EmojiProcessor.java
ap...@google.com
Branch: androidx-main
commit 42039d57d8357094bdacb901d28689ba55b99d92
Author: zzeng <zzeng@google.com>
Date: Fri Dec 02 15:34:12 2022
Support for EmojiCompat in Compose
Add support for cursor movement and deletion by EmojiCompat in Compose.
Bug: 139326806
Test: NA
Change-Id: I34773512ffbfaddbd796e8b9c33447e114b9a651
M compose/foundation/foundation/build.gradle
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/StringHelpers.android.kt
M settings.gradle
ap...@google.com
Branch: androidx-main
commit 5f032489693eed2771265c47da815a908b4a06fb
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Dec 08 14:54:39 2022
Add EmojiCompat editorInfo when configured
Bug:
Test: ./gradlew :com:ui:ui:cAT
Change-Id: Ic121f989d549309058c36fd54fd3caa50f23f172
M compose/ui/ui/build.gradle
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/TextInputServiceAndroidEmojiTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroid.android.kt
ap...@google.com
Branch: androidx-main
commit 5b20374ecd983e5078f8ea6852ae60888d2007e4
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Dec 15 15:56:42 2022
PlatformParagraphStyle to disable emoji processing for a Paragraph.
Fixes:
Test: ./gradlew :com:ui:ui-text:cAT
Relnote: "Add PlatformTextStyle(emojiSupportMatch) to optionally disable emoji support processing for a single Paragraph."
Change-Id: Ia710096395ecfe4bbd986326882331e0a7e6a74d
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/PlatformParagraphStyleTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/PlatformTextStyleTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphIntrinsicsTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidTextStyle.android.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/EmojiSupportMatch.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphIntrinsics.android.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.4.0-alpha04androidx.compose.ui:ui:1.4.0-alpha04androidx.compose.ui:ui-text:1.4.0-alpha04androidx.emoji2:emoji2:1.3.0-alpha01
Description
No description yet.