Fixed
Status Update
Comments
ra...@google.com <ra...@google.com> #2
This is being done because previously ListenableWorker's would transition to FAILED when a WorkerFactory would return used instances of ListenableWorkers.
This was a silent failure, and not easy to diagnose.
This should have always been an exception, and should have crashed the app instead.
This was a silent failure, and not easy to diagnose.
This should have always been an exception, and should have crashed the app instead.
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 2114e28ad291adc12d4ea9bd4038a211daec16b8
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Fri Aug 16 15:26:16 2019
Ensure that the instance of ListenableWorker being returned by WorkerFactory is not used.
* Throw an IllegalStateException when that happens.
* Update a unit test.
Test: Unit tests pass.
Fixes: b/139554406
Change-Id: If86d2ecc15b41a6d5dce8332f9c2d886193a5999
M work/workmanager/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/workmanager/src/main/java/androidx/work/WorkerFactory.java
https://android-review.googlesource.com/1104369
https://goto.google.com/android-sha1/2114e28ad291adc12d4ea9bd4038a211daec16b8
Branch: androidx-master-dev
commit 2114e28ad291adc12d4ea9bd4038a211daec16b8
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Fri Aug 16 15:26:16 2019
Ensure that the instance of ListenableWorker being returned by WorkerFactory is not used.
* Throw an IllegalStateException when that happens.
* Update a unit test.
Test: Unit tests pass.
Fixes:
Change-Id: If86d2ecc15b41a6d5dce8332f9c2d886193a5999
M work/workmanager/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/workmanager/src/main/java/androidx/work/WorkerFactory.java
Description