Make FragmentContainerView Final [140133091]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 27, 2019 10:49PM

FragmentContainerView should have originally been made final, but could not because of the need to verify behavior in test.

Those tests should be rewritten so that FragmentContainerView can be final.

Comments

jb...@google.com <jb...@google.com> #2Aug 28, 2019 04:42PM

Status: Assigned (reopened)

This has been fixed internally and will be available in the Fragment 1.2.0-alpha03 release.

ap...@google.com <ap...@google.com> #3Aug 28, 2019 05:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8b13acf30442b20323b7eaa10f5f3d46392406fb
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Aug 27 15:49:43 2019

Make FragmentContainerView final

Extending FragmentContainerView should not be supported. The tests that
needed to use an extended version of FragmentContainerView have been
rewritten.

Test: All tests pass
BUG: 140133091
Change-Id: Id614f680f5108d8a98c11274001a50f019d088c5

M fragment/fragment/api/1.2.0-alpha03.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/restricted_1.2.0-alpha03.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/androidTest/res/layout/fragment_container_view.xml
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java

https://android-review.googlesource.com/1109794

https://goto.google.com/android-sha1/8b13acf30442b20323b7eaa10f5f3d46392406fb

jb...@google.com <jb...@google.com> Aug 28, 2019 05:26PM

Marked as fixed.

Issue 140133091

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Aug 28, 2019 04:42PM

ap...@google.com <ap...@google.com> #3Aug 28, 2019 05:26PM

jb...@google.com <jb...@google.com> Aug 28, 2019 05:26PM

Add comment

Issue metadata