Fixed
Status Update
Comments
cu...@google.com <cu...@google.com>
cu...@google.com <cu...@google.com> #2
A couple of questions:
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
ap...@google.com <ap...@google.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
Description
Thanks for the update, but I think there's bug in the canAuthenticate() method as it does not return proper error code on APIs < 23.
It returns BiometricManager.BIOMETRIC_ERROR_HW_UNAVAILABLE which according to comment is "The hardware is unavailable. Try again later."
Shouldn't it return BiometricManager.BIOMETRIC_ERROR_NO_HARDWARE in this case?
ERROR_HW_UNAVAILABLE generally means the device supports fingerprint, but the HAL is crashed (or things along those lines). We should return ERROR_NO_HW
/**
* The hardware is unavailable. Try again later.
*/
int ERROR_HW_UNAVAILABLE = 1;
/**
* The device does not have a biometric sensor.
*/
int ERROR_HW_NOT_PRESENT = 12;