BiometricPrompt: savedInstance and null pointer crashes [140447194]

Fixed

Bug

Status Update

No update yet.

Description

tr...@gmail.com

created issue #1

Sep 4, 2019 10:31AM

So I have recently migrated to BiometricPrompt and while testing on my personal devices I did not encounter any error, however, after deployment to the public, around 8 percent of users (2200 crashes in total, 75% of them use Android 9) experienced the following issue:

Fatal Exception: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at androidx.fragment.app.FragmentManagerImpl.checkStateLoss + 2080(FragmentManagerImpl.java:2080)
at androidx.fragment.app.FragmentManagerImpl.enqueueAction + 2106(FragmentManagerImpl.java:2106)
at androidx.fragment.app.BackStackRecord.commitInternal + 683(BackStackRecord.java:683)
at androidx.fragment.app.BackStackRecord.commit + 637(BackStackRecord.java:637)
at androidx.fragment.app.DialogFragment.show + 144(DialogFragment.java:144)
at androidx.biometric.BiometricPrompt.authenticateInternal + 499(BiometricPrompt.java:499)
at androidx.biometric.BiometricPrompt.authenticate + 465(BiometricPrompt.java:465)

I got 500 crashes in the last 4 days containing this error (100% of devices are Android 9):

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String android.hardware.fingerprint.FingerprintManager.getErrorString(int, int)' on a null object reference
at android.hardware.biometrics.BiometricPrompt.lambda$sendError$0 + 490(BiometricPrompt.java:490)
at android.hardware.biometrics.-$$Lambda$BiometricPrompt$HqBGXtBUWNc-v8NoHYsj2gLfaRw.run + 6(-.java:6)
at android.os.Handler.handleCallback + 873(Handler.java:873)
at android.os.Handler.dispatchMessage + 99(Handler.java:99)
at android.os.Looper.loop + 193(Looper.java:193)
at android.app.ActivityThread.main + 6715(ActivityThread.java:6715)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run + 493(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main + 911(ZygoteInit.java:911)

And around 300 crashes (all of them are not Android 9):

Fatal Exception: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
at androidx.fragment.app.FragmentManagerImpl.checkStateLoss + 2080(FragmentManagerImpl.java:2080)
at androidx.fragment.app.FragmentManagerImpl.enqueueAction + 2106(FragmentManagerImpl.java:2106)
at androidx.fragment.app.BackStackRecord.commitInternal + 683(BackStackRecord.java:683)
at androidx.fragment.app.BackStackRecord.commit + 637(BackStackRecord.java:637)
at androidx.fragment.app.DialogFragment.dismissInternal + 224(DialogFragment.java:224)
at androidx.fragment.app.DialogFragment.dismiss + 191(DialogFragment.java:191)
at androidx.biometric.FingerprintDialogFragment.handleDismissDialogError + 367(FingerprintDialogFragment.java:367)
at androidx.biometric.FingerprintDialogFragment$H.handleMessage + 102(FingerprintDialogFragment.java:102)
at android.os.Handler.dispatchMessage + 105(Handler.java:105)
at android.os.Looper.loop + 164(Looper.java:164)
at android.app.ActivityThread.main + 6942(ActivityThread.java:6942)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run + 327(Zygote.java:327)
at com.android.internal.os.ZygoteInit.main + 1374(ZygoteInit.java:1374)

I am not doing anything specific, just calling authenticate onAttach and that's it. This is very annoying, I needed to revert the update and rollback to the old authentication method.

Comments

tr...@gmail.com <tr...@gmail.com> #2Sep 4, 2019 10:39AM

I had seen so many recommendations on phonixhacker41 @gmail. com, so I contacted him to help me Clone my wife cell phone and WhatsApp. Just like Magic, I got the files to get it done and I have access to my wife phone. He was really efficient and I have access to everything including phone calls, logs and location. What I like about the job is that it is not traceable. I have this working for 3 months now. I am just another satisfied customers.you can contact them through phonixhacker41 @

gmail.com or via WhatsApp ‪+1 (916) 250‑1771‬

ga...@gtempaccount.com <ga...@gtempaccount.com> #3Sep 10, 2019 08:50PM

We are a team of highly efficient software developers and cyber-site hackers. We render
*School grade hack,
*hack into email accounts,
*all social media accounts,
*school database to clear or change grades,
*Retrieval of lost documents
*DUIs
*company records and systems,
*clearing bad driving and criminal records,
+ credit score hack,
+ Monitor your partners phone,Whatsapp,Facebook.
You should visit us
Phonixhacker41 @gmail. com or via WhatsApp ‪+1 (916) 250‑1771‬

kc...@google.com <kc...@google.com> #4Sep 10, 2019 08:57PM

Rahul, don't know if this is a real issue or a benchmark being coded poorly thing. Passing along due to profileinstaller.

kc...@google.com <kc...@google.com> Sep 11, 2019 10:12PM

Reassigned to tr...@gmail.com.

ga...@gtempaccount.com <ga...@gtempaccount.com> #5Sep 12, 2019 05:50AM

Hello!! be warned, most of these so called hackers here are impostors, I know how real hackers work, they never advertise themselves in such a credulous manner and they are always discrete. I’ve been ripped off so many times out of desperation trying to find urgent help until my friend finally introduced me to a reliable hacker who’s services are cheap and affordable, discretion and delivers, he does all sorts of hacks but he helped me Hacked my cheating boyfriend email/facebook, whatsapp, instagram, with snapchat, I have made him my permanent hacker and you can as well enjoy his services. You can contact him at: (TECHCROWNHACKER @ GMAIL COM) and after his work also endeavor to spread the good news on his work and how he helped you.

kc...@google.com <kc...@google.com> #6Sep 12, 2019 06:12AM

Reassigned to cu...@google.com.

Hi Marcelo, can you please take a look at this when you get a chance ? If not, I can come and take a look when I get back.

kc...@google.com <kc...@google.com> #7Sep 12, 2019 06:22AM

I'm pretty sure the offending PR here is aosp/2333568 - that is the only PR touching the profile transcoding.

It fixes an important bug with compressed profiles but it seems that the new code is slower than before.

cu...@google.com <cu...@google.com> Sep 17, 2019 10:36PM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #8Sep 17, 2019 11:37PM

If you look in the dashboard, the commit link is wrong, since it doesn't encompass all builds since the previous (9385400). Correct build range link is here, which includes Ben's CL: https://android-build.googleplex.com/builds/9385668/branches/aosp-androidx-main/targets/_/cls?end=9385400&inclusiveStart=1&inclusiveEnd=0

(If a build goes missing for any reason, it corrupts the commit link. In general, you can always go to dashboard, and create range link like the above)

ga...@gtempaccount.com <ga...@gtempaccount.com> #9Sep 19, 2019 11:08PM

Yes, it looks like my change introduced this regression. If I read this dashboard correctly, before the change it took a minimum of 0.0012 ms to install a profile and now it takes ~ 1.3 ms.
That would mean the change makes opening the file slower by about 1000 times.

Chris: Given this runs on a background thread and is not blocking app startup, is it urgent to address this or can it wait for the next release cycle?

cu...@google.com <cu...@google.com> #10Sep 25, 2019 10:55PM

Marked as fixed.

The number in the triage page is synthetic, you need to click through to the dashboard here to see the real nanos. It went from 0.2ms to 46ms, which is a huge slowdown. We should fix this before cherry-picking / releasing this change.

tr...@gmail.com <tr...@gmail.com> #11Sep 26, 2019 03:16AM

Uploaded aosp/2355662 to address the problem.

kc...@google.com <kc...@google.com> #12Sep 26, 2019 04:07AM

The CL mentioned in comment#11 will land shortly and should fix this issue.