Fixed
Status Update
Comments
kc...@google.com <kc...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 32e15d7e6a58276987c27730dcc01ecfb950d2db
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:07:46 2024
Convert `lifecycle-runtime-compose` to multiplatform
* Only platforms supported by Compose in the AndroidX repository will be supported by `lifecycle-runtime-compose` (`android`, `desktop`).
* That is equivalent to what has been done with other artifacts, such as `lifecycle-viewmodel-compose`.
* Credits to Jake Wharton for the original contribution, his CL can be found at aosp/3002225
Test: `gw -p lifecycle bOS`
RelNote: "Added multiplatform support for `lifecycle-runtime-compose`."
Bug: 331769623
Change-Id: I4f4a03613120f3222bd44ae1feab1a085ddb38da
M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-runtime-compose/build.gradle
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/CollectAsStateWithLifecycleTests.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/DropUnlessLifecycleTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleEffectTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleExtTest.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/DropUnlessLifecycle.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/FlowExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleEffect.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.kt
https://android-review.googlesource.com/3017203
Branch: androidx-main
commit 32e15d7e6a58276987c27730dcc01ecfb950d2db
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:07:46 2024
Convert `lifecycle-runtime-compose` to multiplatform
* Only platforms supported by Compose in the AndroidX repository will be supported by `lifecycle-runtime-compose` (`android`, `desktop`).
* That is equivalent to what has been done with other artifacts, such as `lifecycle-viewmodel-compose`.
* Credits to Jake Wharton for the original contribution, his CL can be found at aosp/3002225
Test: `gw -p lifecycle bOS`
RelNote: "Added multiplatform support for `lifecycle-runtime-compose`."
Bug: 331769623
Change-Id: I4f4a03613120f3222bd44ae1feab1a085ddb38da
M docs-tip-of-tree/build.gradle
M lifecycle/lifecycle-runtime-compose/build.gradle
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/CollectAsStateWithLifecycleTests.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/DropUnlessLifecycleTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleEffectTest.kt
M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleExtTest.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/DropUnlessLifecycle.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/FlowExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleEffect.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleExt.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LocalLifecycleOwner.kt
vi...@gmail.com <vi...@gmail.com>
kc...@google.com <kc...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 195d70fcd1b8d7dea6820e1795584e29e7535c84
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:14:40 2024
Add `lifecycle-runtime-ktx` in `lifecycle-runtime-compose`
* Constraints do not apply to project dependencies, causing `wear:compose:demos` to fail due to a transitive dependency on an older ``-ktx` library. This results in duplicate definitions.
* Workaround: Added a direct dependency on `lifecycle-runtime-ktx`. Although this artifact is empty, it ensures that upgrading `lifecycle-runtime-compose` also updates `lifecycle-runtime-ktx` in cases where our constraints fail (e.g., internally in AndroidX when using project dependencies).
Test: `./gradlew :wear:compose:integration-tests:demos:dataBindingMergeDependencyArtifactsDebugAndroidTest`
Test: `./gradlew :compose:ui:ui-test:compileDebugKotlinAndroid`
Bug: 331769623
Change-Id: I8e79f3d5a7b6586dac65ae4c7d3868d9518ee585
M lifecycle/lifecycle-runtime-compose/build.gradle
https://android-review.googlesource.com/3017204
Branch: androidx-main
commit 195d70fcd1b8d7dea6820e1795584e29e7535c84
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Mar 28 11:14:40 2024
Add `lifecycle-runtime-ktx` in `lifecycle-runtime-compose`
* Constraints do not apply to project dependencies, causing `wear:compose:demos` to fail due to a transitive dependency on an older ``-ktx` library. This results in duplicate definitions.
* Workaround: Added a direct dependency on `lifecycle-runtime-ktx`. Although this artifact is empty, it ensures that upgrading `lifecycle-runtime-compose` also updates `lifecycle-runtime-ktx` in cases where our constraints fail (e.g., internally in AndroidX when using project dependencies).
Test: `./gradlew :wear:compose:integration-tests:demos:dataBindingMergeDependencyArtifactsDebugAndroidTest`
Test: `./gradlew :compose:ui:ui-test:compileDebugKotlinAndroid`
Bug: 331769623
Change-Id: I8e79f3d5a7b6586dac65ae4c7d3868d9518ee585
M lifecycle/lifecycle-runtime-compose/build.gradle
cu...@google.com <cu...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 49455ad0e53fd704ca5a3c56d5b621f666d3d7b9
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Mar 29 14:38:40 2024
Fix corrupt serialized resolution result in `compose-ui`
* `compose-ui` has a transitive dependency on `lifecycle-livedata-core`, and converting `lifecycle-runtime-compose` to KMP triggered a Gradle bug (https://github.com/gradle/gradle/issues/14220 ).
* Directly adding `lifecycle-livedata-core` as `compileOnly` to `androidMain` allowed us to workaround the issue.
Test: `./gradlew :compose:ui:ui:compileCommonMainKotlinMetadata -Pandroidx.constraints=true`
Bug: 331769623
Change-Id: I463276189cf90cfca8efc46bb29ecbb64010e09e
M compose/ui/ui/build.gradle
https://android-review.googlesource.com/3020183
Branch: androidx-main
commit 49455ad0e53fd704ca5a3c56d5b621f666d3d7b9
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Mar 29 14:38:40 2024
Fix corrupt serialized resolution result in `compose-ui`
* `compose-ui` has a transitive dependency on `lifecycle-livedata-core`, and converting `lifecycle-runtime-compose` to KMP triggered a Gradle bug (
* Directly adding `lifecycle-livedata-core` as `compileOnly` to `androidMain` allowed us to workaround the issue.
Test: `./gradlew :compose:ui:ui:compileCommonMainKotlinMetadata -Pandroidx.constraints=true`
Bug: 331769623
Change-Id: I463276189cf90cfca8efc46bb29ecbb64010e09e
M compose/ui/ui/build.gradle
cu...@google.com <cu...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit e48e6e2ce836e4e76a4bb6abe912520282fccf75
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Mar 29 17:03:31 2024
Add `lifecycle-runtime-ktx` in `lifecycle-runtime-compose`
* Constraints do not apply to project dependencies, causing `wear:compose:demos` to fail due to a transitive dependency on an older ``-ktx` library. This results in duplicate definitions.
* Workaround: Added a direct dependency on `lifecycle-runtime-ktx`. Although this artifact is empty, it ensures that upgrading `lifecycle-runtime-compose` also updates `lifecycle-runtime-ktx` in cases where our constraints fail (e.g., internally in AndroidX when using project dependencies).
Test: `./gradlew :wear:compose:integration-tests:demos:dataBindingMergeDependencyArtifactsDebugAndroidTest`
Test: `./gradlew :compose:ui:ui-test:compileDebugKotlinAndroid`
Bug: 331769623
Change-Id: I5599212b8a2dbd83189886a2435068b7b4aa5e1c
M lifecycle/lifecycle-runtime-compose/build.gradle
https://android-review.googlesource.com/3020185
Branch: androidx-main
commit e48e6e2ce836e4e76a4bb6abe912520282fccf75
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Mar 29 17:03:31 2024
Add `lifecycle-runtime-ktx` in `lifecycle-runtime-compose`
* Constraints do not apply to project dependencies, causing `wear:compose:demos` to fail due to a transitive dependency on an older ``-ktx` library. This results in duplicate definitions.
* Workaround: Added a direct dependency on `lifecycle-runtime-ktx`. Although this artifact is empty, it ensures that upgrading `lifecycle-runtime-compose` also updates `lifecycle-runtime-ktx` in cases where our constraints fail (e.g., internally in AndroidX when using project dependencies).
Test: `./gradlew :wear:compose:integration-tests:demos:dataBindingMergeDependencyArtifactsDebugAndroidTest`
Test: `./gradlew :compose:ui:ui-test:compileDebugKotlinAndroid`
Bug: 331769623
Change-Id: I5599212b8a2dbd83189886a2435068b7b4aa5e1c
M lifecycle/lifecycle-runtime-compose/build.gradle
Description
- A bugreport immediately after the issue occurs.
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).
BUILD INFO
- Device type: Samsung S9+, Pixel 3 Emulator
- OS version: 28, 29
- Biometric library version: androidx.biometric:biometric:1.0.0-beta01
STEPS TO REPRODUCE
Test: (1) Pixel 3 emulator with API 29 (2) Samsung S9+ with API 28
1. Ensure a fingerprint is enrolled for the device
2. Install and launch the biometric demo app (with new dep)
3. Host in an activity
EXPECTED RESULTS
Fingerprint dialog should be shown
OBSERVED RESULTS
No fingerprint dialog is shown and app crashes with below error
NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE: 10/10
Crash log:
09-04 14:54:44.717 9394 9394 E AndroidRuntime: FATAL EXCEPTION: main
09-04 14:54:44.717 9394 9394 E AndroidRuntime: java.lang.BootstrapMethodError: Exception from call site #3 bootstrap method
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricFragment.<init>(BiometricFragment.java:86)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricFragment.newInstance(BiometricFragment.java:187)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricPrompt.authenticateInternal(BiometricPrompt.java:681)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricPrompt.authenticate(BiometricPrompt.java:658)