Authenticating with AndroidX biometric latest version causes crash [140508526]

Fixed

Bug

Status Update

No update yet.

Description

vi...@gmail.com

created issue #1

Sep 4, 2019 11:46PM

If this is a bug in the library, we would appreciate if you could attach:
- A bugreport immediately after the issue occurs.
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

BUILD INFO
- Device type: Samsung S9+, Pixel 3 Emulator
- OS version: 28, 29
- Biometric library version: androidx.biometric:biometric:1.0.0-beta01

STEPS TO REPRODUCE
Test: (1) Pixel 3 emulator with API 29 (2) Samsung S9+ with API 28

1. Ensure a fingerprint is enrolled for the device
2. Install and launch the biometric demo app (with new dep)
3. Host in an activity

EXPECTED RESULTS
Fingerprint dialog should be shown

OBSERVED RESULTS
No fingerprint dialog is shown and app crashes with below error

NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE: 10/10

Crash log:

09-04 14:54:44.717 9394 9394 E AndroidRuntime: FATAL EXCEPTION: main
09-04 14:54:44.717 9394 9394 E AndroidRuntime: java.lang.BootstrapMethodError: Exception from call site #3 bootstrap method
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricFragment.<init>(BiometricFragment.java:86)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricFragment.newInstance(BiometricFragment.java:187)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricPrompt.authenticateInternal(BiometricPrompt.java:681)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricPrompt.authenticate(BiometricPrompt.java:658)

Comments

kc...@google.com <kc...@google.com> #2Sep 5, 2019 12:41AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

vi...@gmail.com <vi...@gmail.com> Sep 5, 2019 02:59AM

SampleBiometricApp.zip

134 KB

Download

biometric_crash_issue.zip

11 MB

Download

kc...@google.com <kc...@google.com> #3Sep 5, 2019 03:09AM

Reassigned to cu...@google.com.

Curtis, is this caused by aosp/1097713?

cu...@google.com <cu...@google.com> Sep 5, 2019 05:04PM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #4Sep 7, 2019 01:35AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d8b9a4d638bb116533b3921e9984cdf3ba833903
Author: Curtis Belmonte <curtislb@google.com>
Date: Thu Sep 05 10:21:10 2019

Remove Java 8 lambdas and method refs from biometric

Using Java 8 features such as method refs and lambdas can cause
compatibility issues with some apps, resulting in runtime crashes. These
crashes aren't worth the added syntactic sugar of lambdas, so this
commit replaces all instances in the biometric library with equivalent
anonymous classes. It also sets the language level version of the
library to Java 7 to avoid inadvertent future regressions.

Test: ./gradlew biometric:connectedAndroidTest
Test: Launch SampleBiometricApp (from bug report) and press authenticate

Before: App crashes with BootstrapMethodError
After: App no longer crashes and authentication works as normal

Fixes: 140508526
Change-Id: I6aeeb9a860f6ba54539ed459e0fd7e7a058eddd7

M biometric/build.gradle
M biometric/src/androidTest/java/androidx/biometric/DeviceCredentialHandlerBridgeTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java

https://android-review.googlesource.com/1116272

https://goto.google.com/android-sha1/d8b9a4d638bb116533b3921e9984cdf3ba833903

cu...@google.com <cu...@google.com> #5Sep 7, 2019 01:35AM

Fixed by aosp/1116272

Issue 140508526