Fixed
Status Update
No update yet.
Comments
kc...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
vi...@gmail.com
kc...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
cu...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d8b9a4d638bb116533b3921e9984cdf3ba833903
Author: Curtis Belmonte <curtislb@google.com>
Date: Thu Sep 05 10:21:10 2019
Remove Java 8 lambdas and method refs from biometric
Using Java 8 features such as method refs and lambdas can cause
compatibility issues with some apps, resulting in runtime crashes. These
crashes aren't worth the added syntactic sugar of lambdas, so this
commit replaces all instances in the biometric library with equivalent
anonymous classes. It also sets the language level version of the
library to Java 7 to avoid inadvertent future regressions.
Test: ./gradlew biometric:connectedAndroidTest
Test: Launch SampleBiometricApp (from bug report) and press authenticate
Before: App crashes with BootstrapMethodError
After: App no longer crashes and authentication works as normal
Fixes: 140508526
Change-Id: I6aeeb9a860f6ba54539ed459e0fd7e7a058eddd7
M biometric/build.gradle
M biometric/src/androidTest/java/androidx/biometric/DeviceCredentialHandlerBridgeTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java
https://android-review.googlesource.com/1116272
https://goto.google.com/android-sha1/d8b9a4d638bb116533b3921e9984cdf3ba833903
Branch: androidx-master-dev
commit d8b9a4d638bb116533b3921e9984cdf3ba833903
Author: Curtis Belmonte <curtislb@google.com>
Date: Thu Sep 05 10:21:10 2019
Remove Java 8 lambdas and method refs from biometric
Using Java 8 features such as method refs and lambdas can cause
compatibility issues with some apps, resulting in runtime crashes. These
crashes aren't worth the added syntactic sugar of lambdas, so this
commit replaces all instances in the biometric library with equivalent
anonymous classes. It also sets the language level version of the
library to Java 7 to avoid inadvertent future regressions.
Test: ./gradlew biometric:connectedAndroidTest
Test: Launch SampleBiometricApp (from bug report) and press authenticate
Before: App crashes with BootstrapMethodError
After: App no longer crashes and authentication works as normal
Fixes: 140508526
Change-Id: I6aeeb9a860f6ba54539ed459e0fd7e7a058eddd7
M biometric/build.gradle
M biometric/src/androidTest/java/androidx/biometric/DeviceCredentialHandlerBridgeTest.java
M biometric/src/main/java/androidx/biometric/BiometricFragment.java
M biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
M biometric/src/main/java/androidx/biometric/FingerprintHelperFragment.java
cu...@google.com
Fixed by aosp/1116272
Description
- A bugreport immediately after the issue occurs.
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).
BUILD INFO
- Device type: Samsung S9+, Pixel 3 Emulator
- OS version: 28, 29
- Biometric library version: androidx.biometric:biometric:1.0.0-beta01
STEPS TO REPRODUCE
Test: (1) Pixel 3 emulator with API 29 (2) Samsung S9+ with API 28
1. Ensure a fingerprint is enrolled for the device
2. Install and launch the biometric demo app (with new dep)
3. Host in an activity
EXPECTED RESULTS
Fingerprint dialog should be shown
OBSERVED RESULTS
No fingerprint dialog is shown and app crashes with below error
NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE: 10/10
Crash log:
09-04 14:54:44.717 9394 9394 E AndroidRuntime: FATAL EXCEPTION: main
09-04 14:54:44.717 9394 9394 E AndroidRuntime: java.lang.BootstrapMethodError: Exception from call site #3 bootstrap method
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricFragment.<init>(BiometricFragment.java:86)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricFragment.newInstance(BiometricFragment.java:187)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricPrompt.authenticateInternal(BiometricPrompt.java:681)
09-04 14:54:44.717 9394 9394 E AndroidRuntime: at androidx.biometric.BiometricPrompt.authenticate(BiometricPrompt.java:658)