Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1d4e6911dcf86c2b56d96037e56d0bbe4552732f
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 06 13:08:47 2019
Deprecate Fragment getFragmentManager and requireFragmentManager
GetFragmentManager() does not clearly define which FragmentManager is
being retrieved. Deprecating it (and requireFragmentManager()) in favor
of getParentFragmentManager() creates an explicit API so it is clear
that this method returns the FragmentManager that this Fragment is added to.
GetParentFragmentManager() must return a FragmentManager or an
IllegalStateException will be thrown, exactly like
requireFragmentManager().
Test: All tests pass
BUG: 140574496
Change-Id: I0981a7319feccd0bd951b8e37b2906be0fd91345
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioDialogFragmentTest.kt
M fragment/fragment/api/1.2.0-alpha04.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.2.0-alpha04.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.2.0-alpha04.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/PostponedTransitionTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/ReentrantFragmentTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLifecycleCallbacksDispatcher.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
https://android-review.googlesource.com/1115082
https://goto.google.com/android-sha1/1d4e6911dcf86c2b56d96037e56d0bbe4552732f
Branch: androidx-master-dev
commit 1d4e6911dcf86c2b56d96037e56d0bbe4552732f
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 06 13:08:47 2019
Deprecate Fragment getFragmentManager and requireFragmentManager
GetFragmentManager() does not clearly define which FragmentManager is
being retrieved. Deprecating it (and requireFragmentManager()) in favor
of getParentFragmentManager() creates an explicit API so it is clear
that this method returns the FragmentManager that this Fragment is added to.
GetParentFragmentManager() must return a FragmentManager or an
IllegalStateException will be thrown, exactly like
requireFragmentManager().
Test: All tests pass
BUG: 140574496
Change-Id: I0981a7319feccd0bd951b8e37b2906be0fd91345
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioDialogFragmentTest.kt
M fragment/fragment/api/1.2.0-alpha04.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.2.0-alpha04.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.2.0-alpha04.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/PostponedTransitionTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/ReentrantFragmentTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLifecycleCallbacksDispatcher.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java
jb...@google.com <jb...@google.com> #3
This has been added internally and will be available in the Fragment 1.2.0-alpha04 release.
Description