com.android.build.gradle.internal.tasks.MergeNativeLibsTask breaks remote build cache [140602655]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 6, 2019 06:59PM

AGP 3.5.0
Gradle 5.6.2

The task com.android.build.gradle.internal.tasks.MergeNativeLibsTask has a property named `projectNativeLibs` which has absolute-path normalization. This means the task cannot use the remote cache. See attached screenshot for what this looks like in a Gradle Enterprise build comparison.

I would expect that property to use a different normalization strategy. If the .so files are machine-dependent, then they shouldn't themselves be the input, but rather some version number or something. If the different native libraries produce different output, I would consider that a bug.

MergeNativeLibsTask-comparison.png

170 KB

View

Download

Comments

je...@google.com <je...@google.com> Sep 9, 2019 04:09PM

Assigned to st...@google.com.

[Deleted User] <[Deleted User]> #2Sep 9, 2019 04:10PM

Project: platform/frameworks/support
Branch: androidx-main

commit af364c3aef9d0f67629cbfda8ac80670031d8461
Author: Mihai Popa <popam@google.com>
Date: Fri Feb 04 14:19:55 2022

Add reverseLayout to LazyVerticalGrid

The CL also includes the changes of
Iba3e1689ee37948667dc2b8a7de06865465ab3f5, which were done only for
lists previously.

Relnote: LazyVerticalGrid now supports reverseLayout.
Fixes: 215572963
Bug: 211753558
Test: ran all tests in androidx.compose.foundation.lazy.grid
Change-Id: I6d7d7057318b873fc22b78a212480e1205ccb8c0

A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridsReverseLayoutTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridMeasure.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridsContentPaddingTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGrid.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyArrangementsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredLine.kt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGrid.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridLayoutInfoTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredItem.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridPrefetcherTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyMeasuredLineProvider.kt

https://android-review.googlesource.com/1972779

xa...@google.com <xa...@google.com> #3Feb 17, 2020 04:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit ff557be3f50e772a71a4e199e55129b251020d78
Author: Mihai Popa <popam@google.com>
Date: Tue Feb 08 13:13:43 2022

Remove obsolete OptIn annotations in LazyGridState

Bug: 211753558
Test: existing tests
Change-Id: I9ffa633155d7c242df877b584c60227c6598accf

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGridState.kt

https://android-review.googlesource.com/1976766

je...@google.com <je...@google.com> Mar 2, 2020 05:35PM

Reassigned to ji...@google.com.

ji...@google.com <ji...@google.com> Mar 9, 2020 08:49PM

Marked as fixed.

ga...@gradle.com <ga...@gradle.com> #4Mar 26, 2020 11:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3d133f1208c0c2936b620e3940d6b61cb50b9ef5
Author: Mihai Popa <popam@google.com>
Date: Tue Feb 15 20:48:28 2022

Improve Lazy grids animateScrollToItem

Similar to I7c655d025e9e0a716b8b8dfba36117e043a529c7 and
Ie55adbd9d360c46362e96d125777e70e5c4334c6.

1) Start using expected distance to the item based on the average lines
size instead of just starting an animation to a fixed large offset.
This works better when the target item is close to the original
state, especially when scrolling backward as we can easily overshot
as we stop this animation only once the target item became visible
2) Properly pass the velocity between different animations and their
lastFrameTimeNanos so the sequentialAnimation param start to work
properly(previously it was doing nothing). The simplest way is to
just use AnimationState.copy() when we need to reset the current
value.
3) Added proper per frame offset assertions which allows us to verify
that the animation behave as a proper spring() animation in the cases
when the item sizes are the same and when we don't need to scroll too
much so we fall back to the teleport
4) Fix LazyGridState.animateScrollToItem() skipping the item on slow
devices. It was possible that we go into a wrong if branch in the
scrolling logic when the overshoot happened and the list ended up
scrolled to the end instead of pointing to the needed element.

Test: new tests in LazyScrollTest
Bug: 211753558
Change-Id: Iacca7cc7a074700b7d88a0317d995d49699b2b16

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGridState.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyGridTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGrid.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyScrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridScrolling.kt

https://android-review.googlesource.com/1986826

ji...@google.com <ji...@google.com> #5Mar 27, 2020 07:09PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2c087945231b7650f0a4d34cc6b23d30c6aa2f93
Author: Mihai Popa <popam@google.com>
Date: Tue Feb 08 13:57:41 2022

Accept negative offsets in LazyGridState scrolling

Similar to Iceb907f268a19db3e9315154ebd136764ad975a3 for lists.

Relnote: Now it is allowed to pass negative scroll offsets into LazyGridState.scrollToItem() and LazyGridState.animateScrollToItem().
Test: LazyScrollTest
Bug: 211753558
Change-Id: I025c608ce2eef36f90ad657bba78229b62bcd725

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyGridState.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/grid/LazyScrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListState.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/grid/LazyGridScrollPosition.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/list/LazyScrollTest.kt

https://android-review.googlesource.com/1976767