[ViewPager2] Focus events causing ViewPager2 to unexpectedly the change page [140656866]

Fixed

Bug

Status Update

No update yet.

Description

ne...@gmail.com

created issue #1

Sep 8, 2019 06:50AM

It doesn't matter if the keyboard is being hidden from code (hideSoftInputFromWindow) or from user interface by hitting back button quickly enough while the page transition is in progress.

I've added the keyboard hiding to my previously used (another bug report) example

https://github.com/AlmightyCZ/ViewPager2TextInputGravity
To replicate the issue, switch to second page(FORM), focus the editText, leave the keyboard open and use the tab to switch to the third page(LAST). The ViewPager jumps to LAST page for a split second and then immediately back to FORM. If the keyboard is not showing, then the page changes happens without any problem.

Using View/Handler.post for hideKeyboard invocation doesn't change the outcome, only postDelayed with long enough delay "works".

Comments

je...@google.com <je...@google.com> #2Sep 13, 2019 11:02PM

Seems to be a DNS problem with systems that have 'obtain DNS server address automatically'. Changed my system to a manual setting and the browser etc now work. SDK 2.2 didn't seem to mind the auto setting though.

je...@google.com <je...@google.com> #3Sep 17, 2019 02:27PM

Could you please describe how/where you changed your system to a manual setting?

je...@google.com <je...@google.com> #4Sep 17, 2019 03:53PM

Based on its date, this issue was originally reported before Android 2.3. Because of the many changes that existed in Android 4.x compared to previous versions, it's very likely that this issue doesn't exist in recent versions of Android like 4.2.2 or newer. Because of the high likelihood that this issue is obsolete, it is getting closed automatically by a script, without a human looking at it in detail. If the issue still exists on a Nexus 4 or Nexus 7 running Android 4.2.2 and is not related to Google applications, please open a new report accordingly.

je...@google.com <je...@google.com> #5Sep 17, 2019 05:00PM

java.lang.IllegalArgumentException: Unable to locate adb
at com.android.tools.idea.run.editor.DeployTargetPickerDialog.<init>(DeployTargetPickerDialog.java:144)
at com.android.tools.idea.run.editor.ShowChooserTargetProvider.showPrompt(ShowChooserTargetProvider.java:113)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getDeployTarget(AndroidRunConfigurationBase.java:600)
at com.android.tools.idea.run.AndroidRunConfigurationBase.doGetState(AndroidRunConfigurationBase.java:281)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getState(AndroidRunConfigurationBase.java:241)
at com.intellij.execution.runners.ExecutionEnvironment.getState(ExecutionEnvironment.java:158)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:55)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:50)
at com.intellij.execution.ProgramRunnerUtil.executeConfigurationAsync(ProgramRunnerUtil.java:92)
at com.intellij.execution.ProgramRunnerUtil.executeConfiguration(ProgramRunnerUtil.java:41)
at com.intellij.execution.impl.ExecutionManagerImpl.restart(ExecutionManagerImpl.java:93)
at com.intellij.execution.impl.ExecutionManagerImpl.access$300(ExecutionManagerImpl.java:44)
at com.intellij.execution.impl.ExecutionManagerImpl$3.run(ExecutionManagerImpl.java:442)
at com.intellij.util.concurrency.QueueProcessor.runSafely(QueueProcessor.java:232)
at com.intellij.util.Alarm$Request.runSafely(Alarm.java:356)
at com.intellij.util.Alarm$Request.run(Alarm.java:343)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at com.intellij.util.concurrency.SchedulingWrapper$MyScheduledFutureTask.run(SchedulingWrapper.java:228)
at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:315)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:435)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:419)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:403)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
at java.awt.EventQueue.access$500(EventQueue.java:98)
at java.awt.EventQueue$3.run(EventQueue.java:715)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:755)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:704)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:391)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

ap...@google.com <ap...@google.com> #6Sep 19, 2019 06:47PM

voilà ce qu'on m'affiche lorsque j’exécute mon programme

jg...@google.com <jg...@google.com> Sep 20, 2019 01:41PM

Accepted by je...@google.com.

ap...@google.com <ap...@google.com> #7Sep 20, 2019 05:06PM

je ne vois pas comment résoudre ce problème. svp aidez moi

ap...@google.com <ap...@google.com> #8Sep 20, 2019 05:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d9000ec31ab4743ed07c8aa713d506ea57c37de2
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Sep 20 15:49:02 2019

Clear focus on page change in ViewPager2

Makes sure that a page can't keep focus when it is moving out of the
screen.

Bug: 140656866
Test: follow-up

Change-Id: I4e0fece0d4c438da76bfcb10939ba1bc880e27e7

M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java

https://android-review.googlesource.com/1126610

https://goto.google.com/android-sha1/d9000ec31ab4743ed07c8aa713d506ea57c37de2

jg...@google.com <jg...@google.com> #9Sep 30, 2019 02:08PM

Fixes are in place now. Will come out in the next release.

ti...@gmail.com <ti...@gmail.com> #10Oct 1, 2019 09:20AM

Any plan when the next release is?

jg...@google.com <jg...@google.com> #11Oct 2, 2019 01:46PM

We are aiming to release beta05 with the fix on October 9, but we are unable to make promises as it depends on other AndroidX libraries.

ti...@gmail.com <ti...@gmail.com> #12Oct 2, 2019 03:09PM

Thanks, that's somewhat useful.

an...@wpost.com <an...@wpost.com> #13Oct 10, 2019 12:35PM

It looks like this change has broken the ability to use DPAD_LEFT or DPAD_RIGHT navigation by setting items as focusable.

https://android-review.googlesource.com/c/platform/frameworks/support/+/1125359/

Is there a workaround? I can make a sample if needed, and perhaps a new issue. Thanks!

jg...@google.com <jg...@google.com> #14Oct 11, 2019 05:29PM

Marked as fixed.

Fix for the original issue is now out (released on Oct 9 with beta05). Marking as Fixed.

Regarding

comment#13

(DPAD_*) -- moving to

http://issuetracker.google.com/142548536

pa...@google.com <pa...@google.com> #15Jul 5, 2022 10:40PM

This is still happening for me (see screencast) and seems to be caused by: https://android-review.googlesource.com/c/platform/frameworks/support/+/1126151

In our code, we have viewpager.setFocusability(false) but a child view is focusable. This combination causes the offending code to be called and the next item to show up briefly:

if (hasFocus()) { // if clear focus did not succeed
  mRecyclerView.requestFocus(View.FOCUS_FORWARD);
}

Reading the commit history it looks like the above code was added for API < 28. Is it possible to check for both hasFocus() && API < 28 here?

ap...@google.com <ap...@google.com> #16Dec 11, 2023 07:12PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4e83b07b60706d954045f24b600338fae14abb2c
Author: Jakub Gielzak <jgielzak@google.com>
Date: Mon Sep 23 19:53:57 2019

Clear focus on page change on API < 28

Follow-up to: I4e0fece0d4c438da76bfcb10939ba1bc880e27e7

Bug: 140656866
Test: follow-up

Change-Id: I91bcd072e1812eeb20fbce6fb989557d60079bb7

M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java

https://android-review.googlesource.com/1126151