Transition cast issue [140680619]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 9, 2019 10:59AM

Component used: Navigation
Version used:2.2.0-alpha02
Devices/Android versions reproduced on: All

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.

https://github.com/android/animation/blob/master/Motion/README.md (Also on my production project)

2019-09-09 12:57:19.033 27253-27253/com.example.android.motion E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.android.motion, PID: 27253
java.lang.ClassCastException: androidx.transition.TransitionSet cannot be cast to android.transition.Transition
at androidx.fragment.app.FragmentTransition.setListenerForTransitionEnd(FragmentTransition.java:307)
at androidx.fragment.app.FragmentTransition.configureTransitionsReordered(FragmentTransition.java:258)
at androidx.fragment.app.FragmentTransition.startTransitions(FragmentTransition.java:136)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2385)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2333)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2230)
at androidx.fragment.app.FragmentManager$3.run(FragmentManager.java:414)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7037)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)

Works fine with alpha01.

Have a nice day !

Comments

[Deleted User] <[Deleted User]> #2Sep 9, 2019 11:57AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

jb...@google.com <jb...@google.com> #3Sep 9, 2019 06:17PM

Assigned to jb...@google.com.

Great! Thanks a lot, I'll look for the live updates soon!

[Deleted User] <[Deleted User]> #4Sep 9, 2019 06:21PM

Thanks !

ap...@google.com <ap...@google.com> #5Sep 12, 2019 04:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 10e8b488eb239d6a4b92d435c763c764b33e005e
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 10 08:50:31 2019

Update Transition library to 1.3.0-alpha03

Test: ./gradlew checkApi
BUG: 140680619
Change-Id: Ic34228e983f7043b7eb9ee062fd5f80fbd2d8ba3

M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
A transition/transition/api/1.3.0-alpha03.txt
A transition/transition/api/public_plus_experimental_1.3.0-alpha03.txt
A transition/transition/api/res-1.3.0-alpha03.txt

https://android-review.googlesource.com/1119837

https://goto.google.com/android-sha1/10e8b488eb239d6a4b92d435c763c764b33e005e

ap...@google.com <ap...@google.com> #6Sep 16, 2019 07:56PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 900fa5745610ff26178e36625f819ee619029e63
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 10 02:10:35 2019

Move to TOT Fragments for transitions

Test: ./gradlew bOS
BUG: 140680619
Change-Id: Iae7788e1fd5bebf1b949f874d5e3f51581d77126

M transition/transition/build.gradle

https://android-review.googlesource.com/1119838

https://goto.google.com/android-sha1/900fa5745610ff26178e36625f819ee619029e63

ap...@google.com <ap...@google.com> #7Sep 16, 2019 09:23PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bb8909f5befccff067eae16d474182ab1fb4fe28
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Sep 16 10:33:26 2019

Move StrictFragment and TargetTracking to testutils

Moving components to testutils to be shared between fragments and
transitions.

Test: all tests pass
BuG: 140680619
Change-Id: I26cb015ff150cf9508261d14636e70f0afa2b523

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimationTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/TrackingVisibility.java
M testutils/testutils-runtime/src/main/java/androidx/fragment/app/StrictFragment.kt
M testutils/testutils-runtime/src/main/java/androidx/fragment/app/TargetTracking.java

https://android-review.googlesource.com/1119839

https://goto.google.com/android-sha1/bb8909f5befccff067eae16d474182ab1fb4fe28

ap...@google.com <ap...@google.com> #8Sep 20, 2019 11:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 01f81f393d08eab98f76ee2ba8477fcd4d7050a9
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 20 15:32:28 2019

Use CancellationSignal instead of ExitAnimationCompleteMarker

There is no need to create our own cancellation API when
CancellationSignal works great for this usecase, and is a public
solutions. We should remove the ExitAnimationCompleteMarker interface
and replace it with CancellationSignal.

Test: all tests pass
BUG: 140680619
Change-Id: I421fa2370341a67ad45a9f36ae806da78200face

M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransition.java

https://android-review.googlesource.com/1125794

https://goto.google.com/android-sha1/01f81f393d08eab98f76ee2ba8477fcd4d7050a9

ap...@google.com <ap...@google.com> #9Sep 23, 2019 10:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5da219c2d359c9a9e339ccf206e0f6f51dfa6ab2
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 20 15:46:21 2019

Fix androidx transitions for Fragments

We should ensure that both androidx and support transitions work in
conjuction with Fragments. This change moves the
setListenerForTransitionEnd() method to FragmentTransitionImpl, then
implements overrides for the FragmentTransitionCompat21 and
FragmentTransitionSupport classes, so the two types of transitions can
be handled separately.

Test: added FragmentTransitionTests in previous CL
BUG: 140680619
Change-Id: I6fdda6609d8fe91d9f8618510495180572262a5b

M fragment/fragment/api/restricted_1.2.0-alpha05.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransition.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransitionCompat21.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransitionImpl.java
M transition/transition/src/main/java/androidx/transition/FragmentTransitionSupport.java

https://android-review.googlesource.com/1119841

https://goto.google.com/android-sha1/5da219c2d359c9a9e339ccf206e0f6f51dfa6ab2

ap...@google.com <ap...@google.com> #10Sep 23, 2019 10:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 366bb45ac5b9b06d1f6c9da0d94e825e093a4e7c
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Sep 16 13:29:48 2019

Add Fragment transition tests to androidx transitions

We should test fragment transitions for both androidx and support
transtions. This change copies over the transition tests from Fragments.

Test: this added tests
BUG: 140680619
Change-Id: I298535c1205686a75d205a65610af3fd43adeef8

M transition/transition/build.gradle
M transition/transition/src/androidTest/AndroidManifest.xml
A transition/transition/src/androidTest/java/androidx/transition/FragmentTestActivity.kt
A transition/transition/src/androidTest/java/androidx/transition/FragmentTestUtil.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionSupportTest.java
A transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionTest.kt
A transition/transition/src/androidTest/java/androidx/transition/TrackingTransition.kt
A transition/transition/src/androidTest/java/androidx/transition/TrackingVisibility.java
A transition/transition/src/androidTest/java/androidx/transition/TransitionFragment.kt
A transition/transition/src/androidTest/res/layout/activity_content.xml
A transition/transition/src/androidTest/res/layout/double_container.xml
A transition/transition/src/androidTest/res/layout/fragment_scene1.xml
A transition/transition/src/androidTest/res/layout/fragment_scene2.xml
A transition/transition/src/androidTest/res/layout/fragment_scene3.xml
A transition/transition/src/androidTest/res/layout/simple_container.xml
A transition/transition/src/androidTest/res/layout/strict_view_fragment.xml

https://android-review.googlesource.com/1119840

https://goto.google.com/android-sha1/366bb45ac5b9b06d1f6c9da0d94e825e093a4e7c

jb...@google.com <jb...@google.com> #11Sep 23, 2019 10:47PM

Marked as fixed.

This has been fixed internally and will be in available in the Fragment 1.2.0-beta01 release.

vi...@gmail.com <vi...@gmail.com> #12Oct 1, 2019 08:55AM

Hi. When will the release 1.2.0-beta01 be?

il...@google.com <il...@google.com> #13Oct 2, 2019 11:21PM

Should be ~next week.