Transition cast issue [140680619]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 9, 2019 10:59AM

Component used: Navigation
Version used:2.2.0-alpha02
Devices/Android versions reproduced on: All

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.

https://github.com/android/animation/blob/master/Motion/README.md (Also on my production project)

2019-09-09 12:57:19.033 27253-27253/com.example.android.motion E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.android.motion, PID: 27253
java.lang.ClassCastException: androidx.transition.TransitionSet cannot be cast to android.transition.Transition
at androidx.fragment.app.FragmentTransition.setListenerForTransitionEnd(FragmentTransition.java:307)
at androidx.fragment.app.FragmentTransition.configureTransitionsReordered(FragmentTransition.java:258)
at androidx.fragment.app.FragmentTransition.startTransitions(FragmentTransition.java:136)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2385)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2333)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2230)
at androidx.fragment.app.FragmentManager$3.run(FragmentManager.java:414)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7037)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)

Works fine with alpha01.

Have a nice day !

Comments

[Deleted User] <[Deleted User]> #2Sep 9, 2019 11:57AM

Please include a sample project that reproduces your issue.

jb...@google.com <jb...@google.com> #3Sep 9, 2019 06:17PM

Assigned to jb...@google.com.

Here is the sample project.

Steps to reproduce:
1. Press on "Search" icon;
2. Write something;
3. Search this text, keyboard will be dismissed;
4. Tap on "Dialog" button;
5. Dissmiss dialog;

With the new 1.5.0 fragment library version text will be cleared in the search box after dismissing dialog.
In the version 1.4.1 and lower text in the search is not clearing and this is correct behaviour.

Please suggest some workarounds or how to fix this issue?

[Deleted User] <[Deleted User]> #4Sep 9, 2019 06:21PM

Hello, have you checked sample project? I hope it will help find the issue.

ap...@google.com <ap...@google.com> #5Sep 12, 2019 04:35PM

@3
I've described a weird workaround that I got, here:

https://issuetracker.google.com/issues/244854449#comment3
Sample:

https://issuetracker.google.com/issues/244854449#comment4

It probably has bugs of its own that I didn't think of.
Google please fix this.

ap...@google.com <ap...@google.com> #6Sep 16, 2019 07:56PM

Hello, any update please?

ap...@google.com <ap...@google.com> #7Sep 16, 2019 09:23PM

Hello I raised similar issue with this ticket https://issuetracker.google.com/issues/249247706

This makes the SearchView unusable/broken when fragments are changed (i.e base on searchView input query)

What can we do to fix this problem? What is the progress of work on solving this problem?

ap...@google.com <ap...@google.com> #8Sep 20, 2019 11:39PM

@7 Check @5 for a workaround.

ap...@google.com <ap...@google.com> #9Sep 23, 2019 10:35PM

Hi, i am also facing this issue after we dismiss a DialogFragment, the callback comes in the onPrepareOptionsMenu(), which is causing the issues for me.
Any idea on when it will be fixed?

ap...@google.com <ap...@google.com> #10Sep 23, 2019 10:35PM

Hello, any estimate please?

jb...@google.com <jb...@google.com> #11Sep 23, 2019 10:47PM

Marked as fixed.

Facing a similar kind of issue when scrolling the fragments using a ViewPager.

https://issuetracker.google.com/issues/267677504

Can you update regarding any progress on this issue.

vi...@gmail.com <vi...@gmail.com> #12Oct 1, 2019 08:55AM

I wonder if the new SearchBar has this issue:

https://material.io/blog/android-stable-release-1-8-0

il...@google.com <il...@google.com> #13Oct 2, 2019 11:21PM

Project: platform/frameworks/support
Branch: androidx-main

commit 50f098644adc703ae218b0b7e999629f516a0241
Author: sanura <sanura@google.com>
Date: Thu Mar 02 00:11:35 2023

Add check to only invalidate options menu when contributing menu items

FragmentManager previously appropriately only added
a MenuProvider when the host is a MenuHost **and**
we are at the root fragment that is providing the
menu items. This behavior should be mirrored when
removing a MenuProvider as well, so that only
components that directly contribute menu items will
invalidate the options menu.

Bug: 244336571
Test: all tests pass
Change-Id: I9404ee9fcc9ce6b80d70a93bea720fe4ccf583a0

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerInflatedFragmentTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/OptionsMenuFragmentTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/FragmentTestActivity.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/2465169